From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3A3A1A00C5;
	Thu, 25 Aug 2022 09:48:03 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id CE1C040DFD;
	Thu, 25 Aug 2022 09:48:02 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 85ADC40156
 for <dev@dpdk.org>; Thu, 25 Aug 2022 09:48:01 +0200 (CEST)
Content-class: urn:content-classes:message
Subject: RE: [PATCH v2 0/3] Add lcore poll busyness telemetry
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Date: Thu, 25 Aug 2022 09:47:59 +0200
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D872AB@smartserver.smartshare.dk>
X-MimeOLE: Produced By Microsoft Exchange V6.5
In-Reply-To: <20220824162442.631456-1-kevin.laatz@intel.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v2 0/3] Add lcore poll busyness telemetry
Thread-Index: Adi31cpwgwMDtzLoReCtrqZ4TzpMFAAf06Og
References: <24c49429394294cfbf0d9c506b205029bac77c8b.1657890378.git.anatoly.burakov@intel.com>
 <20220824162442.631456-1-kevin.laatz@intel.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Kevin Laatz" <kevin.laatz@intel.com>,
	<dev@dpdk.org>
Cc: <anatoly.burakov@intel.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Kevin Laatz [mailto:kevin.laatz@intel.com]
> Sent: Wednesday, 24 August 2022 18.25
>=20
> Currently, there is no way to measure lcore busyness in a passive way,
> without any modifications to the application. This patchset adds a new
> EAL
> API that will be able to passively track core busyness. As part of the
> set,
> new telemetry endpoints are added to read the generate metrics.
>=20
> Anatoly Burakov (2):
>   eal: add lcore poll busyness telemetry
>   eal: add cpuset lcore telemetry entries
>=20
> Kevin Laatz (1):
>   doc: add howto guide for lcore poll busyness
>=20

At first glance, reading the commit messages, I thought you had ignored =
the feedback.
However, I see that V2 adds "poll" in front of "busyness".

It's just missing in many locations in the code, e.g. in =
eal_common_lcore_telemetry.c, the telemetry command is still registered =
as "/eal/lcore/busyness".

I recommend that you search for "business" in the files, and add "poll" =
where it is missing.

Perhaps one of your testers can do it for you... I know from experience =
that it can be difficult spotting details like this in your own code, =
whereas many test people are good at this stuff. There's even a company =
here in Denmark offering autistics as testers - they are absolutely =
brilliant at tasks like this!

-Morten