From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2139CA0542;
	Mon, 29 Aug 2022 20:57:56 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BD0954069D;
	Mon, 29 Aug 2022 20:57:55 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id D9D524003C
 for <dev@dpdk.org>; Mon, 29 Aug 2022 20:57:54 +0200 (CEST)
Content-class: urn:content-classes:message
Subject: RE: [RFC PATCH 1/3] os: begin separating some OS compatibility from
 EAL
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Date: Mon, 29 Aug 2022 20:57:53 +0200
X-MimeOLE: Produced By Microsoft Exchange V6.5
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D872D2@smartserver.smartshare.dk>
In-Reply-To: <20220829151901.376754-2-bruce.richardson@intel.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [RFC PATCH 1/3] os: begin separating some OS compatibility from
 EAL
Thread-Index: Adi7urxOV0X29F03QLWxuKN/xnARzAAHQC4w
References: <20220829151901.376754-1-bruce.richardson@intel.com>
 <20220829151901.376754-2-bruce.richardson@intel.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Bruce Richardson" <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> Sent: Monday, 29 August 2022 17.19
> To: dev@dpdk.org
> Cc: Bruce Richardson
> Subject: [RFC PATCH 1/3] os: begin separating some OS compatibility
> from EAL
>=20
> Some library functionality we may want ahead of EAL build depends upon
> some OS-specific functionality, so we create a new lib for that to be
> built separately. For now, just includes fnmatch function for windows.

The description given in patch 0/3 mentions that this causes a circular =
dependency between the EAL and Log libraries. You should mention that =
here too. Until I re-read that, I didn't understand the need to move =
fnmatch() out of the EAL library - I was even sidetracking wildly, =
considering if it had to do with needing it on the host computer (for =
some host compiler checks).

FYI, and not important: fnmatch() is a C library function (man 3), not a =
System call (man 2). But obviously still O/S specific, since it is not =
included with the C library for Windows.