From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40283A00C4; Thu, 29 Sep 2022 13:16:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32EFE41156; Thu, 29 Sep 2022 13:16:24 +0200 (CEST) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id ED2E6427F5 for ; Thu, 29 Sep 2022 13:16:22 +0200 (CEST) X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH] metrics: return error code on initialization failures Date: Thu, 29 Sep 2022 13:16:21 +0200 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D8736D@smartserver.smartshare.dk> In-Reply-To: <20220929093829.10218-1-bruce.richardson@intel.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] metrics: return error code on initialization failures Thread-Index: AdjT50c0d4dzxIPaRKyc003B9luWiQADXv+w References: <20220929093829.10218-1-bruce.richardson@intel.com> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Bruce Richardson" , Cc: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > Sent: Thursday, 29 September 2022 11.38 >=20 > DPDK libraries should never call rte_exit on failure, so change the > function return type of rte_metrics_init to "int" to allow returning = an > error code to the application rather than exiting the whole app on = init > failure. >=20 > Signed-off-by: Bruce Richardson > --- Plain and simple is always good. :-) Acked-by: Morten Br=F8rup