From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 20B74A00C2;
	Thu,  6 Oct 2022 18:03:23 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BA10140A82;
	Thu,  6 Oct 2022 18:03:22 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 6CCF440697
 for <dev@dpdk.org>; Thu,  6 Oct 2022 18:03:21 +0200 (CEST)
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v3 1/4] ethdev: add trace points
Date: Thu, 6 Oct 2022 18:03:20 +0200
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D873AB@smartserver.smartshare.dk>
In-Reply-To: <20221006151844.23483-2-adwivedi@marvell.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v3 1/4] ethdev: add trace points
Thread-Index: AdjZl2kTlGPCNdLSR+afvyKvrBpzegAA1q2A
References: <20220929102936.5490-1-adwivedi@marvell.com>
 <20221006151844.23483-1-adwivedi@marvell.com>
 <20221006151844.23483-2-adwivedi@marvell.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Ankur Dwivedi" <adwivedi@marvell.com>,
	<dev@dpdk.org>
Cc: <thomas@monjalon.net>, <mdr@ashroe.eu>, <orika@nvidia.com>,
 <ferruh.yigit@xilinx.com>, <chas3@att.com>, <humin29@huawei.com>,
 <linville@tuxdriver.com>, <ciara.loftus@intel.com>, <qi.z.zhang@intel.com>,
 <mw@semihalf.com>, <mk@semihalf.com>, <shaibran@amazon.com>,
 <evgenys@amazon.com>, <igorch@amazon.com>, <chandu@amd.com>,
 <irusskikh@marvell.com>, <shepard.siegel@atomicrules.com>,
 <ed.czeck@atomicrules.com>, <john.miller@atomicrules.com>,
 <ajit.khaparde@broadcom.com>, <somnath.kotur@broadcom.com>,
 <jerinj@marvell.com>, <mczekaj@marvell.com>, <sthotton@marvell.com>,
 <srinivasan@marvell.com>, <hkalra@marvell.com>,
 <rahul.lakkireddy@chelsio.com>, <johndale@cisco.com>, <hyonkim@cisco.com>,
 <liudongdong3@huawei.com>, <yisen.zhuang@huawei.com>,
 <xuanziyang2@huawei.com>, <cloud.wangxiaoyun@huawei.com>,
 <zhouguoyang@huawei.com>, <simei.su@intel.com>, <wenjun1.wu@intel.com>,
 <qiming.yang@intel.com>, <Yuying.Zhang@intel.com>, <beilei.xing@intel.com>,
 <xiao.w.wang@intel.com>, <jingjing.wu@intel.com>, <junfeng.guo@intel.com>,
 <rosen.xu@intel.com>, <ndabilpuram@marvell.com>, <kirankumark@marvell.com>,
 <skori@marvell.com>, <skoteshwar@marvell.com>, <lironh@marvell.com>,
 <zr@semihalf.com>, <radhac@marvell.com>, <vburru@marvell.com>,
 <sedara@marvell.com>, <matan@nvidia.com>, <viacheslavo@nvidia.com>,
 <sthemmin@microsoft.com>, <longli@microsoft.com>, <spinler@cesnet.cz>,
 <chaoyong.he@corigine.com>, <niklas.soderlund@corigine.com>,
 <hemant.agrawal@nxp.com>, <sachin.saxena@oss.nxp.com>, <g.singh@nxp.com>,
 <apeksha.gupta@nxp.com>, <sachin.saxena@nxp.com>, <aboyer@pensando.io>,
 <rmody@marvell.com>, <shshaikh@marvell.com>, <dsinghrawat@marvell.com>,
 <andrew.rybchenko@oktetlabs.ru>, <jiawenwu@trustnetic.com>,
 <jianwang@trustnetic.com>, <jbehrens@vmware.com>,
 <maxime.coquelin@redhat.com>, <chenbo.xia@intel.com>,
 <steven.webster@windriver.com>, <matt.peters@windriver.com>,
 <bruce.richardson@intel.com>, <mtetsuyah@gmail.com>, <grive@u256.net>,
 <jasvinder.singh@intel.com>, <cristian.dumitrescu@intel.com>,
 <jgrajcia@cisco.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Ankur Dwivedi [mailto:adwivedi@marvell.com]
> Sent: Thursday, 6 October 2022 17.19
>=20
> Add trace points for ethdev functions.
>=20
> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> ---

I did my best, but this series needs review by people with direct =
knowledge about the affected functions.

rte_eth_call_rx/tx_callbacks() are treated as fast path functions, but I =
think more functions should be too:


rte_eth_tx_buffer_drop_callback() and rte_eth_tx_buffer_count_callback() =
are certainly fast path functions.

rte_eth_tx_done_cleanup()probably is too.

rte_eth_macaddr_get() could be, but probably isn't. If treated as slow =
path, it could be noted in its documentation.

I don't know about rte_eth_timesync_read_rx/tx_timestamp(), =
rte_eth_timesync_adjust/read/write_time() and rte_eth_read_clock().