DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Jerin Jacob" <jerinj@marvell.com>
Cc: <dev@dpdk.org>, "Li, WeiyuanX" <weiyuanx.li@intel.com>,
	"Thomas Monjalon" <thomas@monjalon.net>,
	"Ferruh Yigit" <ferruh.yigit@amd.com>,
	"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>
Subject: rte_event_dev_xstats_reset id type
Date: Wed, 12 Oct 2022 10:10:28 +0200	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D873D4@smartserver.smartshare.dk> (raw)

Hi Jerin (eventdev maintainer),

While looking into bug #1101 [1], I noticed a mix of unsigned int and uint32_t in the test code, which will fail on 64-bit big endian CPUs.

Specifically, rte_event_dev_xstats_reset() is called with the "ids" parameter pointing to an unsigned int [2], but that parameter is a pointer to an uint32_t.

I think the type of the ids array parameter to rte_event_dev_xstats_reset() should be changed to unsigned int array, like in the other rte_event_dev_xxx() functions.

Or even better, use the same type for an "xstats id" across all device types. For ethdev devices, they are uint64_t, but I don't know why. (They are passed around as arrays, so they could be 32 bit. I guess that they were originally not used in arrays, so unsigned int seemed the logical choice.)


[1]: https://bugs.dpdk.org/show_bug.cgi?id=1101
[2]: https://git.dpdk.org/dpdk/tree/drivers/event/sw/sw_evdev_selftest.c#n1766


Med venlig hilsen / Kind regards,
-Morten Brørup


             reply	other threads:[~2022-10-12  8:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12  8:10 Morten Brørup [this message]
2022-10-12  9:45 ` Jerin Jacob
2022-10-12 10:29   ` Van Haaren, Harry
2022-10-12 10:41     ` Morten Brørup
2022-10-12 12:14       ` Van Haaren, Harry
2022-10-12 15:13         ` Thomas Monjalon
2022-10-12 15:35           ` Morten Brørup
2022-10-12 16:16             ` Jerin Jacob
2022-10-12 16:28               ` Thomas Monjalon
2022-10-12 16:47                 ` Jerin Jacob
2022-10-12 20:44                   ` Thomas Monjalon
2022-10-13  6:51                     ` xstats " Morten Brørup
2022-10-13  7:12                       ` Pavan Nikhilesh Bhagavatula
2022-10-13  8:26                         ` Thomas Monjalon
2022-10-13  8:33                           ` [EXT] " Pavan Nikhilesh Bhagavatula
2022-10-13  8:59                         ` Van Haaren, Harry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D873D4@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=jerinj@marvell.com \
    --cc=thomas@monjalon.net \
    --cc=weiyuanx.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).