From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E3D29A0547;
	Wed, 12 Oct 2022 10:10:32 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D8B2242F3B;
	Wed, 12 Oct 2022 10:10:32 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id C14A242ECF
 for <dev@dpdk.org>; Wed, 12 Oct 2022 10:10:30 +0200 (CEST)
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: rte_event_dev_xstats_reset id type
Date: Wed, 12 Oct 2022 10:10:28 +0200
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D873D4@smartserver.smartshare.dk>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: rte_event_dev_xstats_reset id type
Thread-Index: AdjeEhbtoOQJQgFzRxCUoDaj0Sr2kA==
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Jerin Jacob" <jerinj@marvell.com>
Cc: <dev@dpdk.org>, "Li, WeiyuanX" <weiyuanx.li@intel.com>,
 "Thomas Monjalon" <thomas@monjalon.net>,
 "Ferruh Yigit" <ferruh.yigit@amd.com>,
 "Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi Jerin (eventdev maintainer),

While looking into bug #1101 [1], I noticed a mix of unsigned int and =
uint32_t in the test code, which will fail on 64-bit big endian CPUs.

Specifically, rte_event_dev_xstats_reset() is called with the "ids" =
parameter pointing to an unsigned int [2], but that parameter is a =
pointer to an uint32_t.

I think the type of the ids array parameter to =
rte_event_dev_xstats_reset() should be changed to unsigned int array, =
like in the other rte_event_dev_xxx() functions.

Or even better, use the same type for an "xstats id" across all device =
types. For ethdev devices, they are uint64_t, but I don't know why. =
(They are passed around as arrays, so they could be 32 bit. I guess that =
they were originally not used in arrays, so unsigned int seemed the =
logical choice.)


[1]: https://bugs.dpdk.org/show_bug.cgi?id=3D1101
[2]: =
https://git.dpdk.org/dpdk/tree/drivers/event/sw/sw_evdev_selftest.c#n1766=



Med venlig hilsen / Kind regards,
-Morten Br=F8rup