From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 57062A0093;
	Mon, 28 Nov 2022 18:22:13 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id F23C24067E;
	Mon, 28 Nov 2022 18:22:12 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 69AB540150
 for <dev@dpdk.org>; Mon, 28 Nov 2022 18:22:11 +0100 (CET)
Content-class: urn:content-classes:message
Subject: RE: [PATCH v2 1/2] eal: provide leading and trailing zero bit count
 abstraction
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Date: Mon, 28 Nov 2022 18:22:10 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87520@smartserver.smartshare.dk>
X-MimeOLE: Produced By Microsoft Exchange V6.5
In-Reply-To: <20221128171332.GA28869@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v2 1/2] eal: provide leading and trailing zero bit count
 abstraction
Thread-Index: AdkDTMGiD/kEW+qsSVSWIBUmHKNvVwAAEbTA
References: <1669241687-18810-1-git-send-email-roretzla@linux.microsoft.com>
 <1669246997-30592-1-git-send-email-roretzla@linux.microsoft.com>
 <1669246997-30592-2-git-send-email-roretzla@linux.microsoft.com>
 <98CBD80474FA8B44BF855DF32C47DC35D874F9@smartserver.smartshare.dk>
 <20221128171332.GA28869@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Tyler Retzlaff" <roretzla@linux.microsoft.com>
Cc: <dev@dpdk.org>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> Sent: Monday, 28 November 2022 18.14
>=20
> On Thu, Nov 24, 2022 at 11:17:23AM +0100, Morten Br=F8rup wrote:
> > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> > > Sent: Thursday, 24 November 2022 00.43
> > >
> > > Provide an abstraction for leading and trailing zero bit counting
> > > functions to hide compiler specific intrinsics and builtins.
> > >
> > > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > > ---
> >
>=20
> let me unpack what is being asked for here.
>=20
> > Related functions already exist in lib/eal/include/rte_common.h.
>=20
> i don't understand. are you saying these inline functions duplicate
> existing bit counting functionality? if so i'll relocate any you
> identify.

Sorry about not being clear about my intentions with the feedback.

I'm not asking for anything; I only wanted to point at the similar =
family of functions in rte_common.h, to make sure that you were aware of =
them.

>=20
> >
> > If some functions are missing, it would be good to add them.
>=20
> the change here is to address a specific family of functions that are
> impeding portability of the rte_common.h header and nothing more.
>=20
> i'm open to having a separate mail thread discussing what other
> functions we might want and whether to relocate code out of
> rte_common.h
> since that is likely to be a drawn out discussion it shouldn't be a
> blocking dependency of this series.

I do not request any new functions; I'll leave it up to you to decide if =
anything would be good to add.

>=20
> >
> > Also, it makes sense moving them out of rte_common.h.
>=20
> thanks!

Thank you! Cleaning up is always appreciated.