DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Thomas Monjalon" <thomas@monjalon.net>,
	"Tyler Retzlaff" <roretzla@linux.microsoft.com>
Cc: "Stephen Hemminger" <stephen@networkplumber.org>, <dev@dpdk.org>,
	<david.marchand@redhat.com>,
	"Bruce Richardson" <bruce.richardson@intel.com>
Subject: RE: help with pthread_t deprecation / api changes
Date: Tue, 13 Dec 2022 21:39:24 +0100	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87595@smartserver.smartshare.dk> (raw)
In-Reply-To: <3905723.ZaRXLXkqSa@thomas>

> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Tuesday, 13 December 2022 20.34
> 
> 13/12/2022 18:38, Tyler Retzlaff:
> > Okay, just one final confirmation. This is what we would like?
> >
> > * completely remove the existing rte_thread_getname api.
> >     - by implication this means remove the 1 use of it in eal in
> >       logging.
> >
> > * introduce a new void rte_thread_set_name(rte_thread_t, const char
> *name)
> >   that:
> >     - returns void (does not fail), but in cases it can be detected
> will
> >       log a DEBUG level log message.
> >     - quietly truncates the name (if longer) to
> RTE_MAX_THREAD_NAME_LEN on
> >       all platforms.

Consider also DEBUG logging if truncating the name. Your choice - do or don't is fine with me.

> >     - document that it is best effort and only works if the stars
> align
> >       for the target platform.
> >
> > * there will be no unit test, since the set doesn't fail and there is
> no
> >   get to validate the set.
> >
> > once i get confirmation i'll update the series.
> 
> Just my opinion: this proposal is my preference, yes.
> What others think?

LGTM.


  reply	other threads:[~2022-12-13 20:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30 22:54 Tyler Retzlaff
2022-12-02  1:12 ` Tyler Retzlaff
2022-12-02  8:03   ` Morten Brørup
2022-12-02 19:57     ` Tyler Retzlaff
2022-12-09  7:53       ` Thomas Monjalon
2022-12-09 16:48         ` Stephen Hemminger
2022-12-09 20:06           ` Tyler Retzlaff
2022-12-09 21:13             ` Thomas Monjalon
2022-12-09 23:49               ` Tyler Retzlaff
2022-12-11  7:50                 ` Thomas Monjalon
2022-12-12 17:45                   ` Tyler Retzlaff
2022-12-13  8:32                     ` Thomas Monjalon
2022-12-13 17:38                       ` Tyler Retzlaff
2022-12-13 19:34                         ` Thomas Monjalon
2022-12-13 20:39                           ` Morten Brørup [this message]
2022-12-14  0:16                             ` Tyler Retzlaff
2022-12-09 21:14           ` Thomas Monjalon
2022-12-09 22:38             ` Stephen Hemminger
2022-12-09 23:55               ` Tyler Retzlaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D87595@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=roretzla@linux.microsoft.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).