DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] net/ixgbe: fix ixgbe firmware version get
@ 2023-01-04  9:51 Shiyang He
  2023-01-04 10:18 ` Morten Brørup
  2023-01-09  6:53 ` [PATCH v2] net/ixgbe: fix ixgbe firmware version inconsistency Shiyang He
  0 siblings, 2 replies; 8+ messages in thread
From: Shiyang He @ 2023-01-04  9:51 UTC (permalink / raw)
  To: dev; +Cc: yidingx.zhou, Shiyang He, stable, Qiming Yang, Wenjun Wu, Remy Horton

The firmware version obtained by dpdk-ethtool is inconsistent with that
obtained by linux-ethtool.

This commit fixes the issue.

Fixes: 8b0b56574269 ("net/ixgbe: add firmware version get")
Cc: stable@dpdk.org

Signed-off-by: Shiyang He <shiyangx.he@intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index ae9f65b334..012096021e 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -3859,7 +3859,7 @@ ixgbe_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size)
 	ixgbe_read_eeprom(hw, 0x2e, &eeprom_verh);
 	ixgbe_read_eeprom(hw, 0x2d, &eeprom_verl);
 
-	etrack_id = (eeprom_verh << 16) | eeprom_verl;
+	etrack_id = (eeprom_verl << 16) | eeprom_verh;
 	ret = snprintf(fw_version, fw_size, "0x%08x", etrack_id);
 	if (ret < 0)
 		return -EINVAL;
-- 
2.34.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2023-01-16  8:04 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-04  9:51 [PATCH] net/ixgbe: fix ixgbe firmware version get Shiyang He
2023-01-04 10:18 ` Morten Brørup
2023-01-05  2:52   ` He, ShiyangX
2023-01-05  6:57     ` Morten Brørup
2023-01-05  7:33       ` He, ShiyangX
2023-01-09  6:53 ` [PATCH v2] net/ixgbe: fix ixgbe firmware version inconsistency Shiyang He
2023-01-09  7:47   ` Morten Brørup
2023-01-16  8:04     ` Zhang, Qi Z

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).