From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33BC0423B8; Thu, 12 Jan 2023 16:06:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2411C40E25; Thu, 12 Jan 2023 16:06:17 +0100 (CET) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 4B4C740DDC for ; Thu, 12 Jan 2023 16:06:16 +0100 (CET) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [RFC PATCH 1/1] build: increase minimum C standard for DPDK builds Date: Thu, 12 Jan 2023 16:06:11 +0100 X-MimeOLE: Produced By Microsoft Exchange V6.5 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D8766B@smartserver.smartshare.dk> In-Reply-To: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [RFC PATCH 1/1] build: increase minimum C standard for DPDK builds Thread-Index: AdkmhBHk/IX9aFmIQEGhKAzhf3qDBgAEcUBw References: <20230112113556.47485-1-bruce.richardson@intel.com> <20230112113556.47485-2-bruce.richardson@intel.com> <98CBD80474FA8B44BF855DF32C47DC35D8766A@smartserver.smartshare.dk> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Bruce Richardson" Cc: , , , X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > Sent: Thursday, 12 January 2023 13.47 >=20 > On Thu, Jan 12, 2023 at 01:42:48PM +0100, Morten Br=F8rup wrote: > > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > > Sent: Thursday, 12 January 2023 12.36 > > > > > > Set the default C language standard to be used for DPDK builds to > C99. > > > This requires no actual code changes to build successfully. > > > > Great! > > > > > > > > To ensure compatibility is kept for external apps using DPDK > headers, > > > we > > > explicitly set the build parameters for the chkincs binary to the > old > > > minimum standard of "gnu89". [NOTE: DPDK code does not compile and > has > > > previously not compiled for pure c89 standard, so that stricter > > > requirement need not be checked.] By adding this additional check, > we > > > can separately manage C standards used internally in DPDK builds > and > > > that required in the build flags for external apps using DPDK. > > > > It seems I have to accept this techboard decision for now. ;-) > > > There is no techboard decision here - certainly not yet. There is > plenty of > discussion still to be had. However, for now this RFC is being very > conservative - perhaps overly so. Yeah, perhaps I was phrasing that somewhat emotionally loaded. :-) I didn't mean to cause confusion on the mailing list. Thanks for = clarifying, Bruce.