From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E8A98423E0;
	Sun, 15 Jan 2023 08:58:21 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BBED340156;
	Sun, 15 Jan 2023 08:58:21 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id CF44440042
 for <dev@dpdk.org>; Sun, 15 Jan 2023 08:58:20 +0100 (CET)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v12 1/6] memarea: introduce memarea library
Date: Sun, 15 Jan 2023 08:58:15 +0100
X-MimeOLE: Produced By Microsoft Exchange V6.5
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87672@smartserver.smartshare.dk>
In-Reply-To: <20230114114944.42194-2-fengchengwen@huawei.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v12 1/6] memarea: introduce memarea library
Thread-Index: AdkoDmU2FYlclxSfRnyi1PIUXM1SVgAp2/xQ
References: <20220721044648.6817-1-fengchengwen@huawei.com>
 <20230114114944.42194-1-fengchengwen@huawei.com>
 <20230114114944.42194-2-fengchengwen@huawei.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Chengwen Feng" <fengchengwen@huawei.com>, <david.marchand@redhat.com>,
 <anatoly.burakov@intel.com>, <dmitry.kozliuk@gmail.com>,
 <jerinjacobk@gmail.com>, <hofors@lysator.liu.se>, <liudongdong3@huawei.com>
Cc: <thomas@monjalon.net>,
	<dev@dpdk.org>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Chengwen Feng [mailto:fengchengwen@huawei.com]
> Sent: Saturday, 14 January 2023 12.50
>=20
> The memarea library is an allocator of variable-size object which =
based
> on a memory region.
>=20
> This patch provides rte_memarea_create() and rte_memarea_destroy() =
API.
>=20
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Reviewed-by: Dongdong Liu <liudongdong3@huawei.com>
> ---

[...]

> +struct memarea_obj {
> +	TAILQ_ENTRY(memarea_obj) obj_node;
> +	TAILQ_ENTRY(memarea_obj) free_node;
> +	size_t                   size;
> +	size_t                   alloc_size;
> +	uint32_t                 magic;
> +};

The magic cookie is for debug purposes only, and should be enclosed by =
#ifdef RTE_LIBRTE_MEMAREA_DEBUG, like in the mempool library [1].

[1]: =
https://elixir.bootlin.com/dpdk/latest/source/lib/mempool/rte_mempool.h#L=
154

With that added:

Series-acked-by: Morten Br=F8rup <mb@smartsharesystems.com>