From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Robin Jarry" <rjarry@redhat.com>, <dev@dpdk.org>
Cc: "Ciara Power" <ciara.power@intel.com>,
"Tyler Retzlaff" <roretzla@linux.microsoft.com>,
"Bruce Richardson" <bruce.richardson@intel.com>
Subject: RE: [PATCH] telemetry: fix docstring of RTE_TEL_INT_VAL
Date: Tue, 7 Feb 2023 10:51:15 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87709@smartserver.smartshare.dk> (raw)
In-Reply-To: <20230207084636.1079996-1-rjarry@redhat.com>
> From: Robin Jarry [mailto:rjarry@redhat.com]
> Sent: Tuesday, 7 February 2023 09.47
>
> The doc string was left to its previous definition. Make it explicit
> that RTE_TEL_INT_VAL is a 64-bit signed integer.
>
> Fixes: 8e639c7c50cc ("telemetry: use 64-bit signed values in API")
>
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
> ---
> lib/telemetry/rte_telemetry.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/telemetry/rte_telemetry.h
> b/lib/telemetry/rte_telemetry.h
> index ad712732be04..d8ea97f17395 100644
> --- a/lib/telemetry/rte_telemetry.h
> +++ b/lib/telemetry/rte_telemetry.h
> @@ -43,7 +43,7 @@ struct rte_tel_data;
> */
> enum rte_tel_value_type {
> RTE_TEL_STRING_VAL, /** a string value */
> - RTE_TEL_INT_VAL, /** a signed 32-bit int value */
> + RTE_TEL_INT_VAL, /** a signed 64-bit int value */
> RTE_TEL_UINT_VAL, /** an unsigned 64-bit int value */
> RTE_TEL_CONTAINER, /** a container struct */
> };
> --
> 2.39.1
>
Yes, this value type has changed as the comment reflects.
We could consider adding a note that the value does not exceed 32-bit when using API version 23, because the "set" functions in API version 23 only take a 32-bit value parameter. But such a note will be purely informative, and would probably add more confusion than information.
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
next prev parent reply other threads:[~2023-02-07 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 8:46 Robin Jarry
2023-02-07 9:51 ` Morten Brørup [this message]
2023-02-07 10:05 ` Bruce Richardson
2023-02-09 9:18 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D87709@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=rjarry@redhat.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).