From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C55C741C5D; Fri, 10 Feb 2023 08:28:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52A6840EE6; Fri, 10 Feb 2023 08:28:40 +0100 (CET) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id E8FEB40EE3 for ; Fri, 10 Feb 2023 08:28:38 +0100 (CET) X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH v2 1/2] net/i40e: replace put function Date: Fri, 10 Feb 2023 08:28:35 +0100 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87728@smartserver.smartshare.dk> In-Reply-To: <20230210065407.209567-2-kamalakshitha.aligeri@arm.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH v2 1/2] net/i40e: replace put function Thread-Index: Adk9HI27debauMtVS4+AhJ0xPBQjfwAAtueQ References: <20230209062501.142828-1-kamalakshitha.aligeri@arm.com> <20230210065407.209567-1-kamalakshitha.aligeri@arm.com> <20230210065407.209567-2-kamalakshitha.aligeri@arm.com> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Kamalakshitha Aligeri" , , , , , , , , , Cc: , X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Kamalakshitha Aligeri [mailto:kamalakshitha.aligeri@arm.com] > Sent: Friday, 10 February 2023 07.54 >=20 > Integrated zero-copy put API in mempool cache in i40e PMD. > On Ampere Altra server, l3fwd single core's performance improves by 5% > with the new API >=20 > Signed-off-by: Kamalakshitha Aligeri > Reviewed-by: Ruifeng Wang > Reviewed-by: Feifei Wang > --- > Link: > https://patchwork.dpdk.org/project/dpdk/patch/20230209145833.129986-1- > mb@smartsharesystems.com/ If you agree with the referred patch, please review or acknowledge it on = the mailing list, so it can be merged. >=20 > .mailmap | 1 + > drivers/net/i40e/i40e_rxtx_vec_common.h | 28 = ++++++++++++++++++++----- > 2 files changed, 24 insertions(+), 5 deletions(-) >=20 > diff --git a/.mailmap b/.mailmap > index 75884b6fe2..05a42edbcf 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -670,6 +670,7 @@ Kai Ji > Kaiwen Deng > Kalesh AP > Kamalakannan R > +Kamalakshitha Aligeri > Kamil Bednarczyk > Kamil Chalupnik > Kamil Rytarowski > diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h > b/drivers/net/i40e/i40e_rxtx_vec_common.h > index fe1a6ec75e..113599d82b 100644 > --- a/drivers/net/i40e/i40e_rxtx_vec_common.h > +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h > @@ -95,18 +95,36 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq) >=20 > n =3D txq->tx_rs_thresh; >=20 > - /* first buffer to free from S/W ring is at index > - * tx_next_dd - (tx_rs_thresh-1) > - */ > + /* first buffer to free from S/W ring is at index > + * tx_next_dd - (tx_rs_thresh-1) > + */ > txep =3D &txq->sw_ring[txq->tx_next_dd - (n - 1)]; >=20 > if (txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) { > + struct rte_mempool *mp =3D txep[0].mbuf->pool; > + struct rte_mempool_cache *cache =3D > rte_mempool_default_cache(mp, rte_lcore_id()); > + void **cache_objs; > + > + if (unlikely(!cache)) > + goto fallback; > + > + cache_objs =3D rte_mempool_cache_zc_put_bulk(cache, mp, n); > + if (unlikely(!cache_objs)) > + goto fallback; > + > for (i =3D 0; i < n; i++) { > - free[i] =3D txep[i].mbuf; > + cache_objs[i] =3D txep->mbuf; > /* no need to reset txep[i].mbuf in vector path */ > + txep++; Why the change from "xyz[i] =3D txep[i].mbuf;" to "xyz[i] =3D = txep->mbuf; txep++;"? I don't see "txep" being used after the "done" = label. And at the fallback, you still use "xyz[i] =3D txep[i].mbuf;". It = would look cleaner using the same method in both places. It's not important, so feel free to keep as is or change as suggested. = Both ways, Acked-by: Morten Br=F8rup > } > - rte_mempool_put_bulk(free[0]->pool, (void **)free, n); > goto done; > + > +fallback: > + for (i =3D 0; i < n; i++) > + free[i] =3D txep[i].mbuf; > + rte_mempool_generic_put(mp, (void **)free, n, cache); > + goto done; > + > } >=20 > m =3D rte_pktmbuf_prefree_seg(txep[0].mbuf); > -- > 2.25.1 >=20