From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5A702428CE;
	Tue,  4 Apr 2023 16:57:44 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 4A56841156;
	Tue,  4 Apr 2023 16:57:44 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 0989241153
 for <dev@dpdk.org>; Tue,  4 Apr 2023 16:57:42 +0200 (CEST)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc
Date: Tue, 4 Apr 2023 16:57:41 +0200
X-MimeOLE: Produced By Microsoft Exchange V6.5
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87857@smartserver.smartshare.dk>
In-Reply-To: <754a877d020a4a199a5310b469e876a7@huawei.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc
Thread-Index: AQHZZnap0PZ0bua2nE60okV7Fqc0Ma8bDxDwgAAq7rA=
References: <1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com>
 <1680558751-17931-4-git-send-email-roretzla@linux.microsoft.com>
 <754a877d020a4a199a5310b469e876a7@huawei.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Konstantin Ananyev" <konstantin.ananyev@huawei.com>,
 "Tyler Retzlaff" <roretzla@linux.microsoft.com>, <dev@dpdk.org>
Cc: <bruce.richardson@intel.com>, <david.marchand@redhat.com>,
 <thomas@monjalon.net>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Konstantin Ananyev [mailto:konstantin.ananyev@huawei.com]
> Sent: Tuesday, 4 April 2023 14.11

[...]

> Another ore generic comment - do we really need to pollute all that =
code with
> RTE_TOOLCHAIN_MSVC ifdefs?
> Right now we have ability to have subdir per arch (x86/arm/etc.).
> Can we treat x86+windows+msvc as a special arch?

I disagree with the per-arch suggestion.

We should have arch directories in EAL only, where the differences are =
significant.

Anything else, such as drivers and libraries, should be allowed to =
implement architecture and compiler specific variants using #ifdef or =
subdirectories/-files as the developer deems appropriate, i.e. #ifdef =
for few/minor variations, and subfiles or -directories for larger =
variations.

Multi-architecture code is voluminous, but I don't want separate files =
for only small variations.

It would be nice to agree on some official guidance on this for the =
coding guidelines.