From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CAA3142941;
	Fri, 14 Apr 2023 14:46:54 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AB9BE40144;
	Fri, 14 Apr 2023 14:46:54 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 19A40400D5
 for <dev@dpdk.org>; Fri, 14 Apr 2023 14:46:53 +0200 (CEST)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v2] dmadev: add tracepoints
Date: Fri, 14 Apr 2023 14:46:51 +0200
X-MimeOLE: Produced By Microsoft Exchange V6.5
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D8787A@smartserver.smartshare.dk>
In-Reply-To: <20230414090901.32164-1-fengchengwen@huawei.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v2] dmadev: add tracepoints
Thread-Index: AdluscXfsp0RegvaQ0CDKrYCeZH32AAHHT6A
References: <20230414090901.32164-1-fengchengwen@huawei.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Chengwen Feng" <fengchengwen@huawei.com>, <thomas@monjalon.net>,
 "Kevin Laatz" <kevin.laatz@intel.com>,
 "Bruce Richardson" <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Chengwen Feng [mailto:fengchengwen@huawei.com]
> Sent: Friday, 14 April 2023 11.09
>=20
> Add tracepoints at important APIs for tracing support.
>=20
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
>=20
> ---
> v2: Address Morten's comment:
>     Make stats_get as fast-path trace-points.
>     Place fast-path trace-point functions behind in version.map.

...

> +RTE_TRACE_POINT(
> +	rte_dma_trace_vchan_status,

rte_dma_trace_vchan_status should also be a FP trace point.

> +	RTE_TRACE_POINT_ARGS(int16_t dev_id, uint16_t vchan,
> +			     enum rte_dma_vchan_status *status, int ret),
> +	int vchan_status =3D *status;
> +	rte_trace_point_emit_i16(dev_id);
> +	rte_trace_point_emit_u16(vchan);
> +	rte_trace_point_emit_int(vchan_status);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> +	rte_dma_trace_dump,
> +	RTE_TRACE_POINT_ARGS(int16_t dev_id, FILE *f, int ret),
> +	rte_trace_point_emit_i16(dev_id);
> +	rte_trace_point_emit_ptr(f);
> +	rte_trace_point_emit_int(ret);
> +)
> +
> +/* Fast path trace points */

Don't add the fast path trace points here. Add them to the =
rte_dmadev_trace_fp.h file.

> +
> +/* Called in loop in examples/dma */
> +RTE_TRACE_POINT_FP(
> +	rte_dma_trace_stats_get,
> +	RTE_TRACE_POINT_ARGS(int16_t dev_id, uint16_t vchan,
> +			     struct rte_dma_stats *stats, int ret),
> +	rte_trace_point_emit_i16(dev_id);
> +	rte_trace_point_emit_u16(vchan);
> +	rte_trace_point_emit_u64(stats->submitted);
> +	rte_trace_point_emit_u64(stats->completed);
> +	rte_trace_point_emit_u64(stats->errors);
> +	rte_trace_point_emit_int(ret);
> +)

With those two fixes, you may add:

Acked-by: Morten Br=F8rup <mb@smartsharesystems.com>