From: "Morten Brørup" <mb@smartsharesystems.com>
To: <olivier.matz@6wind.com>, <andrew.rybchenko@oktetlabs.ru>,
"Kamalakshitha Aligeri" <kamalakshitha.aligeri@arm.com>
Cc: <dev@dpdk.org>, <nd@arm.com>, <thomas@monjalon.net>,
<Yuying.Zhang@intel.com>, <beilei.xing@intel.com>,
<andrew.rybchenko@oktetlabs.ru>, <bruce.richardson@intel.com>,
<konstantin.ananyev@huawei.com>, <Honnappa.Nagarahalli@arm.com>,
<ruifeng.wang@arm.com>, <feifei.wang2@arm.com>
Subject: RE: [PATCH v10 1/2] mempool cache: add zero-copy get and put functions
Date: Tue, 25 Apr 2023 15:14:24 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D878B9@smartserver.smartshare.dk> (raw)
In-Reply-To: <20230224181059.338206-2-kamalakshitha.aligeri@arm.com>
PING mempool maintainers - ack/review or further comments to this series?
> > From: Kamalakshitha Aligeri [mailto:kamalakshitha.aligeri@arm.com]
> > Sent: Friday, 24 February 2023 19.11
> >
> > From: = Morten Brørup <mb@smartsharesystems.com>
>
> This should be:
>
> From: Morten Brørup <mb@smartsharesystems.com>
>
> It could be fixed while merging. This is the only complaint in patchwork.
>
> >
> > Zero-copy access to mempool caches is beneficial for PMD performance,
> > and
> > must be provided by the mempool library to fix [Bug 1052] without a
> > performance regression.
> >
> > [Bug 1052]: https://bugs.dpdk.org/show_bug.cgi?id=1052
> >
> > Bugzilla ID: 1052
> >
> > Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> > Signed-off-by: Kamalakshitha Aligeri <kamalakshitha.aligeri@arm.com>
>
> Can we get some reviews/acks on this please? I would like to see mempool zero-
> copy go into DPDK before 23.11.
>
> Please also note that the warnings and errors in patchwork regarding patch 2/2
> are bogus or unrelated.
>
> > ---
> > v10:
> > * Added mempool test cases with zero-copy API's
>
> For the parts not provided by myself, i.e. the test cases:
>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
>
> [...]
>
> > diff --git a/lib/mempool/version.map b/lib/mempool/version.map
> > index dff2d1cb55..06cb83ad9d 100644
> > --- a/lib/mempool/version.map
> > +++ b/lib/mempool/version.map
> > @@ -49,6 +49,15 @@ EXPERIMENTAL {
> > __rte_mempool_trace_get_contig_blocks;
> > __rte_mempool_trace_default_cache;
> > __rte_mempool_trace_cache_flush;
> > + __rte_mempool_trace_ops_populate;
> > + __rte_mempool_trace_ops_alloc;
> > + __rte_mempool_trace_ops_free;
> > + __rte_mempool_trace_set_ops_byname;
> > +
> > + # added in 23.03
>
> Time is passing, so now this should be updated to 23.07
>
> It could be fixed while merging.
>
> > + __rte_mempool_trace_cache_zc_put_bulk;
> > + __rte_mempool_trace_cache_zc_put_rewind;
> > + __rte_mempool_trace_cache_zc_get_bulk;
> > };
> >
> > INTERNAL {
next prev parent reply other threads:[~2023-04-25 13:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 18:10 [PATCH v10 0/2] " Kamalakshitha Aligeri
2023-02-24 18:10 ` [PATCH v10 1/2] mempool cache: add " Kamalakshitha Aligeri
2023-02-27 7:12 ` Ruifeng Wang
2023-04-06 10:13 ` Morten Brørup
2023-04-25 13:14 ` Morten Brørup [this message]
2023-06-07 10:32 ` Thomas Monjalon
2023-06-07 12:04 ` Morten Brørup
2023-06-07 12:32 ` Thomas Monjalon
2023-06-07 13:42 ` Morten Brørup
2023-06-07 14:05 ` Morten Brørup
2023-07-05 17:18 ` [PATCH v11 " Kamalakshitha Aligeri
2023-07-05 17:18 ` [PATCH v11 2/2] net/i40e: replace put function Kamalakshitha Aligeri
2023-07-06 9:20 ` Konstantin Ananyev
2023-07-06 13:32 ` Morten Brørup
2023-07-06 9:20 ` [PATCH v11 1/2] mempool cache: add zero-copy get and put functions Konstantin Ananyev
2023-07-05 18:02 ` Kamalakshitha Aligeri
2023-07-05 18:02 ` [PATCH v11 2/2] net/i40e: replace put function Kamalakshitha Aligeri
2023-07-18 11:36 ` Morten Brørup
2023-07-21 16:28 ` [PATCH v12 1/2] mempool cache: add zero-copy get and put functions Dharmik Thakkar
2023-07-21 16:28 ` [PATCH v12 2/2] net/i40e: replace put function Dharmik Thakkar
2023-07-31 12:16 ` [PATCH v12 1/2] mempool cache: add zero-copy get and put functions Thomas Monjalon
2023-10-13 5:41 ` Morten Brørup
2024-05-27 12:15 ` Morten Brørup
2023-07-18 10:14 ` [PATCH v11 " Morten Brørup
2023-02-24 18:10 ` [PATCH v10 2/2] net/i40e: replace put function Kamalakshitha Aligeri
2023-03-02 21:44 ` Kamalakshitha Aligeri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D878B9@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Yuying.Zhang@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=feifei.wang2@arm.com \
--cc=kamalakshitha.aligeri@arm.com \
--cc=konstantin.ananyev@huawei.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).