From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB83042C4D; Wed, 7 Jun 2023 12:10:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7ADDB40A84; Wed, 7 Jun 2023 12:10:05 +0200 (CEST) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 8024E40698 for ; Wed, 7 Jun 2023 12:10:03 +0200 (CEST) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 48EA520266; Wed, 7 Jun 2023 12:10:03 +0200 (CEST) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH 2/4] mempool: clarify comments for mempool cache implementation X-MimeOLE: Produced By Microsoft Exchange V6.5 Date: Wed, 7 Jun 2023 12:10:01 +0200 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87999@smartserver.smartshare.dk> In-Reply-To: <20230309045738.1261000-3-honnappa.nagarahalli@arm.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH 2/4] mempool: clarify comments for mempool cache implementation Thread-Index: AdlSQ7sdvAOvro8oRB2hmi+9s8azKhG48bxw References: <20230309045738.1261000-1-honnappa.nagarahalli@arm.com> <20230309045738.1261000-3-honnappa.nagarahalli@arm.com> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Honnappa Nagarahalli" , , Cc: , , , , , X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Honnappa Nagarahalli [mailto:honnappa.nagarahalli@arm.com] > Sent: Thursday, 9 March 2023 05.58 >=20 > Clarify that the mempool cache create and free API implementations > work on user owned mempool caches. >=20 > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Kamalakshitha Aligeri > Reviewed-by: Ruifeng Wang > --- > lib/mempool/rte_mempool.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c > index cf5dea2304..a46d855dbf 100644 > --- a/lib/mempool/rte_mempool.c > +++ b/lib/mempool/rte_mempool.c > @@ -757,9 +757,9 @@ mempool_cache_init(struct rte_mempool_cache = *cache, > uint32_t size) > } >=20 > /* > - * Create and initialize a cache for objects that are retrieved from = and > - * returned to an underlying mempool. This structure is identical to = the > - * local_cache[lcore_id] pointed to by the mempool structure. > + * Create and initialize a user owned cache for objects that are = retrieved > + * from and returned to an underlying mempool. This structure is = identical > + * to the local_cache[lcore_id] pointed to by the mempool structure. > */ > struct rte_mempool_cache * > rte_mempool_cache_create(uint32_t size, int socket_id) > @@ -786,9 +786,9 @@ rte_mempool_cache_create(uint32_t size, int = socket_id) > } >=20 > /* > - * Free a cache. It's the responsibility of the user to make sure = that any > - * remaining objects in the cache are flushed to the corresponding > - * mempool. > + * Free a user owned cache. It's the responsibility of the user to = make > + * sure that any remaining objects in the cache are flushed to the > + * corresponding mempool. > */ > void > rte_mempool_cache_free(struct rte_mempool_cache *cache) > -- > 2.25.1 >=20 These comments should probably be updated in the function descriptions = in rte_mempool.h too, so they go into the auto-generated documentation.