From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FF0E42F6C; Fri, 28 Jul 2023 17:08:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C45740685; Fri, 28 Jul 2023 17:08:59 +0200 (CEST) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 90EDD4021E for ; Fri, 28 Jul 2023 17:08:57 +0200 (CEST) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 5994920433; Fri, 28 Jul 2023 17:08:56 +0200 (CEST) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH] doc: announce ethdev operation struct changes Date: Fri, 28 Jul 2023 17:08:55 +0200 X-MimeOLE: Produced By Microsoft Exchange V6.5 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87AA2@smartserver.smartshare.dk> In-Reply-To: <2352864.NG923GbCHz@thomas> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] doc: announce ethdev operation struct changes Thread-Index: AdnBY8aMUJQBQZfKT2qLPsX1MgbtaQAATYjg References: <20230704081006.1202932-1-feifei.wang2@arm.com> <2352864.NG923GbCHz@thomas> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Thomas Monjalon" , Cc: , , "Feifei Wang" , "Ruifeng Wang" , "Feifei Wang" , , , X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, 28 July 2023 16.57 >=20 > 04/07/2023 10:10, Feifei Wang: > > To support mbufs recycle mode, announce the coming ABI changes > > from DPDK 23.11. > > > > Signed-off-by: Feifei Wang > > Reviewed-by: Ruifeng Wang > > --- > > doc/guides/rel_notes/deprecation.rst | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > > index 66431789b0..c7e1ffafb2 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -118,6 +118,10 @@ Deprecation Notices > > The legacy actions should be removed > > once ``MODIFY_FIELD`` alternative is implemented in drivers. > > > > +* ethdev: The Ethernet device data structure ``struct rte_eth_dev`` = and > > + the fast-path ethdev flat array ``struct rte_eth_fp_ops`` will be = updated > > + with new fields to support mbufs recycle mode from DPDK 23.11. Existing fields will also be moved around [1]: @@ -83,15 +90,17 @@ struct rte_eth_fp_ops { * Rx fast-path functions and related data. * 64-bit systems: occupies first 64B line */ + /** Rx queues data. */ + struct rte_ethdev_qdata rxq; /** PMD receive function. */ eth_rx_burst_t rx_pkt_burst; /** Get the number of used Rx descriptors. */ eth_rx_queue_count_t rx_queue_count; /** Check the status of a Rx descriptor. */ eth_rx_descriptor_status_t rx_descriptor_status; - /** Rx queues data. */ - struct rte_ethdev_qdata rxq; - uintptr_t reserved1[3]; + /** Refill Rx descriptors with the recycling mbufs. */ + eth_recycle_rx_descriptors_refill_t recycle_rx_descriptors_refill; + uintptr_t reserved1[2]; /**@}*/ =20 /**@{*/ @@ -99,15 +108,17 @@ struct rte_eth_fp_ops { * Tx fast-path functions and related data. * 64-bit systems: occupies second 64B line */ + /** Tx queues data. */ + struct rte_ethdev_qdata txq; /** PMD transmit function. */ eth_tx_burst_t tx_pkt_burst; /** PMD transmit prepare function. */ eth_tx_prep_t tx_pkt_prepare; /** Check the status of a Tx descriptor. */ eth_tx_descriptor_status_t tx_descriptor_status; - /** Tx queues data. */ - struct rte_ethdev_qdata txq; - uintptr_t reserved2[3]; + /** Copy used mbufs from Tx mbuf ring into Rx. */ + eth_recycle_tx_mbufs_reuse_t recycle_tx_mbufs_reuse; + uintptr_t reserved2[2]; /**@}*/ [1]: = https://patchwork.dpdk.org/project/dpdk/patch/20230706095004.1848199-2-fe= ifei.wang2@arm.com/ >=20 > It does seem to be an impacting change for existing applications, > except that it is allowed only during ABI breakage window. >=20 > I think my patch should be enough: > https://patches.dpdk.org/project/dpdk/patch/20230728142946.1201459-1- > thomas@monjalon.net/ >=20