From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16CE24305C; Mon, 14 Aug 2023 08:37:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D97F540A7F; Mon, 14 Aug 2023 08:37:38 +0200 (CEST) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 1A212406A2; Mon, 14 Aug 2023 08:37:38 +0200 (CEST) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 0579D205ED; Mon, 14 Aug 2023 08:37:37 +0200 (CEST) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH 6/6] devtools: forbid new direct use of GCC atomic builtins Date: Mon, 14 Aug 2023 08:37:30 +0200 X-MimeOLE: Produced By Microsoft Exchange V6.5 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87AED@smartserver.smartshare.dk> In-Reply-To: <20230811155637.GC20040@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH 6/6] devtools: forbid new direct use of GCC atomic builtins Thread-Index: AdnMbGp+2xUn62tCQE2r8bBphRjI8QCDM2Hw References: <1691717521-1025-1-git-send-email-roretzla@linux.microsoft.com> <1691717521-1025-7-git-send-email-roretzla@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35D87AE9@smartserver.smartshare.dk> <20230811155637.GC20040@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Tyler Retzlaff" Cc: , , "Bruce Richardson" , "Honnappa Nagarahalli" , "Ruifeng Wang" , "Jerin Jacob" , "Sunil Kumar Kori" , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , "Joyce Kong" , "David Christensen" , "Konstantin Ananyev" , "David Hunt" , "Thomas Monjalon" , "David Marchand" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > Sent: Friday, 11 August 2023 17.57 >=20 > On Fri, Aug 11, 2023 at 11:51:17AM +0200, Morten Br=F8rup wrote: > > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > > > Sent: Friday, 11 August 2023 03.32 > > > > > > Refrain from using compiler __atomic_xxx builtins DPDK now = requires > > > the use of rte_atomic__explicit macros when operating on DPDK > > > atomic variables. > > > > > > Signed-off-by: Tyler Retzlaff > > > Acked-by: Morten Br=F8rup > > > > The Acked-by should have been: > > Suggested-by: Morten Br=F8rup >=20 > ooh, did i make a mistake? i was carrying the ack from my abandoned > series (or i thought you had acked this patch on that series sorry). >=20 > i'll change it to suggested-by. >=20 > thanks! No problem. Both tags mean that I approve of the concept anyway. Minor mistakes are bound to come with big sets like this. Better in the = comments than in the code. :-) >=20 > > > > > --- > > > devtools/checkpatches.sh | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > > > index 43f5e36..a32f02e 100755 > > > --- a/devtools/checkpatches.sh > > > +++ b/devtools/checkpatches.sh > > > @@ -102,6 +102,14 @@ check_forbidden_additions() { # > > > -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk > > > \ > > > "$1" || res=3D1 > > > > > > + # refrain from using compiler __atomic_xxx builtins > > > + awk -v FOLDERS=3D"lib drivers app examples" \ > > > + -v EXPRESSIONS=3D"__atomic_.*\\\(" \ > > > > This expression is a superset of other expressions in checkpatches = (search > for "__atomic" in the checkpatches, and you'll find them). Perhaps = they can be > removed? >=20 > yes, seems like a good idea. >=20 > v2 >=20 > > > > > + -v RET_ON_FAIL=3D1 \ > > > + -v MESSAGE=3D'Using __atomic_xxx builtins' \ > > > + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk > > > \ > > > + "$1" || res=3D1 > > > + > > > # refrain from using compiler __atomic_thread_fence() > > > # It should be avoided on x86 for SMP case. > > > awk -v FOLDERS=3D"lib drivers app examples" \ > > > -- > > > 1.8.3.1 > >