[PATCH] config/x86: config support for AMD EPYC processors

[PATCH] config/x86: config support for AMD EPYC processors

[Sivaprasad Tummala]

From: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>

By default, max lcores are limited to 128 for x86 platforms.
On AMD EPYC processors, this limit needs to be increased to
leverage all the cores.

The patch adjusts the limit specifically for native compilation
on AMD EPYC CPUs.

Signed-off-by: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
---
 config/x86/meson.build | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/config/x86/meson.build b/config/x86/meson.build
index d8ef50fb40..5355731cef 100644
--- a/config/x86/meson.build
+++ b/config/x86/meson.build
@@ -83,4 +83,21 @@ endif
 
 dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64)
 dpdk_conf.set('RTE_MAX_LCORE', 128)
+
+epyc_zen_cores = {
+    '__znver4__':512,
+    '__znver3__':256,
+    '__znver2__':256,
+    '__znver1__':128
+    }
+
+if get_option('platform') == 'native'
+    foreach m:epyc_zen_cores.keys()
+        if cc.get_define(m, args: machine_args) != ''
+            dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
+            break
+        endif
+    endforeach
+endif
+
 dpdk_conf.set('RTE_MAX_NUMA_NODES', 32)
-- 
2.34.1

Re: [PATCH] config/x86: config support for AMD EPYC processors

[David Marchand]

On Mon, Sep 25, 2023 at 5:11 PM Sivaprasad Tummala
<sivaprasad.tummala@amd.com> wrote:
>
> From: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
>
> By default, max lcores are limited to 128 for x86 platforms.
> On AMD EPYC processors, this limit needs to be increased to
> leverage all the cores.
>
> The patch adjusts the limit specifically for native compilation
> on AMD EPYC CPUs.
>
> Signed-off-by: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>

This patch is a revamp of
http://inbox.dpdk.org/dev/BY5PR12MB3681C3FC6676BC03F0B42CCC96789@BY5PR12MB3681.namprd12.prod.outlook.com/
for which a discussion at techboard is supposed to have taken place.
But I didn't find a trace of it.

One option that had been discussed in the previous thread was to
increase the max number of cores for x86.
I am unclear if this option has been properly evaluated/debatted.

Can the topic be brought again at techboard?

Thanks.

-- 
David Marchand

RE: [PATCH] config/x86: config support for AMD EPYC processors

[Tummala, Sivaprasad]

[AMD Official Use Only - General]

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Friday, October 6, 2023 1:21 PM
> To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> Cc: bruce.richardson@intel.com; konstantin.v.ananyev@yandex.ru; dev@dpdk.org;
> dpdk-techboard <techboard@dpdk.org>; Thomas Monjalon
> <thomas@monjalon.net>
> Subject: Re: [PATCH] config/x86: config support for AMD EPYC processors
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On Mon, Sep 25, 2023 at 5:11 PM Sivaprasad Tummala
> <sivaprasad.tummala@amd.com> wrote:
> >
> > From: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> >
> > By default, max lcores are limited to 128 for x86 platforms.
> > On AMD EPYC processors, this limit needs to be increased to leverage
> > all the cores.
> >
> > The patch adjusts the limit specifically for native compilation on AMD
> > EPYC CPUs.
> >
> > Signed-off-by: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
>
> This patch is a revamp of
> http://inbox.dpdk.org/dev/BY5PR12MB3681C3FC6676BC03F0B42CCC96789@BY5PR
> 12MB3681.namprd12.prod.outlook.com/
> for which a discussion at techboard is supposed to have taken place.
> But I didn't find a trace of it.
>
> One option that had been discussed in the previous thread was to increase the
> max number of cores for x86.
> I am unclear if this option has been properly evaluated/debatted.
>
> Can the topic be brought again at techboard?

Hi David,

The patch is intended to detect AMD platforms and enable all CPU cores by
default on native builds.

As an optimization for memory footprint, users can override this by specifying
"-Dmax_lcores" option based on DPDK lcores required for their usecases.

Sure, will request to add this topic for discussion at techboard.
>
> Thanks.
>
> --
> David Marchand

RE: [PATCH] config/x86: config support for AMD EPYC processors

[Tummala, Sivaprasad]

[AMD Official Use Only - General]

Hi DPDK Techboard,

Request to add this topic for discussion in the next techboard meeting.

Thanks & Regards,
Sivaprasad

> -----Original Message-----
> From: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> Sent: Monday, October 16, 2023 10:44 AM
> To: David Marchand <david.marchand@redhat.com>
> Cc: bruce.richardson@intel.com; konstantin.v.ananyev@yandex.ru; dev@dpdk.org;
> dpdk-techboard <techboard@dpdk.org>; Thomas Monjalon
> <thomas@monjalon.net>
> Subject: RE: [PATCH] config/x86: config support for AMD EPYC processors
>
> [AMD Official Use Only - General]
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> [AMD Official Use Only - General]
>
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: Friday, October 6, 2023 1:21 PM
> > To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> > Cc: bruce.richardson@intel.com; konstantin.v.ananyev@yandex.ru;
> > dev@dpdk.org; dpdk-techboard <techboard@dpdk.org>; Thomas Monjalon
> > <thomas@monjalon.net>
> > Subject: Re: [PATCH] config/x86: config support for AMD EPYC
> > processors
> >
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > On Mon, Sep 25, 2023 at 5:11 PM Sivaprasad Tummala
> > <sivaprasad.tummala@amd.com> wrote:
> > >
> > > From: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> > >
> > > By default, max lcores are limited to 128 for x86 platforms.
> > > On AMD EPYC processors, this limit needs to be increased to leverage
> > > all the cores.
> > >
> > > The patch adjusts the limit specifically for native compilation on
> > > AMD EPYC CPUs.
> > >
> > > Signed-off-by: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> >
> > This patch is a revamp of
> >
> http://inbox.dpdk.org/dev/BY5PR12MB3681C3FC6676BC03F0B42CCC96789@BY5PR
> > 12MB3681.namprd12.prod.outlook.com/
> > for which a discussion at techboard is supposed to have taken place.
> > But I didn't find a trace of it.
> >
> > One option that had been discussed in the previous thread was to
> > increase the max number of cores for x86.
> > I am unclear if this option has been properly evaluated/debatted.
> >
> > Can the topic be brought again at techboard?
>
> Hi David,
>
> The patch is intended to detect AMD platforms and enable all CPU cores by default
> on native builds.
>
> As an optimization for memory footprint, users can override this by specifying "-
> Dmax_lcores" option based on DPDK lcores required for their usecases.
>
> Sure, will request to add this topic for discussion at techboard.
> >
> > Thanks.
> >
> > --
> > David Marchand

Re: [PATCH] config/x86: config support for AMD EPYC processors

[Kevin Traynor]

On 16/10/2023 06:20, Tummala, Sivaprasad wrote:
> [AMD Official Use Only - General]
> 
> Hi DPDK Techboard,
> 
> Request to add this topic for discussion in the next techboard meeting.
> 

Hi Sivaprasad,

Are you or a representative (Ferruh?) able to attend the techboard 
meeting (3pm UTC Wednesday) to discuss this item?

thanks,
Kevin.

> Thanks & Regards,
> Sivaprasad
> 
>> -----Original Message-----
>> From: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
>> Sent: Monday, October 16, 2023 10:44 AM
>> To: David Marchand <david.marchand@redhat.com>
>> Cc: bruce.richardson@intel.com; konstantin.v.ananyev@yandex.ru; dev@dpdk.org;
>> dpdk-techboard <techboard@dpdk.org>; Thomas Monjalon
>> <thomas@monjalon.net>
>> Subject: RE: [PATCH] config/x86: config support for AMD EPYC processors
>>
>> [AMD Official Use Only - General]
>>
>> Caution: This message originated from an External Source. Use proper caution
>> when opening attachments, clicking links, or responding.
>>
>>
>> [AMD Official Use Only - General]
>>
>>> -----Original Message-----
>>> From: David Marchand <david.marchand@redhat.com>
>>> Sent: Friday, October 6, 2023 1:21 PM
>>> To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
>>> Cc: bruce.richardson@intel.com; konstantin.v.ananyev@yandex.ru;
>>> dev@dpdk.org; dpdk-techboard <techboard@dpdk.org>; Thomas Monjalon
>>> <thomas@monjalon.net>
>>> Subject: Re: [PATCH] config/x86: config support for AMD EPYC
>>> processors
>>>
>>> Caution: This message originated from an External Source. Use proper
>>> caution when opening attachments, clicking links, or responding.
>>>
>>>
>>> On Mon, Sep 25, 2023 at 5:11 PM Sivaprasad Tummala
>>> <sivaprasad.tummala@amd.com> wrote:
>>>>
>>>> From: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
>>>>
>>>> By default, max lcores are limited to 128 for x86 platforms.
>>>> On AMD EPYC processors, this limit needs to be increased to leverage
>>>> all the cores.
>>>>
>>>> The patch adjusts the limit specifically for native compilation on
>>>> AMD EPYC CPUs.
>>>>
>>>> Signed-off-by: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
>>>
>>> This patch is a revamp of
>>>
>> http://inbox.dpdk.org/dev/BY5PR12MB3681C3FC6676BC03F0B42CCC96789@BY5PR
>>> 12MB3681.namprd12.prod.outlook.com/
>>> for which a discussion at techboard is supposed to have taken place.
>>> But I didn't find a trace of it.
>>>
>>> One option that had been discussed in the previous thread was to
>>> increase the max number of cores for x86.
>>> I am unclear if this option has been properly evaluated/debatted.
>>>
>>> Can the topic be brought again at techboard?
>>
>> Hi David,
>>
>> The patch is intended to detect AMD platforms and enable all CPU cores by default
>> on native builds.
>>
>> As an optimization for memory footprint, users can override this by specifying "-
>> Dmax_lcores" option based on DPDK lcores required for their usecases.
>>
>> Sure, will request to add this topic for discussion at techboard.
>>>
>>> Thanks.
>>>
>>> --
>>> David Marchand
> 

RE: [PATCH] config/x86: config support for AMD EPYC processors

[Morten Brørup]

> From: Kevin Traynor [mailto:ktraynor@redhat.com]
> Sent: Tuesday, 17 October 2023 11.45
> 
> On 16/10/2023 06:20, Tummala, Sivaprasad wrote:
> > [AMD Official Use Only - General]
> >
> > Hi DPDK Techboard,
> >
> > Request to add this topic for discussion in the next techboard
> meeting.
> >
> 
> Hi Sivaprasad,
> 
> Are you or a representative (Ferruh?) able to attend the techboard
> meeting (3pm UTC Wednesday) to discuss this item?
> 
> thanks,
> Kevin.
> 
> > Thanks & Regards,
> > Sivaprasad
> >
> >> From: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> >> Sent: Monday, October 16, 2023 10:44 AM
> >>
> >>> From: David Marchand <david.marchand@redhat.com>
> >>> Sent: Friday, October 6, 2023 1:21 PM
> >>>
> >>> On Mon, Sep 25, 2023 at 5:11 PM Sivaprasad Tummala
> >>> <sivaprasad.tummala@amd.com> wrote:
> >>>>
> >>>> From: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> >>>>
> >>>> By default, max lcores are limited to 128 for x86 platforms.
> >>>> On AMD EPYC processors, this limit needs to be increased to
> leverage
> >>>> all the cores.
> >>>>
> >>>> The patch adjusts the limit specifically for native compilation on
> >>>> AMD EPYC CPUs.
> >>>>
> >>>> Signed-off-by: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> >>>
> >>> This patch is a revamp of
> >>>
> >>
> http://inbox.dpdk.org/dev/BY5PR12MB3681C3FC6676BC03F0B42CCC96789@BY5PR
> >>> 12MB3681.namprd12.prod.outlook.com/
> >>> for which a discussion at techboard is supposed to have taken place.
> >>> But I didn't find a trace of it.
> >>>
> >>> One option that had been discussed in the previous thread was to
> >>> increase the max number of cores for x86.
> >>> I am unclear if this option has been properly evaluated/debatted.

Here are the minutes from the previous techboard discussions:
[1]: http://inbox.dpdk.org/dev/YZ43U36bFWHYClAi@platinum/
[2]: http://inbox.dpdk.org/dev/20211202112506.68acaa1a@hermes.local/

AFAIK, there has been no progress with dynamic max_lcores, so I guess the techboard's conclusion still stands:

There is no identified use-case where a single application requires more than 128 lcores. If a case a use-case exists for a single application that uses more than 128 lcores, the TB is ok to update the default config value.

> >>>
> >>> Can the topic be brought again at techboard?
> >>
> >> Hi David,
> >>
> >> The patch is intended to detect AMD platforms and enable all CPU
> cores by default
> >> on native builds.

This is done on native ARM builds, so why not on native X86 builds too?

> >>
> >> As an optimization for memory footprint, users can override this by
> specifying "-
> >> Dmax_lcores" option based on DPDK lcores required for their usecases.
> >>
> >> Sure, will request to add this topic for discussion at techboard.
> >>>
> >>> Thanks.
> >>>
> >>> --
> >>> David Marchand
> >

Re: [PATCH] config/x86: config support for AMD EPYC processors

[Ferruh Yigit]

On 10/17/2023 10:45 AM, Kevin Traynor wrote:
> On 16/10/2023 06:20, Tummala, Sivaprasad wrote:
>> [AMD Official Use Only - General]
>>
>> Hi DPDK Techboard,
>>
>> Request to add this topic for discussion in the next techboard meeting.
>>
> 
> Hi Sivaprasad,
> 
> Are you or a representative (Ferruh?) able to attend the techboard
> meeting (3pm UTC Wednesday) to discuss this item?
> 

Hi Kevin,

I confirmed with Siva that both me and Siva will join the meeting.

Thanks,
ferruh

> thanks,
> Kevin.
> 
>> Thanks & Regards,
>> Sivaprasad
>>
>>> -----Original Message-----
>>> From: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
>>> Sent: Monday, October 16, 2023 10:44 AM
>>> To: David Marchand <david.marchand@redhat.com>
>>> Cc: bruce.richardson@intel.com; konstantin.v.ananyev@yandex.ru;
>>> dev@dpdk.org;
>>> dpdk-techboard <techboard@dpdk.org>; Thomas Monjalon
>>> <thomas@monjalon.net>
>>> Subject: RE: [PATCH] config/x86: config support for AMD EPYC processors
>>>
>>> [AMD Official Use Only - General]
>>>
>>> Caution: This message originated from an External Source. Use proper
>>> caution
>>> when opening attachments, clicking links, or responding.
>>>
>>>
>>> [AMD Official Use Only - General]
>>>
>>>> -----Original Message-----
>>>> From: David Marchand <david.marchand@redhat.com>
>>>> Sent: Friday, October 6, 2023 1:21 PM
>>>> To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
>>>> Cc: bruce.richardson@intel.com; konstantin.v.ananyev@yandex.ru;
>>>> dev@dpdk.org; dpdk-techboard <techboard@dpdk.org>; Thomas Monjalon
>>>> <thomas@monjalon.net>
>>>> Subject: Re: [PATCH] config/x86: config support for AMD EPYC
>>>> processors
>>>>
>>>> Caution: This message originated from an External Source. Use proper
>>>> caution when opening attachments, clicking links, or responding.
>>>>
>>>>
>>>> On Mon, Sep 25, 2023 at 5:11 PM Sivaprasad Tummala
>>>> <sivaprasad.tummala@amd.com> wrote:
>>>>>
>>>>> From: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
>>>>>
>>>>> By default, max lcores are limited to 128 for x86 platforms.
>>>>> On AMD EPYC processors, this limit needs to be increased to leverage
>>>>> all the cores.
>>>>>
>>>>> The patch adjusts the limit specifically for native compilation on
>>>>> AMD EPYC CPUs.
>>>>>
>>>>> Signed-off-by: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
>>>>
>>>> This patch is a revamp of
>>>>
>>> http://inbox.dpdk.org/dev/BY5PR12MB3681C3FC6676BC03F0B42CCC96789@BY5PR
>>>> 12MB3681.namprd12.prod.outlook.com/
>>>> for which a discussion at techboard is supposed to have taken place.
>>>> But I didn't find a trace of it.
>>>>
>>>> One option that had been discussed in the previous thread was to
>>>> increase the max number of cores for x86.
>>>> I am unclear if this option has been properly evaluated/debatted.
>>>>
>>>> Can the topic be brought again at techboard?
>>>
>>> Hi David,
>>>
>>> The patch is intended to detect AMD platforms and enable all CPU
>>> cores by default
>>> on native builds.
>>>
>>> As an optimization for memory footprint, users can override this by
>>> specifying "-
>>> Dmax_lcores" option based on DPDK lcores required for their usecases.
>>>
>>> Sure, will request to add this topic for discussion at techboard.
>>>>
>>>> Thanks.
>>>>
>>>> -- 
>>>> David Marchand
>>
> 

Re: [PATCH] config/x86: config support for AMD EPYC processors

[Thomas Monjalon]

17/10/2023 12:27, Morten Brørup:
> > >> From: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> > >>> From: David Marchand <david.marchand@redhat.com>
> > >>> On Mon, Sep 25, 2023 at 5:11 PM Sivaprasad Tummala
> > >>>> From: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> > >>>>
> > >>>> By default, max lcores are limited to 128 for x86 platforms.
> > >>>> On AMD EPYC processors, this limit needs to be increased to
> > leverage
> > >>>> all the cores.
> > >>>>
> > >>>> The patch adjusts the limit specifically for native compilation on
> > >>>> AMD EPYC CPUs.
> > >>>>
> > >>>> Signed-off-by: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> > >>>
> > >>> This patch is a revamp of
> > >>>
> > >>
> > http://inbox.dpdk.org/dev/BY5PR12MB3681C3FC6676BC03F0B42CCC96789@BY5PR
> > >>> 12MB3681.namprd12.prod.outlook.com/
> > >>> for which a discussion at techboard is supposed to have taken place.
> > >>> But I didn't find a trace of it.
> > >>>
> > >>> One option that had been discussed in the previous thread was to
> > >>> increase the max number of cores for x86.
> > >>> I am unclear if this option has been properly evaluated/debatted.
> 
> Here are the minutes from the previous techboard discussions:
> [1]: http://inbox.dpdk.org/dev/YZ43U36bFWHYClAi@platinum/
> [2]: http://inbox.dpdk.org/dev/20211202112506.68acaa1a@hermes.local/
> 
> AFAIK, there has been no progress with dynamic max_lcores, so I guess the techboard's conclusion still stands:
> 
> There is no identified use-case where a single application requires more than 128 lcores. If a case a use-case exists for a single application that uses more than 128 lcores, the TB is ok to update the default config value.
> 
> > >>>
> > >>> Can the topic be brought again at techboard?
> > >>
> > >> Hi David,
> > >>
> > >> The patch is intended to detect AMD platforms and enable all CPU
> > cores by default
> > >> on native builds.
> 
> This is done on native ARM builds, so why not on native X86 builds too?
> 
> > >>
> > >> As an optimization for memory footprint, users can override this by
> > specifying "-
> > >> Dmax_lcores" option based on DPDK lcores required for their usecases.
> > >>
> > >> Sure, will request to add this topic for discussion at techboard.

This is the summary of the techboard meeting:
(see https://mails.dpdk.org/archives/dev/2023-October/279672.html)

- There is some asks for more than 128 worker cores
- Discussion about generally increasing the default max core count and
trade-offs with memory consumption but this is longer term issue
- Acceptance for the direction of this patch in the short term
- Details of whether it should be for EPYC only or x86 to be figured out
on mailing list

So now let's figure out the details please.
Suggestions?

RE: [PATCH] config/x86: config support for AMD EPYC processors

[Morten Brørup]

> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, 6 November 2023 22.05
> 
> 17/10/2023 12:27, Morten Brørup:
> > > >> From: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> > > >>> From: David Marchand <david.marchand@redhat.com>
> > > >>> On Mon, Sep 25, 2023 at 5:11 PM Sivaprasad Tummala
> > > >>>> From: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> > > >>>>
> > > >>>> By default, max lcores are limited to 128 for x86 platforms.
> > > >>>> On AMD EPYC processors, this limit needs to be increased to
> > > leverage
> > > >>>> all the cores.
> > > >>>>
> > > >>>> The patch adjusts the limit specifically for native
> compilation on
> > > >>>> AMD EPYC CPUs.
> > > >>>>
> > > >>>> Signed-off-by: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> > > >>>
> > > >>> This patch is a revamp of
> > > >>>
> > > >>
> > >
> http://inbox.dpdk.org/dev/BY5PR12MB3681C3FC6676BC03F0B42CCC96789@BY5PR
> > > >>> 12MB3681.namprd12.prod.outlook.com/
> > > >>> for which a discussion at techboard is supposed to have taken
> place.
> > > >>> But I didn't find a trace of it.
> > > >>>
> > > >>> One option that had been discussed in the previous thread was
> to
> > > >>> increase the max number of cores for x86.
> > > >>> I am unclear if this option has been properly
> evaluated/debatted.
> >
> > Here are the minutes from the previous techboard discussions:
> > [1]: http://inbox.dpdk.org/dev/YZ43U36bFWHYClAi@platinum/
> > [2]: http://inbox.dpdk.org/dev/20211202112506.68acaa1a@hermes.local/
> >
> > AFAIK, there has been no progress with dynamic max_lcores, so I guess
> the techboard's conclusion still stands:
> >
> > There is no identified use-case where a single application requires
> more than 128 lcores. If a case a use-case exists for a single
> application that uses more than 128 lcores, the TB is ok to update the
> default config value.
> >
> > > >>>
> > > >>> Can the topic be brought again at techboard?
> > > >>
> > > >> Hi David,
> > > >>
> > > >> The patch is intended to detect AMD platforms and enable all CPU
> > > cores by default
> > > >> on native builds.
> >
> > This is done on native ARM builds, so why not on native X86 builds
> too?
> >
> > > >>
> > > >> As an optimization for memory footprint, users can override this
> by
> > > specifying "-
> > > >> Dmax_lcores" option based on DPDK lcores required for their
> usecases.
> > > >>
> > > >> Sure, will request to add this topic for discussion at
> techboard.
> 
> This is the summary of the techboard meeting:
> (see https://mails.dpdk.org/archives/dev/2023-October/279672.html)
> 
> - There is some asks for more than 128 worker cores
> - Discussion about generally increasing the default max core count and
> trade-offs with memory consumption but this is longer term issue

The distros are currently satisfied with the 128 cores default, so the decision here was: Leave the 128 cores default as is, for now.

Any long term improvements regarding memory consumption of many-core systems are not relevant for this patch.

> - Acceptance for the direction of this patch in the short term

With the twist that it must work for cross compile. It is the properties of the target CPU that matter, not the properties of the host CPU. (Although the build may be "native", i.e. the target CPU is the same as the host CPU, it is still the target CPU that matters.)

> - Details of whether it should be for EPYC only or x86 to be figured
> out
> on mailing list

I think this is obvious...

ARM already provides ARM CPU specific optimizations.
AMD should be allowed to provide AMD CPU specific optimizations too.
Intel can also provide Intel CPU specific optimizations.

And if some of these optimizations are rooted in the same criteria, they should be shared across the relevant CPU architectures. We follow this principle in the source code files, and the principle also applies to the build files.

> 
> So now let's figure out the details please.
> Suggestions?

Suggestions provided inline above. :-)

RE: [PATCH] config/x86: config support for AMD EPYC processors

[Konstantin Ananyev]

> -----Original Message-----
> From: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> Sent: Monday, September 25, 2023 4:10 PM
> To: bruce.richardson@intel.com; konstantin.v.ananyev@yandex.ru
> Cc: dev@dpdk.org; Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> Subject: [PATCH] config/x86: config support for AMD EPYC processors
> 
> From: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> 
> By default, max lcores are limited to 128 for x86 platforms.
> On AMD EPYC processors, this limit needs to be increased to
> leverage all the cores.
> 
> The patch adjusts the limit specifically for native compilation
> on AMD EPYC CPUs.
> 
> Signed-off-by: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> ---
>  config/x86/meson.build | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/config/x86/meson.build b/config/x86/meson.build
> index d8ef50fb40..5355731cef 100644
> --- a/config/x86/meson.build
> +++ b/config/x86/meson.build
> @@ -83,4 +83,21 @@ endif
> 
>  dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64)
>  dpdk_conf.set('RTE_MAX_LCORE', 128)
> +
> +epyc_zen_cores = {
> +    '__znver4__':512,
> +    '__znver3__':256,
> +    '__znver2__':256,
> +    '__znver1__':128
> +    }
> +
> +if get_option('platform') == 'native'
> +    foreach m:epyc_zen_cores.keys()
> +        if cc.get_define(m, args: machine_args) != ''
> +            dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
> +            break
> +        endif
> +    endforeach
> +endif
> +
>  dpdk_conf.set('RTE_MAX_NUMA_NODES', 32)
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
 


> 2.34.1

RE: [PATCH] config/x86: config support for AMD EPYC processors

[Konstantin Ananyev]

> 
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Monday, 6 November 2023 22.05
> >
> > 17/10/2023 12:27, Morten Brørup:
> > > > >> From: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> > > > >>> From: David Marchand <david.marchand@redhat.com>
> > > > >>> On Mon, Sep 25, 2023 at 5:11 PM Sivaprasad Tummala
> > > > >>>> From: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> > > > >>>>
> > > > >>>> By default, max lcores are limited to 128 for x86 platforms.
> > > > >>>> On AMD EPYC processors, this limit needs to be increased to
> > > > leverage
> > > > >>>> all the cores.
> > > > >>>>
> > > > >>>> The patch adjusts the limit specifically for native
> > compilation on
> > > > >>>> AMD EPYC CPUs.
> > > > >>>>
> > > > >>>> Signed-off-by: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> > > > >>>
> > > > >>> This patch is a revamp of
> > > > >>>
> > > > >>
> > > >
> > http://inbox.dpdk.org/dev/BY5PR12MB3681C3FC6676BC03F0B42CCC96789@BY5PR
> > > > >>> 12MB3681.namprd12.prod.outlook.com/
> > > > >>> for which a discussion at techboard is supposed to have taken
> > place.
> > > > >>> But I didn't find a trace of it.
> > > > >>>
> > > > >>> One option that had been discussed in the previous thread was
> > to
> > > > >>> increase the max number of cores for x86.
> > > > >>> I am unclear if this option has been properly
> > evaluated/debatted.
> > >
> > > Here are the minutes from the previous techboard discussions:
> > > [1]: http://inbox.dpdk.org/dev/YZ43U36bFWHYClAi@platinum/
> > > [2]: http://inbox.dpdk.org/dev/20211202112506.68acaa1a@hermes.local/
> > >
> > > AFAIK, there has been no progress with dynamic max_lcores, so I guess
> > the techboard's conclusion still stands:
> > >
> > > There is no identified use-case where a single application requires
> > more than 128 lcores. If a case a use-case exists for a single
> > application that uses more than 128 lcores, the TB is ok to update the
> > default config value.
> > >
> > > > >>>
> > > > >>> Can the topic be brought again at techboard?
> > > > >>
> > > > >> Hi David,
> > > > >>
> > > > >> The patch is intended to detect AMD platforms and enable all CPU
> > > > cores by default
> > > > >> on native builds.
> > >
> > > This is done on native ARM builds, so why not on native X86 builds
> > too?
> > >
> > > > >>
> > > > >> As an optimization for memory footprint, users can override this
> > by
> > > > specifying "-
> > > > >> Dmax_lcores" option based on DPDK lcores required for their
> > usecases.
> > > > >>
> > > > >> Sure, will request to add this topic for discussion at
> > techboard.
> >
> > This is the summary of the techboard meeting:
> > (see https://mails.dpdk.org/archives/dev/2023-October/279672.html)
> >
> > - There is some asks for more than 128 worker cores
> > - Discussion about generally increasing the default max core count and
> > trade-offs with memory consumption but this is longer term issue
> 
> The distros are currently satisfied with the 128 cores default, so the decision here was: Leave the 128 cores default as is, for now.
> 
> Any long term improvements regarding memory consumption of many-core systems are not relevant for this patch.
> 
> > - Acceptance for the direction of this patch in the short term
> 
> With the twist that it must work for cross compile. It is the properties of the target CPU that matter, not the properties of the host
> CPU. (Although the build may be "native", i.e. the target CPU is the same as the host CPU, it is still the target CPU that matters.)
> 
> > - Details of whether it should be for EPYC only or x86 to be figured
> > out
> > on mailing list
> 
> I think this is obvious...
> 
> ARM already provides ARM CPU specific optimizations.
> AMD should be allowed to provide AMD CPU specific optimizations too.
> Intel can also provide Intel CPU specific optimizations.

I suppose no-one stopping AMD/Intel/ARM to provide their CPU specific optimizations.
Though as end-user, my preference would be to have one generic build (machine=default) that would work ok
on all cpus for given architecture (let say x86) instead of maintaining/testing dozens of different flavors.
I suppose for 23.11 we have not much choice but accept that patch as it is.
Though I think in future (24.11?) it would be ideal to make RTE_MAX_LCORE a runtime parameter and
remove it from public API structs.    

> 
> And if some of these optimizations are rooted in the same criteria, they should be shared across the relevant CPU architectures. We
> follow this principle in the source code files, and the principle also applies to the build files.
> 
> >
> > So now let's figure out the details please.
> > Suggestions?
> 
> Suggestions provided inline above. :-)

RE: [PATCH] config/x86: config support for AMD EPYC processors

[Morten Brørup]

> From: Konstantin Ananyev [mailto:konstantin.ananyev@huawei.com]
> Sent: Tuesday, 7 November 2023 14.14
> 
> >
> > > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > Sent: Monday, 6 November 2023 22.05
> > >
> > > 17/10/2023 12:27, Morten Brørup:
> > > > > >> From: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> > > > > >>> From: David Marchand <david.marchand@redhat.com>
> > > > > >>> On Mon, Sep 25, 2023 at 5:11 PM Sivaprasad Tummala
> > > > > >>>> From: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> > > > > >>>>
> > > > > >>>> By default, max lcores are limited to 128 for x86
> platforms.
> > > > > >>>> On AMD EPYC processors, this limit needs to be increased
> to
> > > > > leverage
> > > > > >>>> all the cores.
> > > > > >>>>
> > > > > >>>> The patch adjusts the limit specifically for native
> > > compilation on
> > > > > >>>> AMD EPYC CPUs.
> > > > > >>>>
> > > > > >>>> Signed-off-by: Sivaprasad Tummala
> <Sivaprasad.Tummala@amd.com>
> > > > > >>>
> > > > > >>> This patch is a revamp of
> > > > > >>>
> > > > > >>
> > > > >
> > >
> http://inbox.dpdk.org/dev/BY5PR12MB3681C3FC6676BC03F0B42CCC96789@BY5PR
> > > > > >>> 12MB3681.namprd12.prod.outlook.com/
> > > > > >>> for which a discussion at techboard is supposed to have
> taken
> > > place.
> > > > > >>> But I didn't find a trace of it.
> > > > > >>>
> > > > > >>> One option that had been discussed in the previous thread
> was
> > > to
> > > > > >>> increase the max number of cores for x86.
> > > > > >>> I am unclear if this option has been properly
> > > evaluated/debatted.
> > > >
> > > > Here are the minutes from the previous techboard discussions:
> > > > [1]: http://inbox.dpdk.org/dev/YZ43U36bFWHYClAi@platinum/
> > > > [2]:
> http://inbox.dpdk.org/dev/20211202112506.68acaa1a@hermes.local/
> > > >
> > > > AFAIK, there has been no progress with dynamic max_lcores, so I
> guess
> > > the techboard's conclusion still stands:
> > > >
> > > > There is no identified use-case where a single application
> requires
> > > more than 128 lcores. If a case a use-case exists for a single
> > > application that uses more than 128 lcores, the TB is ok to update
> the
> > > default config value.
> > > >
> > > > > >>>
> > > > > >>> Can the topic be brought again at techboard?
> > > > > >>
> > > > > >> Hi David,
> > > > > >>
> > > > > >> The patch is intended to detect AMD platforms and enable all
> CPU
> > > > > cores by default
> > > > > >> on native builds.
> > > >
> > > > This is done on native ARM builds, so why not on native X86
> builds
> > > too?
> > > >
> > > > > >>
> > > > > >> As an optimization for memory footprint, users can override
> this
> > > by
> > > > > specifying "-
> > > > > >> Dmax_lcores" option based on DPDK lcores required for their
> > > usecases.
> > > > > >>
> > > > > >> Sure, will request to add this topic for discussion at
> > > techboard.
> > >
> > > This is the summary of the techboard meeting:
> > > (see https://mails.dpdk.org/archives/dev/2023-October/279672.html)
> > >
> > > - There is some asks for more than 128 worker cores
> > > - Discussion about generally increasing the default max core count
> and
> > > trade-offs with memory consumption but this is longer term issue
> >
> > The distros are currently satisfied with the 128 cores default, so
> the decision here was: Leave the 128 cores default as is, for now.
> >
> > Any long term improvements regarding memory consumption of many-core
> systems are not relevant for this patch.
> >
> > > - Acceptance for the direction of this patch in the short term
> >
> > With the twist that it must work for cross compile. It is the
> properties of the target CPU that matter, not the properties of the
> host
> > CPU. (Although the build may be "native", i.e. the target CPU is the
> same as the host CPU, it is still the target CPU that matters.)
> >
> > > - Details of whether it should be for EPYC only or x86 to be
> figured
> > > out
> > > on mailing list
> >
> > I think this is obvious...
> >
> > ARM already provides ARM CPU specific optimizations.
> > AMD should be allowed to provide AMD CPU specific optimizations too.
> > Intel can also provide Intel CPU specific optimizations.
> 
> I suppose no-one stopping AMD/Intel/ARM to provide their CPU specific
> optimizations.
> Though as end-user, my preference would be to have one generic build
> (machine=default) that would work ok
> on all cpus for given architecture (let say x86) instead of
> maintaining/testing dozens of different flavors.

Agree. Machine specific builds should be explicitly specified. I consider "native" a variant of explicitly specifying the target machine.

> I suppose for 23.11 we have not much choice but accept that patch as it
> is.

No. They agreed in the techboard meeting to rework it for cross compile.

> Though I think in future (24.11?) it would be ideal to make
> RTE_MAX_LCORE a runtime parameter and
> remove it from public API structs.

It is probably more difficult than it sounds to fully remove RTE_MAX_LCORE.

However, if we could make it mostly a runtime parameter, and only keep RTE_MAX_LCORE in arrays of small structures, we could increase it to some very large (but still sane) value, like 4096 or whatever number of CPU cores can be found in the largest system out there.

> 
> >
> > And if some of these optimizations are rooted in the same criteria,
> they should be shared across the relevant CPU architectures. We
> > follow this principle in the source code files, and the principle
> also applies to the build files.
> >
> > >
> > > So now let's figure out the details please.
> > > Suggestions?
> >
> > Suggestions provided inline above. :-)

RE: [PATCH] config/x86: config support for AMD EPYC processors

[Konstantin Ananyev]

> > > > > > >> From: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> > > > > > >>> From: David Marchand <david.marchand@redhat.com>
> > > > > > >>> On Mon, Sep 25, 2023 at 5:11 PM Sivaprasad Tummala
> > > > > > >>>> From: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> > > > > > >>>>
> > > > > > >>>> By default, max lcores are limited to 128 for x86
> > platforms.
> > > > > > >>>> On AMD EPYC processors, this limit needs to be increased
> > to
> > > > > > leverage
> > > > > > >>>> all the cores.
> > > > > > >>>>
> > > > > > >>>> The patch adjusts the limit specifically for native
> > > > compilation on
> > > > > > >>>> AMD EPYC CPUs.
> > > > > > >>>>
> > > > > > >>>> Signed-off-by: Sivaprasad Tummala
> > <Sivaprasad.Tummala@amd.com>
> > > > > > >>>
> > > > > > >>> This patch is a revamp of
> > > > > > >>>
> > > > > > >>
> > > > > >
> > > >
> > http://inbox.dpdk.org/dev/BY5PR12MB3681C3FC6676BC03F0B42CCC96789@BY5PR
> > > > > > >>> 12MB3681.namprd12.prod.outlook.com/
> > > > > > >>> for which a discussion at techboard is supposed to have
> > taken
> > > > place.
> > > > > > >>> But I didn't find a trace of it.
> > > > > > >>>
> > > > > > >>> One option that had been discussed in the previous thread
> > was
> > > > to
> > > > > > >>> increase the max number of cores for x86.
> > > > > > >>> I am unclear if this option has been properly
> > > > evaluated/debatted.
> > > > >
> > > > > Here are the minutes from the previous techboard discussions:
> > > > > [1]: http://inbox.dpdk.org/dev/YZ43U36bFWHYClAi@platinum/
> > > > > [2]:
> > http://inbox.dpdk.org/dev/20211202112506.68acaa1a@hermes.local/
> > > > >
> > > > > AFAIK, there has been no progress with dynamic max_lcores, so I
> > guess
> > > > the techboard's conclusion still stands:
> > > > >
> > > > > There is no identified use-case where a single application
> > requires
> > > > more than 128 lcores. If a case a use-case exists for a single
> > > > application that uses more than 128 lcores, the TB is ok to update
> > the
> > > > default config value.
> > > > >
> > > > > > >>>
> > > > > > >>> Can the topic be brought again at techboard?
> > > > > > >>
> > > > > > >> Hi David,
> > > > > > >>
> > > > > > >> The patch is intended to detect AMD platforms and enable all
> > CPU
> > > > > > cores by default
> > > > > > >> on native builds.
> > > > >
> > > > > This is done on native ARM builds, so why not on native X86
> > builds
> > > > too?
> > > > >
> > > > > > >>
> > > > > > >> As an optimization for memory footprint, users can override
> > this
> > > > by
> > > > > > specifying "-
> > > > > > >> Dmax_lcores" option based on DPDK lcores required for their
> > > > usecases.
> > > > > > >>
> > > > > > >> Sure, will request to add this topic for discussion at
> > > > techboard.
> > > >
> > > > This is the summary of the techboard meeting:
> > > > (see https://mails.dpdk.org/archives/dev/2023-October/279672.html)
> > > >
> > > > - There is some asks for more than 128 worker cores
> > > > - Discussion about generally increasing the default max core count
> > and
> > > > trade-offs with memory consumption but this is longer term issue
> > >
> > > The distros are currently satisfied with the 128 cores default, so
> > the decision here was: Leave the 128 cores default as is, for now.
> > >
> > > Any long term improvements regarding memory consumption of many-core
> > systems are not relevant for this patch.
> > >
> > > > - Acceptance for the direction of this patch in the short term
> > >
> > > With the twist that it must work for cross compile. It is the
> > properties of the target CPU that matter, not the properties of the
> > host
> > > CPU. (Although the build may be "native", i.e. the target CPU is the
> > same as the host CPU, it is still the target CPU that matters.)
> > >
> > > > - Details of whether it should be for EPYC only or x86 to be
> > figured
> > > > out
> > > > on mailing list
> > >
> > > I think this is obvious...
> > >
> > > ARM already provides ARM CPU specific optimizations.
> > > AMD should be allowed to provide AMD CPU specific optimizations too.
> > > Intel can also provide Intel CPU specific optimizations.
> >
> > I suppose no-one stopping AMD/Intel/ARM to provide their CPU specific
> > optimizations.
> > Though as end-user, my preference would be to have one generic build
> > (machine=default) that would work ok
> > on all cpus for given architecture (let say x86) instead of
> > maintaining/testing dozens of different flavors.
> 
> Agree. Machine specific builds should be explicitly specified. I consider "native" a variant of explicitly specifying the target machine.
> 
> > I suppose for 23.11 we have not much choice but accept that patch as it
> > is.
> 
> No. They agreed in the techboard meeting to rework it for cross compile.

Ah, yes, cross-builds, nearly forgot about them.
I suppose yes, you are right, it needs to be supported for completeness.
 
> 
> > Though I think in future (24.11?) it would be ideal to make
> > RTE_MAX_LCORE a runtime parameter and
> > remove it from public API structs.
> 
> It is probably more difficult than it sounds to fully remove RTE_MAX_LCORE.

I am not saying it is not an easy one, otherwise probably it will be already done.
 
> However, if we could make it mostly a runtime parameter, and only keep RTE_MAX_LCORE in arrays of small structures, we could
> increase it to some very large (but still sane) value, like 4096 or whatever number of CPU cores can be found in the largest system out
> there.
> >
> > >
> > > And if some of these optimizations are rooted in the same criteria,
> > they should be shared across the relevant CPU architectures. We
> > > follow this principle in the source code files, and the principle
> > also applies to the build files.
> > >
> > > >
> > > > So now let's figure out the details please.
> > > > Suggestions?
> > >
> > > Suggestions provided inline above. :-)

RE: [PATCH] config/x86: config support for AMD EPYC processors

[Tummala, Sivaprasad]

[AMD Official Use Only - General]

Hi Konstantin, Morten,

> -----Original Message-----
> From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> Sent: Tuesday, November 7, 2023 8:03 PM
> To: Morten Brørup <mb@smartsharesystems.com>; Thomas Monjalon
> <thomas@monjalon.net>; Kevin Traynor <ktraynor@redhat.com>; Tummala,
> Sivaprasad <Sivaprasad.Tummala@amd.com>; David Marchand
> <david.marchand@redhat.com>; Yigit, Ferruh <Ferruh.Yigit@amd.com>;
> bruce.richardson@intel.com; konstantin.v.ananyev@yandex.ru;
> maxime.coquelin@redhat.com; Aaron Conole <aconole@redhat.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] config/x86: config support for AMD EPYC processors
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> > > > > > > >> From: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> > > > > > > >>> From: David Marchand <david.marchand@redhat.com> On Mon,
> > > > > > > >>> Sep 25, 2023 at 5:11 PM Sivaprasad Tummala
> > > > > > > >>>> From: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> > > > > > > >>>>
> > > > > > > >>>> By default, max lcores are limited to 128 for x86
> > > platforms.
> > > > > > > >>>> On AMD EPYC processors, this limit needs to be
> > > > > > > >>>> increased
> > > to
> > > > > > > leverage
> > > > > > > >>>> all the cores.
> > > > > > > >>>>
> > > > > > > >>>> The patch adjusts the limit specifically for native
> > > > > compilation on
> > > > > > > >>>> AMD EPYC CPUs.
> > > > > > > >>>>
> > > > > > > >>>> Signed-off-by: Sivaprasad Tummala
> > > <Sivaprasad.Tummala@amd.com>
> > > > > > > >>>
> > > > > > > >>> This patch is a revamp of
> > > > > > > >>>
> > > > > > > >>
> > > > > > >
> > > > >
> > >
> http://inbox.dpdk.org/dev/BY5PR12MB3681C3FC6676BC03F0B42CCC96789@BY5
> > > PR
> > > > > > > >>> 12MB3681.namprd12.prod.outlook.com/
> > > > > > > >>> for which a discussion at techboard is supposed to have
> > > taken
> > > > > place.
> > > > > > > >>> But I didn't find a trace of it.
> > > > > > > >>>
> > > > > > > >>> One option that had been discussed in the previous
> > > > > > > >>> thread
> > > was
> > > > > to
> > > > > > > >>> increase the max number of cores for x86.
> > > > > > > >>> I am unclear if this option has been properly
> > > > > evaluated/debatted.
> > > > > >
> > > > > > Here are the minutes from the previous techboard discussions:
> > > > > > [1]: http://inbox.dpdk.org/dev/YZ43U36bFWHYClAi@platinum/
> > > > > > [2]:
> > > http://inbox.dpdk.org/dev/20211202112506.68acaa1a@hermes.local/
> > > > > >
> > > > > > AFAIK, there has been no progress with dynamic max_lcores, so
> > > > > > I
> > > guess
> > > > > the techboard's conclusion still stands:
> > > > > >
> > > > > > There is no identified use-case where a single application
> > > requires
> > > > > more than 128 lcores. If a case a use-case exists for a single
> > > > > application that uses more than 128 lcores, the TB is ok to
> > > > > update
> > > the
> > > > > default config value.
> > > > > >
> > > > > > > >>>
> > > > > > > >>> Can the topic be brought again at techboard?
> > > > > > > >>
> > > > > > > >> Hi David,
> > > > > > > >>
> > > > > > > >> The patch is intended to detect AMD platforms and enable
> > > > > > > >> all
> > > CPU
> > > > > > > cores by default
> > > > > > > >> on native builds.
> > > > > >
> > > > > > This is done on native ARM builds, so why not on native X86
> > > builds
> > > > > too?
> > > > > >
> > > > > > > >>
> > > > > > > >> As an optimization for memory footprint, users can
> > > > > > > >> override
> > > this
> > > > > by
> > > > > > > specifying "-
> > > > > > > >> Dmax_lcores" option based on DPDK lcores required for
> > > > > > > >> their
> > > > > usecases.
> > > > > > > >>
> > > > > > > >> Sure, will request to add this topic for discussion at
> > > > > techboard.
> > > > >
> > > > > This is the summary of the techboard meeting:
> > > > > (see
> > > > > https://mails.dpdk.org/archives/dev/2023-October/279672.html)
> > > > >
> > > > > - There is some asks for more than 128 worker cores
> > > > > - Discussion about generally increasing the default max core
> > > > > count
> > > and
> > > > > trade-offs with memory consumption but this is longer term issue
> > > >
> > > > The distros are currently satisfied with the 128 cores default, so
> > > the decision here was: Leave the 128 cores default as is, for now.
> > > >
> > > > Any long term improvements regarding memory consumption of
> > > > many-core
> > > systems are not relevant for this patch.
> > > >
> > > > > - Acceptance for the direction of this patch in the short term
> > > >
> > > > With the twist that it must work for cross compile. It is the
> > > properties of the target CPU that matter, not the properties of the
> > > host
> > > > CPU. (Although the build may be "native", i.e. the target CPU is
> > > > the
> > > same as the host CPU, it is still the target CPU that matters.)
> > > >
> > > > > - Details of whether it should be for EPYC only or x86 to be
> > > figured
> > > > > out
> > > > > on mailing list
> > > >
> > > > I think this is obvious...
> > > >
> > > > ARM already provides ARM CPU specific optimizations.
> > > > AMD should be allowed to provide AMD CPU specific optimizations too.
> > > > Intel can also provide Intel CPU specific optimizations.
> > >
> > > I suppose no-one stopping AMD/Intel/ARM to provide their CPU
> > > specific optimizations.
> > > Though as end-user, my preference would be to have one generic build
> > > (machine=default) that would work ok on all cpus for given
> > > architecture (let say x86) instead of maintaining/testing dozens of
> > > different flavors.
> >
> > Agree. Machine specific builds should be explicitly specified. I consider "native" a
> variant of explicitly specifying the target machine.
> >
> > > I suppose for 23.11 we have not much choice but accept that patch as
> > > it is.
> >
> > No. They agreed in the techboard meeting to rework it for cross compile.
>
> Ah, yes, cross-builds, nearly forgot about them.
> I suppose yes, you are right, it needs to be supported for completeness.
>

Yes, currently the patch is targeted to support max lcores selection only for native builds.
Cross-compilation works as it is now.

Once this patch is merged in this release, we plan to extend for cross builds in the coming releases.

> >
> > > Though I think in future (24.11?) it would be ideal to make
> > > RTE_MAX_LCORE a runtime parameter and remove it from public API
> > > structs.
> >
> > It is probably more difficult than it sounds to fully remove RTE_MAX_LCORE.
>
> I am not saying it is not an easy one, otherwise probably it will be already done.
>
> > However, if we could make it mostly a runtime parameter, and only keep
> > RTE_MAX_LCORE in arrays of small structures, we could increase it to
> > some very large (but still sane) value, like 4096 or whatever number of CPU
> cores can be found in the largest system out there.
> > >
> > > >
> > > > And if some of these optimizations are rooted in the same
> > > > criteria,
> > > they should be shared across the relevant CPU architectures. We
> > > > follow this principle in the source code files, and the principle
> > > also applies to the build files.
> > > >
> > > > >
> > > > > So now let's figure out the details please.
> > > > > Suggestions?
> > > >
> > > > Suggestions provided inline above. :-)

RE: [PATCH] config/x86: config support for AMD EPYC processors

[Morten Brørup]

> From: Tummala, Sivaprasad [mailto:Sivaprasad.Tummala@amd.com]
> Sent: Wednesday, 8 November 2023 13.24
> 
> [AMD Official Use Only - General]
> 
> Hi Konstantin, Morten,
> 
> > From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> > Sent: Tuesday, November 7, 2023 8:03 PM
> >
> >
> > > > I suppose for 23.11 we have not much choice but accept that patch
> > > > as it is.
> > >
> > > No. They agreed in the techboard meeting to rework it for cross
> compile.
> >
> > Ah, yes, cross-builds, nearly forgot about them.
> > I suppose yes, you are right, it needs to be supported for
> completeness.
> >
> 
> Yes, currently the patch is targeted to support max lcores selection
> only for native builds.
> Cross-compilation works as it is now.
> 
> Once this patch is merged in this release, we plan to extend for cross
> builds in the coming releases.

OK, I'll accept this approach.

Acked-by: Morten Brørup <mb@smartsharesystems.com>

RE: [PATCH] config/x86: config support for AMD EPYC processors

[Konstantin Ananyev]

> Hi Konstantin, Morten,
> 
> > -----Original Message-----
> > From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> > Sent: Tuesday, November 7, 2023 8:03 PM
> > To: Morten Brørup <mb@smartsharesystems.com>; Thomas Monjalon
> > <thomas@monjalon.net>; Kevin Traynor <ktraynor@redhat.com>; Tummala,
> > Sivaprasad <Sivaprasad.Tummala@amd.com>; David Marchand
> > <david.marchand@redhat.com>; Yigit, Ferruh <Ferruh.Yigit@amd.com>;
> > bruce.richardson@intel.com; konstantin.v.ananyev@yandex.ru;
> > maxime.coquelin@redhat.com; Aaron Conole <aconole@redhat.com>
> > Cc: dev@dpdk.org
> > Subject: RE: [PATCH] config/x86: config support for AMD EPYC processors
> >
> > Caution: This message originated from an External Source. Use proper caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > > > > > > > >> From: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> > > > > > > > >>> From: David Marchand <david.marchand@redhat.com> On Mon,
> > > > > > > > >>> Sep 25, 2023 at 5:11 PM Sivaprasad Tummala
> > > > > > > > >>>> From: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> > > > > > > > >>>>
> > > > > > > > >>>> By default, max lcores are limited to 128 for x86
> > > > platforms.
> > > > > > > > >>>> On AMD EPYC processors, this limit needs to be
> > > > > > > > >>>> increased
> > > > to
> > > > > > > > leverage
> > > > > > > > >>>> all the cores.
> > > > > > > > >>>>
> > > > > > > > >>>> The patch adjusts the limit specifically for native
> > > > > > compilation on
> > > > > > > > >>>> AMD EPYC CPUs.
> > > > > > > > >>>>
> > > > > > > > >>>> Signed-off-by: Sivaprasad Tummala
> > > > <Sivaprasad.Tummala@amd.com>
> > > > > > > > >>>
> > > > > > > > >>> This patch is a revamp of
> > > > > > > > >>>
> > > > > > > > >>
> > > > > > > >
> > > > > >
> > > >
> > http://inbox.dpdk.org/dev/BY5PR12MB3681C3FC6676BC03F0B42CCC96789@BY5
> > > > PR
> > > > > > > > >>> 12MB3681.namprd12.prod.outlook.com/
> > > > > > > > >>> for which a discussion at techboard is supposed to have
> > > > taken
> > > > > > place.
> > > > > > > > >>> But I didn't find a trace of it.
> > > > > > > > >>>
> > > > > > > > >>> One option that had been discussed in the previous
> > > > > > > > >>> thread
> > > > was
> > > > > > to
> > > > > > > > >>> increase the max number of cores for x86.
> > > > > > > > >>> I am unclear if this option has been properly
> > > > > > evaluated/debatted.
> > > > > > >
> > > > > > > Here are the minutes from the previous techboard discussions:
> > > > > > > [1]: http://inbox.dpdk.org/dev/YZ43U36bFWHYClAi@platinum/
> > > > > > > [2]:
> > > > http://inbox.dpdk.org/dev/20211202112506.68acaa1a@hermes.local/
> > > > > > >
> > > > > > > AFAIK, there has been no progress with dynamic max_lcores, so
> > > > > > > I
> > > > guess
> > > > > > the techboard's conclusion still stands:
> > > > > > >
> > > > > > > There is no identified use-case where a single application
> > > > requires
> > > > > > more than 128 lcores. If a case a use-case exists for a single
> > > > > > application that uses more than 128 lcores, the TB is ok to
> > > > > > update
> > > > the
> > > > > > default config value.
> > > > > > >
> > > > > > > > >>>
> > > > > > > > >>> Can the topic be brought again at techboard?
> > > > > > > > >>
> > > > > > > > >> Hi David,
> > > > > > > > >>
> > > > > > > > >> The patch is intended to detect AMD platforms and enable
> > > > > > > > >> all
> > > > CPU
> > > > > > > > cores by default
> > > > > > > > >> on native builds.
> > > > > > >
> > > > > > > This is done on native ARM builds, so why not on native X86
> > > > builds
> > > > > > too?
> > > > > > >
> > > > > > > > >>
> > > > > > > > >> As an optimization for memory footprint, users can
> > > > > > > > >> override
> > > > this
> > > > > > by
> > > > > > > > specifying "-
> > > > > > > > >> Dmax_lcores" option based on DPDK lcores required for
> > > > > > > > >> their
> > > > > > usecases.
> > > > > > > > >>
> > > > > > > > >> Sure, will request to add this topic for discussion at
> > > > > > techboard.
> > > > > >
> > > > > > This is the summary of the techboard meeting:
> > > > > > (see
> > > > > > https://mails.dpdk.org/archives/dev/2023-October/279672.html)
> > > > > >
> > > > > > - There is some asks for more than 128 worker cores
> > > > > > - Discussion about generally increasing the default max core
> > > > > > count
> > > > and
> > > > > > trade-offs with memory consumption but this is longer term issue
> > > > >
> > > > > The distros are currently satisfied with the 128 cores default, so
> > > > the decision here was: Leave the 128 cores default as is, for now.
> > > > >
> > > > > Any long term improvements regarding memory consumption of
> > > > > many-core
> > > > systems are not relevant for this patch.
> > > > >
> > > > > > - Acceptance for the direction of this patch in the short term
> > > > >
> > > > > With the twist that it must work for cross compile. It is the
> > > > properties of the target CPU that matter, not the properties of the
> > > > host
> > > > > CPU. (Although the build may be "native", i.e. the target CPU is
> > > > > the
> > > > same as the host CPU, it is still the target CPU that matters.)
> > > > >
> > > > > > - Details of whether it should be for EPYC only or x86 to be
> > > > figured
> > > > > > out
> > > > > > on mailing list
> > > > >
> > > > > I think this is obvious...
> > > > >
> > > > > ARM already provides ARM CPU specific optimizations.
> > > > > AMD should be allowed to provide AMD CPU specific optimizations too.
> > > > > Intel can also provide Intel CPU specific optimizations.
> > > >
> > > > I suppose no-one stopping AMD/Intel/ARM to provide their CPU
> > > > specific optimizations.
> > > > Though as end-user, my preference would be to have one generic build
> > > > (machine=default) that would work ok on all cpus for given
> > > > architecture (let say x86) instead of maintaining/testing dozens of
> > > > different flavors.
> > >
> > > Agree. Machine specific builds should be explicitly specified. I consider "native" a
> > variant of explicitly specifying the target machine.
> > >
> > > > I suppose for 23.11 we have not much choice but accept that patch as
> > > > it is.
> > >
> > > No. They agreed in the techboard meeting to rework it for cross compile.
> >
> > Ah, yes, cross-builds, nearly forgot about them.
> > I suppose yes, you are right, it needs to be supported for completeness.
> >
> 
> Yes, currently the patch is targeted to support max lcores selection only for native builds.
> Cross-compilation works as it is now.
> 
> Once this patch is merged in this release, we plan to extend for cross builds in the coming releases.

Works for me.
 

Re: [PATCH] config/x86: config support for AMD EPYC processors

[Thomas Monjalon]

25/09/2023 17:10, Sivaprasad Tummala:
> From: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> 
> By default, max lcores are limited to 128 for x86 platforms.
> On AMD EPYC processors, this limit needs to be increased to
> leverage all the cores.
> 
> The patch adjusts the limit specifically for native compilation
> on AMD EPYC CPUs.
> 
> Signed-off-by: Sivaprasad Tummala <Sivaprasad.Tummala@amd.com>
> ---
> +epyc_zen_cores = {
> +    '__znver4__':512,
> +    '__znver3__':256,
> +    '__znver2__':256,
> +    '__znver1__':128
> +    }
> +
> +if get_option('platform') == 'native'
> +    foreach m:epyc_zen_cores.keys()
> +        if cc.get_define(m, args: machine_args) != ''
> +            dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
> +            break
> +        endif
> +    endforeach
> +endif

Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>

Agreed in techboard:
https://mails.dpdk.org/archives/dev/2023-October/279672.html)

Applied, thanks.

RE: [PATCH] config/x86: config support for AMD EPYC processors

[Tummala, Sivaprasad]

[AMD Official Use Only - General]

Hi Morten,

> -----Original Message-----
> From: Morten Brørup <mb@smartsharesystems.com>
> Sent: Wednesday, December 20, 2023 12:58 PM
> To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>;
> david.marchand@redhat.com; ktraynor@redhat.com; thomas@monjalon.net;
> konstantin.ananyev@huawei.com; konstantin.v.ananyev@yandex.ru;
> bruce.richardson@intel.com; maxime.coquelin@redhat.com;
> aconole@redhat.com; Yigit, Ferruh <Ferruh.Yigit@amd.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] config/x86: config support for AMD EPYC processors
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> > From: Sivaprasad Tummala [mailto:sivaprasad.tummala@amd.com]
> > Sent: Wednesday, 20 December 2023 08.11
> >
> > On x86 platforms, max lcores are limited to 128 by default.
> >
> > On AMD EPYC processors, this limit was adjusted for native builds in
> > the previous patch.
> > https://patches.dpdk.org/project/dpdk/patch/
> > 20230925151027.558546-1-sivaprasad.tummala@amd.com/
> >
> > As agreed earlier in mailing list, this patch adjusts the limit for
> > specific AMD EPYC target/cross builds.
> >
> > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > ---
>
> [...]
>
> > +    foreach m:epyc_zen_cores.keys()
> > +        if m.contains(cpu_instruction_set)
> > +            dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
> > +         break
>
> The indentation of "break" uses a mix of tab and spaces, and should be fixed.
Thanks for spotting this. Will fix this in v2.
>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>

RE: [PATCH] config/x86: config support for AMD EPYC processors

[Morten Brørup]

> From: Sivaprasad Tummala [mailto:sivaprasad.tummala@amd.com]
> Sent: Wednesday, 20 December 2023 08.11
> 
> On x86 platforms, max lcores are limited to 128 by default.
> 
> On AMD EPYC processors, this limit was adjusted for native
> builds in the previous patch.
> https://patches.dpdk.org/project/dpdk/patch/
> 20230925151027.558546-1-sivaprasad.tummala@amd.com/
> 
> As agreed earlier in mailing list, this patch adjusts the limit
> for specific AMD EPYC target/cross builds.
> 
> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> ---

[...]

> +    foreach m:epyc_zen_cores.keys()
> +        if m.contains(cpu_instruction_set)
> +            dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
> +	    break

The indentation of "break" uses a mix of tab and spaces, and should be fixed.

Acked-by: Morten Brørup <mb@smartsharesystems.com>

[PATCH] config/x86: config support for AMD EPYC processors

[Sivaprasad Tummala]

On x86 platforms, max lcores are limited to 128 by default.

On AMD EPYC processors, this limit was adjusted for native
builds in the previous patch.
https://patches.dpdk.org/project/dpdk/patch/
20230925151027.558546-1-sivaprasad.tummala@amd.com/

As agreed earlier in mailing list, this patch adjusts the limit
for specific AMD EPYC target/cross builds.

Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
---
 config/x86/meson.build | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/config/x86/meson.build b/config/x86/meson.build
index 5355731cef..f2df4c2003 100644
--- a/config/x86/meson.build
+++ b/config/x86/meson.build
@@ -91,13 +91,21 @@ epyc_zen_cores = {
     '__znver1__':128
     }
 
-if get_option('platform') == 'native'
+cpu_instruction_set = get_option('cpu_instruction_set')
+if cpu_instruction_set == 'native'
     foreach m:epyc_zen_cores.keys()
         if cc.get_define(m, args: machine_args) != ''
             dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
             break
         endif
     endforeach
+else
+    foreach m:epyc_zen_cores.keys()
+        if m.contains(cpu_instruction_set)
+            dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
+	    break
+        endif
+    endforeach
 endif
 
 dpdk_conf.set('RTE_MAX_NUMA_NODES', 32)
-- 
2.25.1