DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>
Cc: "David Marchand" <david.marchand@redhat.com>, <dev@dpdk.org>,
	<konstantin.v.ananyev@yandex.ru>
Subject: RE: [PATCH] dumpcap: fix mbuf pool ring type
Date: Tue, 7 Nov 2023 18:38:32 +0100	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9EFEC@smartserver.smartshare.dk> (raw)
In-Reply-To: <20231107084113.1bff7d9e@hermes.local>

> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Tuesday, 7 November 2023 17.41
> 
> On Tue, 7 Nov 2023 08:22:37 +0100
> Morten Brørup <mb@smartsharesystems.com> wrote:
> 
> > > >
> > > > Or are you saying that if they want to use dumpcap, they must
> choose
> > > a thread safe pool type for their application (regardless if the
> > > application is single-threaded or not)?
> > >
> > > There is no command line of EAL nature in dumpcap.
> > > This is intentional.
> > > QED: overriding default pool type is not going to be a possible
> >
> > The preferred mbuf pool type can configured in the primary process by
> EAL params. If so configured, it is stored in a memzone named
> "mbuf_user_pool_ops".
> > And if it is set there, the secondary process will also use it as its
> preferred mbuf pool type.
> 
> If user decides to use a thread unsafe mempool, wouldn't it break in
> every PMD as well.

Yes, except if the application only uses one thread for packet processing. Then thread safety is not necessary.


  reply	other threads:[~2023-11-07 17:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-04 16:16 Stephen Hemminger
2023-08-05  9:05 ` Morten Brørup
2023-10-02  7:33 ` David Marchand
2023-10-02  8:42   ` Morten Brørup
2023-11-06 19:23     ` Stephen Hemminger
2023-11-06 21:50       ` Morten Brørup
2023-11-07  2:36         ` Stephen Hemminger
2023-11-07  7:22           ` Morten Brørup
2023-11-07 16:41             ` Stephen Hemminger
2023-11-07 17:38               ` Morten Brørup [this message]
2023-11-08 16:50                 ` Stephen Hemminger
2023-11-08 17:43                   ` Morten Brørup
2023-11-07 17:00             ` Stephen Hemminger
2023-11-06 19:24   ` Stephen Hemminger
2023-11-06 19:34 ` [PATCH v2] " Stephen Hemminger
2023-11-08 17:47 ` [PATCH v3 ] " Stephen Hemminger
2023-11-09  7:21   ` Morten Brørup
2023-11-12 14:05     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9EFEC@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.v.ananyev@yandex.ru \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).