From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 293AB432E1; Thu, 9 Nov 2023 08:34:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 182B742DDF; Thu, 9 Nov 2023 08:34:39 +0100 (CET) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 43CB54021E for ; Thu, 9 Nov 2023 08:34:38 +0100 (CET) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 2A0FF2231C; Thu, 9 Nov 2023 08:34:38 +0100 (CET) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH v3 1/5] pdump: fix setting rte_errno on mp error X-MimeOLE: Produced By Microsoft Exchange V6.5 Date: Thu, 9 Nov 2023 08:34:35 +0100 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9EFF9@smartserver.smartshare.dk> In-Reply-To: <20231108183557.381955-2-stephen@networkplumber.org> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH v3 1/5] pdump: fix setting rte_errno on mp error Thread-Index: AdoScnj5TXT9gMWlTTSAA85pKTcw5wAbKysQ References: <20230921042349.104150-1-stephen@networkplumber.org> <20231108183557.381955-1-stephen@networkplumber.org> <20231108183557.381955-2-stephen@networkplumber.org> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Stephen Hemminger" , X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Wednesday, 8 November 2023 19.36 >=20 > The response from MP server sets err_value to negative > on error. The convention for rte_errno is to use a positive > value on error. This makes errors like duplicate registration > show up with the correct error value. >=20 > Fixes: 660098d61f57 ("pdump: use generic multi-process channel") > Signed-off-by: Stephen Hemminger > --- Acked-by: Morten Br=F8rup