From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9449F432E1; Thu, 9 Nov 2023 08:50:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 17FE54021E; Thu, 9 Nov 2023 08:50:13 +0100 (CET) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id D742C4013F for ; Thu, 9 Nov 2023 08:50:11 +0100 (CET) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 9AF942231C; Thu, 9 Nov 2023 08:50:11 +0100 (CET) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH v3 2/5] dumpcap: allow multiple invocations X-MimeOLE: Produced By Microsoft Exchange V6.5 Date: Thu, 9 Nov 2023 08:50:10 +0100 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9EFFA@smartserver.smartshare.dk> In-Reply-To: <20231108183557.381955-3-stephen@networkplumber.org> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH v3 2/5] dumpcap: allow multiple invocations Thread-Index: AdoScn4inWXNrM9FTDSymrWFiBKHHAAbL5Rw References: <20230921042349.104150-1-stephen@networkplumber.org> <20231108183557.381955-1-stephen@networkplumber.org> <20231108183557.381955-3-stephen@networkplumber.org> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Stephen Hemminger" , Cc: "Isaac Boukris" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Wednesday, 8 November 2023 19.36 >=20 > If dumpcap is run twice with each instance pointing a different > interface, it would fail because of overlap in ring a pool names. > Fix by putting process id in the name. >=20 > Fixes: cbb44143be74 ("app/dumpcap: add new packet capture = application") > Reported-by: Isaac Boukris > Signed-off-by: Stephen Hemminger > --- Minor detail: getpid() returns int, so prefer %d over %u. [...] > rte_exit(EXIT_FAILURE, > "Packet dump enable on %u:%s failed %s\n", > intf->port, intf->name, > - rte_strerror(-ret)); > + rte_strerror(rte_errno)); This bugfix (the line above, not the patch itself) supports Tyler's = proposal to standardize on returning -1 with rte_errno set on failure, = instead of some functions returning -errno. Our dual convention for = function return values will cause many bugs like this. With %u or %d, Reviewed-by: Morten Br=F8rup