From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9886C432EA;
	Thu,  9 Nov 2023 21:09:54 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2B2F4402EA;
	Thu,  9 Nov 2023 21:09:54 +0100 (CET)
Received: from dkmailrelay1.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 33728402E7
 for <dev@dpdk.org>; Thu,  9 Nov 2023 21:09:53 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesys.local [192.168.4.10])
 by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id EA79220E53;
 Thu,  9 Nov 2023 21:09:52 +0100 (CET)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v5 2/5] dumpcap: allow multiple invocations
X-MimeOLE: Produced By Microsoft Exchange V6.5
Date: Thu, 9 Nov 2023 21:09:50 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F00D@smartserver.smartshare.dk>
In-Reply-To: <20231109194557.111350-3-stephen@networkplumber.org>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v5 2/5] dumpcap: allow multiple invocations
Thread-Index: AdoTRWuau5LTgDjgQae/o9icuQaxCQAAwNAA
References: <20230921042349.104150-1-stephen@networkplumber.org>
 <20231109194557.111350-1-stephen@networkplumber.org>
 <20231109194557.111350-3-stephen@networkplumber.org>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>,
	<dev@dpdk.org>
Cc: "Isaac Boukris" <iboukris@gmail.com>,
 "Reshma Pattan" <reshma.pattan@intel.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Thursday, 9 November 2023 20.46
>=20
> If dumpcap is run twice with each instance pointing a different
> interface, it would fail because of overlap in ring a pool names.
> Fix by putting process id in the name.
>=20
> It is still not allowed to do multiple invocations on the same
> interface because only one callback is allowed and only one copy
> of mbuf is done. Dumpcap will fail with error in this case:
>=20
>    pdump_prepare_client_request(): client request for pdump
> enable/disable failed
>    EAL: Error - exiting with code: 1
>      Cause: Packet dump enable on 0:net_null0 failed File exists
>=20
> Fixes: cbb44143be74 ("app/dumpcap: add new packet capture =
application")
> Reported-by: Isaac Boukris <iboukris@gmail.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

Reviewed-by: Morten Br=F8rup <mb@smartsharesystems.com>