From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6E24E43B28;
	Fri, 16 Feb 2024 09:04:24 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5B28242E95;
	Fri, 16 Feb 2024 09:04:24 +0100 (CET)
Received: from dkmailrelay1.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 978D842E8B
 for <dev@dpdk.org>; Fri, 16 Feb 2024 09:04:23 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesys.local [192.168.4.10])
 by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 786AF206EF;
 Fri, 16 Feb 2024 09:04:23 +0100 (CET)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v2 1/3] examples/l2fwd-keepalive: don't use EAL logtype
X-MimeOLE: Produced By Microsoft Exchange V6.5
Date: Fri, 16 Feb 2024 09:04:21 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F222@smartserver.smartshare.dk>
In-Reply-To: <20240216033743.150800-2-stephen@networkplumber.org>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v2 1/3] examples/l2fwd-keepalive: don't use EAL logtype
Thread-Index: AdpgiY2KKH0Sbcq1SZCSUhvzK4T+zwAJHWxA
References: <20231211172437.61958-1-stephen@networkplumber.org>
 <20240216033743.150800-1-stephen@networkplumber.org>
 <20240216033743.150800-2-stephen@networkplumber.org>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>,
	<dev@dpdk.org>
Cc: "Huisong Li" <lihuisong@huawei.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Friday, 16 February 2024 04.36
>=20
> EAL logtype should be reserved for EAL library.
> This example is already using printf() so just print
> errors to stderr.
>=20
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Huisong Li <lihuisong@huawei.com>
> ---

Optionally, please consider using RTE_LOG(INFO, L2FWD, ...) instead. =
This would require #define RTE_LOGTYPE_L2FWD RTE_LOGTYPE_USER1 in the =
shm.c file too, or defining it in a common header for the two C files.

And while you are at it, shm.c also has a couple of printf for warnings; =
please consider converting those too. Either to RTE_LOG(INFO, L2FWD, =
...) or to fprintf(stderr, ...).

Anyway...

Acked-by: Morten Br=F8rup <mb@smartsharesystems.com>