From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>,
"Chaoyong He" <chaoyong.he@corigine.com>
Cc: <dev@dpdk.org>, <oss-drivers@corigine.com>,
"Long Wu" <long.wu@corigine.com>,
"Peng Zhang" <peng.zhang@corigine.com>
Subject: RE: [PATCH] net/nfp: add support of UDP fragmentation offload
Date: Sat, 17 Feb 2024 19:02:30 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F228@smartserver.smartshare.dk> (raw)
In-Reply-To: <20240217084725.5a1c6f34@hermes.local>
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Saturday, 17 February 2024 17.47
>
> On Sat, 17 Feb 2024 09:54:10 +0800
> Chaoyong He <chaoyong.he@corigine.com> wrote:
>
> > Add the support of UDP fragmentation offload feature.
> >
> > Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> > Reviewed-by: Long Wu <long.wu@corigine.com>
> > Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
> > ---
> > drivers/common/nfp/nfp_common_ctrl.h | 1 +
> > drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 7 ++++++-
> > drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 8 +++++---
> > drivers/net/nfp/nfp_net_common.c | 8 ++++++--
> > 4 files changed, 18 insertions(+), 6 deletions(-)
>
> Looks like this depends on earlier patch, it does not apply directly to
> main branch.
>
> > - if ((ol_flags & RTE_MBUF_F_TX_TCP_SEG) == 0)
> > + if ((ol_flags & RTE_MBUF_F_TX_TCP_SEG) == 0 &&
> > + (ol_flags & RTE_MBUF_F_TX_UDP_SEG) == 0)
> > goto clean_txd;
>
> That is odd indentation style.
Not formally... it follows the official DPDK Coding Style [1].
[1]: https://doc.dpdk.org/guides/contributing/coding_style.html#general
> Should be:
>
> if ((ol_flags & RTE_MBUF_F_TX_TCP_SEG) == 0 &&
> (ol_flags & RTE_MBUF_F_TX_UDP_SEG) == 0)
> goto clean_txd;
This indentation style is mentioned as an alternative in the guide. But the example in the guide also uses two tabs for a similar long comparison.
Personally, I also prefer the style suggested by Stephen, so we might want to update the Coding Style. ;-)
next prev parent reply other threads:[~2024-02-17 18:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 1:54 Chaoyong He
2024-02-17 16:47 ` Stephen Hemminger
2024-02-17 18:02 ` Morten Brørup [this message]
2024-02-17 18:11 ` Stephen Hemminger
2024-02-18 10:05 ` Morten Brørup
2024-02-19 10:26 ` Bruce Richardson
2024-02-19 10:28 ` Ferruh Yigit
2024-02-19 13:30 ` Ferruh Yigit
2024-02-19 13:41 ` Ferruh Yigit
2024-02-20 7:54 ` Chaoyong He
2024-02-19 14:20 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F228@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=long.wu@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).