From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9DDEE43B9D;
	Fri, 23 Feb 2024 09:10:20 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 421AF4068A;
	Fri, 23 Feb 2024 09:10:20 +0100 (CET)
Received: from dkmailrelay1.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id DF1CA402ED
 for <dev@dpdk.org>; Fri, 23 Feb 2024 09:10:18 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesys.local [192.168.4.10])
 by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id A9FB22011D;
 Fri, 23 Feb 2024 09:10:18 +0100 (CET)
Subject: RE: [PATCH v2 00/17] stop using variadic argument pack extension
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Date: Fri, 23 Feb 2024 09:10:16 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F25B@smartserver.smartshare.dk>
Content-class: urn:content-classes:message
In-Reply-To: <1708645606-7514-1-git-send-email-roretzla@linux.microsoft.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
X-MimeOLE: Produced By Microsoft Exchange V6.5
Thread-Topic: [PATCH v2 00/17] stop using variadic argument pack extension
Thread-Index: Adpl6Wczi17tVDGwT+6PZn+3XaNpSQARiqew
References: <1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com>
 <1708645606-7514-1-git-send-email-roretzla@linux.microsoft.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Tyler Retzlaff" <roretzla@linux.microsoft.com>,
	<dev@dpdk.org>
Cc: "Anatoly Burakov" <anatoly.burakov@intel.com>,
 "Ashish Gupta" <ashish.gupta@marvell.com>,
 "Chenbo Xia" <chenbox@nvidia.com>,
 "Cristian Dumitrescu" <cristian.dumitrescu@intel.com>,
 "David Hunt" <david.hunt@intel.com>, "Fan Zhang" <fanzhang.oss@gmail.com>,
 "Hemant Agrawal" <hemant.agrawal@nxp.com>,
 "Honnappa Nagarahalli" <honnappa.nagarahalli@arm.com>,
 "Jasvinder Singh" <jasvinder.singh@intel.com>,
 "Jerin Jacob" <jerinj@marvell.com>,
 "Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>,
 "Maxime Coquelin" <maxime.coquelin@redhat.com>,
 "Reshma Pattan" <reshma.pattan@intel.com>,
 "Sachin Saxena" <sachin.saxena@nxp.com>,
 "Sivaprasad Tummala" <sivaprasad.tummala@amd.com>,
 "Srikanth Yalavarthi" <syalavarthi@marvell.com>,
 "Stephen Hemminger" <stephen@networkplumber.org>,
 "Sunil Kumar Kori" <skori@marvell.com>, <bruce.richardson@intel.com>,
 <thomas@monjalon.net>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> Sent: Friday, 23 February 2024 00.46
>=20
> RTE_LOG_LINE cannot be augmented with a prefix format and arguments
> without the user of RTE_LOG_LINE using the args... and ## args =
compiler
> extension to conditionally remove trailing comma when the macro =
receives
> only a single argument.
>=20
> Provide a new/similar macro RTE_LOG_LINE_PREFIX that accepts the =
prefix
> format and arguments as separate parameters allowing them to be =
expanded
> at the correct locations inside of RTE_FMT() allowing the rest of the
> non-prefix format string and arguments to be collapsed to the argument
> pack which can be directly forwarded with __VA_ARGS__ avoiding the =
need
> for conditional comma removal.
>=20
> I've done my best to manually check expansions (preprocessed) and
> compiled printf of the logs to validate correct output.
>=20
> note: due to drastic change in series i have not carried any series =
acks
>       forward.

Series-acked-by: Morten Br=F8rup <mb@smartsharesystems.com>