From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 68FD543C05;
	Tue, 27 Feb 2024 10:15:26 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E9E0A4027D;
	Tue, 27 Feb 2024 10:15:25 +0100 (CET)
Received: from dkmailrelay1.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 9987340150
 for <dev@dpdk.org>; Tue, 27 Feb 2024 10:15:24 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesys.local [192.168.4.10])
 by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 8E0A8208E6;
 Tue, 27 Feb 2024 10:15:23 +0100 (CET)
Content-class: urn:content-classes:message
Subject: RE: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Date: Tue, 27 Feb 2024 10:15:21 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F26D@smartserver.smartshare.dk>
In-Reply-To: <1709012499-12813-21-git-send-email-roretzla@linux.microsoft.com>
X-MimeOLE: Produced By Microsoft Exchange V6.5
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields
Thread-Index: AdppP6ZKFy7ZGQuVQaCD3fI49vzHhAAHSdWg
References: <1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com>
 <1709012499-12813-1-git-send-email-roretzla@linux.microsoft.com>
 <1709012499-12813-21-git-send-email-roretzla@linux.microsoft.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Tyler Retzlaff" <roretzla@linux.microsoft.com>,
	<dev@dpdk.org>
Cc: "Ajit Khaparde" <ajit.khaparde@broadcom.com>,
 "Andrew Boyer" <andrew.boyer@amd.com>,
 "Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
 "Bruce Richardson" <bruce.richardson@intel.com>,
 "Chenbo Xia" <chenbox@nvidia.com>,
 "Chengwen Feng" <fengchengwen@huawei.com>,
 "Dariusz Sosnowski" <dsosnowski@nvidia.com>,
 "David Christensen" <drc@linux.vnet.ibm.com>,
 "Hyong Youb Kim" <hyonkim@cisco.com>, "Jerin Jacob" <jerinj@marvell.com>,
 "Jie Hai" <haijie1@huawei.com>, "Jingjing Wu" <jingjing.wu@intel.com>,
 "John Daley" <johndale@cisco.com>, "Kevin Laatz" <kevin.laatz@intel.com>,
 "Kiran Kumar K" <kirankumark@marvell.com>,
 "Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>,
 "Maciej Czekaj" <mczekaj@marvell.com>, "Matan Azrad" <matan@nvidia.com>,
 "Maxime Coquelin" <maxime.coquelin@redhat.com>,
 "Nithin Dabilpuram" <ndabilpuram@marvell.com>,
 "Ori Kam" <orika@nvidia.com>, "Ruifeng Wang" <ruifeng.wang@arm.com>,
 "Satha Rao" <skoteshwar@marvell.com>,
 "Somnath Kotur" <somnath.kotur@broadcom.com>,
 "Suanming Mou" <suanmingm@nvidia.com>,
 "Sunil Kumar Kori" <skori@marvell.com>,
 "Viacheslav Ovsiienko" <viacheslavo@nvidia.com>,
 "Yisen Zhuang" <yisen.zhuang@huawei.com>,
 "Yuying Zhang" <Yuying.Zhang@intel.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> @@ -607,8 +603,7 @@ struct rte_mbuf {
>  	struct rte_mempool *pool; /**< Pool from which mbuf was allocated. =
*/
>=20
>  	/* second cache line - fields only used in slow path or on TX */
> -	RTE_MARKER cacheline1 __rte_cache_min_aligned;
> -
> +	alignas(RTE_CACHE_LINE_MIN_SIZE)

This comment is a matter of taste...

The alignas() is too far away from the field it applies to, and might =
get overlooked.
I would prefer it immediately before "struct rte_mbuf *next;" and =
"uint64_t dynfield2;".

>  #if RTE_IOVA_IN_MBUF
>  	/**
>  	 * Next segment of scattered packet. Must be NULL in the last