From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05AD243D50; Tue, 26 Mar 2024 10:35:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7EC014028B; Tue, 26 Mar 2024 10:35:57 +0100 (CET) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 1E7B840265 for ; Tue, 26 Mar 2024 10:35:56 +0100 (CET) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id D408B20CEF; Tue, 26 Mar 2024 10:35:55 +0100 (CET) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH v13 01/11] windows: make getopt functions have const properties Date: Tue, 26 Mar 2024 10:35:55 +0100 X-MimeOLE: Produced By Microsoft Exchange V6.5 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F32F@smartserver.smartshare.dk> In-Reply-To: <20240326015827.825648-2-stephen@networkplumber.org> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH v13 01/11] windows: make getopt functions have const properties Thread-Index: Adp/ISSBqEmRNqSaT6CNzHKWq8jqXgAP8NFA References: <20200814173441.23086-1-stephen@networkplumber.org> <20240326015827.825648-1-stephen@networkplumber.org> <20240326015827.825648-2-stephen@networkplumber.org> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Stephen Hemminger" , Cc: "Tyler Retzlaff" , "Dmitry Kozlyuk" , "Pallavi Kadam" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Tuesday, 26 March 2024 02.57 >=20 > Having different prototypes on different platforms can lead > to lots of unnecessary workarounds. Looks like the version of > getopt used from windows was based on an older out of date > version from FreeBSD. >=20 > This patch changes getopt, getopt_long, etc to have the same const > attributes as Linux and FreeBSD. The changes are derived from > the current FreeBSD version of getopt_long. >=20 > Signed-off-by: Stephen Hemminger > Acked-by: Tyler Retzlaff > Acked-by: Dmitry Kozlyuk > --- For the series, Acked-by: Morten Br=F8rup