From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F98D43D50; Tue, 26 Mar 2024 11:28:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 10A244028B; Tue, 26 Mar 2024 11:28:24 +0100 (CET) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 9CA0640265 for ; Tue, 26 Mar 2024 11:28:22 +0100 (CET) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 70FFE20CEF; Tue, 26 Mar 2024 11:28:22 +0100 (CET) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH v7 3/4] security: remove rte marker fields Date: Tue, 26 Mar 2024 11:28:21 +0100 X-MimeOLE: Produced By Microsoft Exchange V6.5 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F333@smartserver.smartshare.dk> In-Reply-To: <1710972098-2209-4-git-send-email-roretzla@linux.microsoft.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH v7 3/4] security: remove rte marker fields Thread-Index: Adp7EjBRpSbAm+9vR2eSyWDNB8iPkwEVP58A References: <1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com> <1710972098-2209-1-git-send-email-roretzla@linux.microsoft.com> <1710972098-2209-4-git-send-email-roretzla@linux.microsoft.com> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Tyler Retzlaff" , , "Akhil Goyal" , "Anoob Joseph" Cc: "Ajit Khaparde" , "Andrew Boyer" , "Andrew Rybchenko" , "Bruce Richardson" , "Chenbo Xia" , "Chengwen Feng" , "Dariusz Sosnowski" , "David Christensen" , "Hyong Youb Kim" , "Jerin Jacob" , "Jie Hai" , "Jingjing Wu" , "John Daley" , "Kevin Laatz" , "Kiran Kumar K" , "Konstantin Ananyev" , "Maciej Czekaj" , "Matan Azrad" , "Maxime Coquelin" , "Nithin Dabilpuram" , "Ori Kam" , "Ruifeng Wang" , "Satha Rao" , "Somnath Kotur" , "Suanming Mou" , "Sunil Kumar Kori" , "Viacheslav Ovsiienko" , "Yisen Zhuang" , "Yuying Zhang" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > Sent: Wednesday, 20 March 2024 23.02 >=20 > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > RTE_MARKER fields from rte_mbuf struct. >=20 > Maintain alignment of fields after removed cacheline1 marker by = placing > C11 alignas(RTE_CACHE_LINE_MIN_SIZE). >=20 > Signed-off-by: Tyler Retzlaff > --- > doc/guides/rel_notes/release_24_03.rst | 3 +++ > lib/security/rte_security_driver.h | 5 +++-- > 2 files changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/doc/guides/rel_notes/release_24_03.rst > b/doc/guides/rel_notes/release_24_03.rst > index 4f18cca..75d40d4 100644 > --- a/doc/guides/rel_notes/release_24_03.rst > +++ b/doc/guides/rel_notes/release_24_03.rst > @@ -219,6 +219,9 @@ Removed Items > * mbuf: ``RTE_MARKER`` fields ``cacheline0`` and ``cacheline1`` > have been removed from ``struct rte_mbuf``. >=20 > +* security: ``RTE_MARKER`` fields ``cacheline0`` and ``cacheline1`` > + have been removed from ``struct rte_security_session``. > + > API Changes > ----------- >=20 > diff --git a/lib/security/rte_security_driver.h > b/lib/security/rte_security_driver.h > index 09829ab..18a1e3c 100644 > --- a/lib/security/rte_security_driver.h > +++ b/lib/security/rte_security_driver.h > @@ -12,6 +12,8 @@ > * RTE Security Common Definitions > */ >=20 > +#include > + > #ifdef __cplusplus > extern "C" { > #endif > @@ -24,7 +26,6 @@ > * Security session to be used by library for internal usage > */ > struct rte_security_session { > - RTE_MARKER cacheline0; > uint64_t opaque_data; > /**< Opaque user defined data */ > uint64_t fast_mdata; > @@ -32,7 +33,7 @@ struct rte_security_session { > rte_iova_t driver_priv_data_iova; > /**< session private data IOVA address */ >=20 > - alignas(RTE_CACHE_LINE_MIN_SIZE) RTE_MARKER cacheline1; > + alignas(RTE_CACHE_LINE_MIN_SIZE) > uint8_t driver_priv_data[]; > /**< Private session material, variable size (depends on driver) > */ > }; > -- > 1.8.3.1 No explicit alignment was ever specified for the struct = rte_security_session itself. I wonder which implicit alignment applies = to it. Anyway, the changes are correct, so Reviewed-by: Morten Br=F8rup