* [PATCH] build: exclude rather than include libs in MSVC build @ 2024-04-02 16:55 Tyler Retzlaff 2024-04-02 16:55 ` Tyler Retzlaff 2024-04-03 18:23 ` [PATCH v2] " Tyler Retzlaff 0 siblings, 2 replies; 13+ messages in thread From: Tyler Retzlaff @ 2024-04-02 16:55 UTC (permalink / raw) To: dev Cc: Morten Brørup, Andrew Rybchenko, Bruce Richardson, Chengwen Feng, Honnappa Nagarahalli, Kevin Laatz, Tyler Retzlaff Some libraries that could be built with MSVC were not being built. Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds. With this change we now get immediate CI build coverage for the libs meter, timer, pci, cfgfile Tyler Retzlaff (1): build: exclude rather than include libs in MSVC build lib/argparse/meson.build | 6 ++++++ lib/dmadev/meson.build | 6 ++++++ lib/mbuf/meson.build | 6 ++++++ lib/mempool/meson.build | 6 ++++++ lib/meson.build | 10 ---------- lib/rcu/meson.build | 6 ++++++ lib/stack/meson.build | 6 ++++++ 7 files changed, 36 insertions(+), 10 deletions(-) -- 1.8.3.1 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] build: exclude rather than include libs in MSVC build 2024-04-02 16:55 [PATCH] build: exclude rather than include libs in MSVC build Tyler Retzlaff @ 2024-04-02 16:55 ` Tyler Retzlaff 2024-04-02 17:15 ` Stephen Hemminger 2024-04-05 20:33 ` Patrick Robb 2024-04-03 18:23 ` [PATCH v2] " Tyler Retzlaff 1 sibling, 2 replies; 13+ messages in thread From: Tyler Retzlaff @ 2024-04-02 16:55 UTC (permalink / raw) To: dev Cc: Morten Brørup, Andrew Rybchenko, Bruce Richardson, Chengwen Feng, Honnappa Nagarahalli, Kevin Laatz, Tyler Retzlaff Some libraries that could be built with MSVC were not being built. Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds. Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com> --- lib/argparse/meson.build | 6 ++++++ lib/dmadev/meson.build | 6 ++++++ lib/mbuf/meson.build | 6 ++++++ lib/mempool/meson.build | 6 ++++++ lib/meson.build | 10 ---------- lib/rcu/meson.build | 6 ++++++ lib/stack/meson.build | 6 ++++++ 7 files changed, 36 insertions(+), 10 deletions(-) diff --git a/lib/argparse/meson.build b/lib/argparse/meson.build index b6a08ca..8ab4c40 100644 --- a/lib/argparse/meson.build +++ b/lib/argparse/meson.build @@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2024 HiSilicon Limited. +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_argparse.c') headers = files('rte_argparse.h') diff --git a/lib/dmadev/meson.build b/lib/dmadev/meson.build index 62b0650..e66dcb6 100644 --- a/lib/dmadev/meson.build +++ b/lib/dmadev/meson.build @@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2021 HiSilicon Limited. +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_dmadev.c', 'rte_dmadev_trace_points.c') headers = files('rte_dmadev.h') indirect_headers += files('rte_dmadev_core.h', 'rte_dmadev_trace_fp.h') diff --git a/lib/mbuf/meson.build b/lib/mbuf/meson.build index 0435c5e..2cee905 100644 --- a/lib/mbuf/meson.build +++ b/lib/mbuf/meson.build @@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files( 'rte_mbuf.c', 'rte_mbuf_ptype.c', diff --git a/lib/mempool/meson.build b/lib/mempool/meson.build index 8099a56..acce66c 100644 --- a/lib/mempool/meson.build +++ b/lib/mempool/meson.build @@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + extra_flags = [] foreach flag: extra_flags diff --git a/lib/meson.build b/lib/meson.build index 179a272..94d2b72 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -68,16 +68,6 @@ libraries = [ 'node', ] -if is_ms_compiler - libraries = [ - 'log', - 'kvargs', - 'telemetry', - 'eal', - 'ring', - ] -endif - always_enable = [ 'cmdline', 'eal', diff --git a/lib/rcu/meson.build b/lib/rcu/meson.build index 09abc52..71143f5 100644 --- a/lib/rcu/meson.build +++ b/lib/rcu/meson.build @@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Arm Limited +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_rcu_qsbr.c') headers = files('rte_rcu_qsbr.h') diff --git a/lib/stack/meson.build b/lib/stack/meson.build index 18177a7..7631a14 100644 --- a/lib/stack/meson.build +++ b/lib/stack/meson.build @@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2019 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_stack.c', 'rte_stack_std.c', 'rte_stack_lf.c') headers = files('rte_stack.h') # subheaders, not for direct inclusion by apps -- 1.8.3.1 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] build: exclude rather than include libs in MSVC build 2024-04-02 16:55 ` Tyler Retzlaff @ 2024-04-02 17:15 ` Stephen Hemminger 2024-04-02 17:19 ` Tyler Retzlaff 2024-04-05 20:33 ` Patrick Robb 1 sibling, 1 reply; 13+ messages in thread From: Stephen Hemminger @ 2024-04-02 17:15 UTC (permalink / raw) To: Tyler Retzlaff Cc: dev, Morten Brørup, Andrew Rybchenko, Bruce Richardson, Chengwen Feng, Honnappa Nagarahalli, Kevin Laatz On Tue, 2 Apr 2024 09:55:48 -0700 Tyler Retzlaff <roretzla@linux.microsoft.com> wrote: > Some libraries that could be built with MSVC were not being built. > > Switch from explicit include to exclude of libs to get immediate CI > coverage of libraries that already work with MSVC Windows builds. > > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com> For mbuf, since it requires mempool, you might not need to explicitly exclude it. But the change looks good. Acked-by: Stephen Hemminger <stephen@networkplumber.org> ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] build: exclude rather than include libs in MSVC build 2024-04-02 17:15 ` Stephen Hemminger @ 2024-04-02 17:19 ` Tyler Retzlaff 0 siblings, 0 replies; 13+ messages in thread From: Tyler Retzlaff @ 2024-04-02 17:19 UTC (permalink / raw) To: Stephen Hemminger Cc: dev, Morten Brørup, Andrew Rybchenko, Bruce Richardson, Chengwen Feng, Honnappa Nagarahalli, Kevin Laatz On Tue, Apr 02, 2024 at 10:15:50AM -0700, Stephen Hemminger wrote: > On Tue, 2 Apr 2024 09:55:48 -0700 > Tyler Retzlaff <roretzla@linux.microsoft.com> wrote: > > > Some libraries that could be built with MSVC were not being built. > > > > Switch from explicit include to exclude of libs to get immediate CI > > coverage of libraries that already work with MSVC Windows builds. > > > > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com> > > For mbuf, since it requires mempool, you might not need to explicitly > exclude it. But the change looks good. interesting, i wonder if the dependency isn't properly working. the way i chose to exclude libs was to just enable them all and then selectively disable those that were attempted build but failed. mbuf did not complain of missing mempool and there was an attempt to build it. with your changes mempool will build though, just need to wait for it to merge. > Acked-by: Stephen Hemminger <stephen@networkplumber.org> ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] build: exclude rather than include libs in MSVC build 2024-04-02 16:55 ` Tyler Retzlaff 2024-04-02 17:15 ` Stephen Hemminger @ 2024-04-05 20:33 ` Patrick Robb 1 sibling, 0 replies; 13+ messages in thread From: Patrick Robb @ 2024-04-05 20:33 UTC (permalink / raw) To: Tyler Retzlaff Cc: dev, Morten Brørup, Andrew Rybchenko, Bruce Richardson, Chengwen Feng, Honnappa Nagarahalli, Kevin Laatz Recheck-request: iol-intel-Functional Sorry about the spam! On Tue, Apr 2, 2024 at 12:55 PM Tyler Retzlaff <roretzla@linux.microsoft.com> wrote: > > Some libraries that could be built with MSVC were not being built. > > Switch from explicit include to exclude of libs to get immediate CI > coverage of libraries that already work with MSVC Windows builds. > > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com> > --- > lib/argparse/meson.build | 6 ++++++ > lib/dmadev/meson.build | 6 ++++++ > lib/mbuf/meson.build | 6 ++++++ > lib/mempool/meson.build | 6 ++++++ > lib/meson.build | 10 ---------- > lib/rcu/meson.build | 6 ++++++ > lib/stack/meson.build | 6 ++++++ > 7 files changed, 36 insertions(+), 10 deletions(-) > > diff --git a/lib/argparse/meson.build b/lib/argparse/meson.build > index b6a08ca..8ab4c40 100644 > --- a/lib/argparse/meson.build > +++ b/lib/argparse/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2024 HiSilicon Limited. > > +if is_ms_compiler > + build = false > + reason = 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources = files('rte_argparse.c') > headers = files('rte_argparse.h') > > diff --git a/lib/dmadev/meson.build b/lib/dmadev/meson.build > index 62b0650..e66dcb6 100644 > --- a/lib/dmadev/meson.build > +++ b/lib/dmadev/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2021 HiSilicon Limited. > > +if is_ms_compiler > + build = false > + reason = 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources = files('rte_dmadev.c', 'rte_dmadev_trace_points.c') > headers = files('rte_dmadev.h') > indirect_headers += files('rte_dmadev_core.h', 'rte_dmadev_trace_fp.h') > diff --git a/lib/mbuf/meson.build b/lib/mbuf/meson.build > index 0435c5e..2cee905 100644 > --- a/lib/mbuf/meson.build > +++ b/lib/mbuf/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > +if is_ms_compiler > + build = false > + reason = 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources = files( > 'rte_mbuf.c', > 'rte_mbuf_ptype.c', > diff --git a/lib/mempool/meson.build b/lib/mempool/meson.build > index 8099a56..acce66c 100644 > --- a/lib/mempool/meson.build > +++ b/lib/mempool/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > +if is_ms_compiler > + build = false > + reason = 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > extra_flags = [] > > foreach flag: extra_flags > diff --git a/lib/meson.build b/lib/meson.build > index 179a272..94d2b72 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -68,16 +68,6 @@ libraries = [ > 'node', > ] > > -if is_ms_compiler > - libraries = [ > - 'log', > - 'kvargs', > - 'telemetry', > - 'eal', > - 'ring', > - ] > -endif > - > always_enable = [ > 'cmdline', > 'eal', > diff --git a/lib/rcu/meson.build b/lib/rcu/meson.build > index 09abc52..71143f5 100644 > --- a/lib/rcu/meson.build > +++ b/lib/rcu/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2018 Arm Limited > > +if is_ms_compiler > + build = false > + reason = 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources = files('rte_rcu_qsbr.c') > headers = files('rte_rcu_qsbr.h') > > diff --git a/lib/stack/meson.build b/lib/stack/meson.build > index 18177a7..7631a14 100644 > --- a/lib/stack/meson.build > +++ b/lib/stack/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2019 Intel Corporation > > +if is_ms_compiler > + build = false > + reason = 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources = files('rte_stack.c', 'rte_stack_std.c', 'rte_stack_lf.c') > headers = files('rte_stack.h') > # subheaders, not for direct inclusion by apps > -- > 1.8.3.1 > ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2] build: exclude rather than include libs in MSVC build 2024-04-02 16:55 [PATCH] build: exclude rather than include libs in MSVC build Tyler Retzlaff 2024-04-02 16:55 ` Tyler Retzlaff @ 2024-04-03 18:23 ` Tyler Retzlaff 2024-04-03 18:23 ` Tyler Retzlaff ` (2 more replies) 1 sibling, 3 replies; 13+ messages in thread From: Tyler Retzlaff @ 2024-04-03 18:23 UTC (permalink / raw) To: dev Cc: Morten Brørup, Andrew Rybchenko, Bruce Richardson, Chengwen Feng, Honnappa Nagarahalli, Kevin Laatz, Srikanth Yalavarthi, Vladimir Medvedkin, Tyler Retzlaff Some libraries that could be built with MSVC were not being built. Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds. With this change we now get immediate CI build coverage for the libs meter, timer, pci, cfgfile v2: * add a few more explicit exclusions for now as they are known to require more than trivial work and avoid needing to disable them later as the dependent libraries are enabled. Tyler Retzlaff (1): build: exclude rather than include libs in MSVC build lib/argparse/meson.build | 6 ++++++ lib/dmadev/meson.build | 6 ++++++ lib/fib/meson.build | 6 ++++++ lib/lpm/meson.build | 6 ++++++ lib/mbuf/meson.build | 6 ++++++ lib/mempool/meson.build | 6 ++++++ lib/meson.build | 10 ---------- lib/mldev/meson.build | 6 ++++++ lib/rcu/meson.build | 6 ++++++ lib/stack/meson.build | 6 ++++++ 10 files changed, 54 insertions(+), 10 deletions(-) -- 1.8.3.1 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2] build: exclude rather than include libs in MSVC build 2024-04-03 18:23 ` [PATCH v2] " Tyler Retzlaff @ 2024-04-03 18:23 ` Tyler Retzlaff 2024-04-03 18:50 ` Morten Brørup 2024-04-11 5:01 ` Patrick Robb 2024-04-03 21:51 ` Stephen Hemminger 2024-04-06 0:38 ` Patrick Robb 2 siblings, 2 replies; 13+ messages in thread From: Tyler Retzlaff @ 2024-04-03 18:23 UTC (permalink / raw) To: dev Cc: Morten Brørup, Andrew Rybchenko, Bruce Richardson, Chengwen Feng, Honnappa Nagarahalli, Kevin Laatz, Srikanth Yalavarthi, Vladimir Medvedkin, Tyler Retzlaff Some libraries that could be built with MSVC were not being built. Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds. Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com> Acked-by: Stephen Hemminger <stephen@networkplumber.org> --- lib/argparse/meson.build | 6 ++++++ lib/dmadev/meson.build | 6 ++++++ lib/fib/meson.build | 6 ++++++ lib/lpm/meson.build | 6 ++++++ lib/mbuf/meson.build | 6 ++++++ lib/mempool/meson.build | 6 ++++++ lib/meson.build | 10 ---------- lib/mldev/meson.build | 6 ++++++ lib/rcu/meson.build | 6 ++++++ lib/stack/meson.build | 6 ++++++ 10 files changed, 54 insertions(+), 10 deletions(-) diff --git a/lib/argparse/meson.build b/lib/argparse/meson.build index b6a08ca..8ab4c40 100644 --- a/lib/argparse/meson.build +++ b/lib/argparse/meson.build @@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2024 HiSilicon Limited. +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_argparse.c') headers = files('rte_argparse.h') diff --git a/lib/dmadev/meson.build b/lib/dmadev/meson.build index 62b0650..e66dcb6 100644 --- a/lib/dmadev/meson.build +++ b/lib/dmadev/meson.build @@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2021 HiSilicon Limited. +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_dmadev.c', 'rte_dmadev_trace_points.c') headers = files('rte_dmadev.h') indirect_headers += files('rte_dmadev_core.h', 'rte_dmadev_trace_fp.h') diff --git a/lib/fib/meson.build b/lib/fib/meson.build index ddcae06..6795f41 100644 --- a/lib/fib/meson.build +++ b/lib/fib/meson.build @@ -2,6 +2,12 @@ # Copyright(c) 2018 Vladimir Medvedkin <medvedkinv@gmail.com> # Copyright(c) 2019 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_fib.c', 'rte_fib6.c', 'dir24_8.c', 'trie.c') headers = files('rte_fib.h', 'rte_fib6.h') deps += ['rib'] diff --git a/lib/lpm/meson.build b/lib/lpm/meson.build index 4cd4888..ae30f80 100644 --- a/lib/lpm/meson.build +++ b/lib/lpm/meson.build @@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_lpm.c', 'rte_lpm6.c') headers = files('rte_lpm.h', 'rte_lpm6.h') # since header files have different names, we can install all vector headers diff --git a/lib/mbuf/meson.build b/lib/mbuf/meson.build index 0435c5e..2cee905 100644 --- a/lib/mbuf/meson.build +++ b/lib/mbuf/meson.build @@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files( 'rte_mbuf.c', 'rte_mbuf_ptype.c', diff --git a/lib/mempool/meson.build b/lib/mempool/meson.build index 8099a56..acce66c 100644 --- a/lib/mempool/meson.build +++ b/lib/mempool/meson.build @@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + extra_flags = [] foreach flag: extra_flags diff --git a/lib/meson.build b/lib/meson.build index 179a272..94d2b72 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -68,16 +68,6 @@ libraries = [ 'node', ] -if is_ms_compiler - libraries = [ - 'log', - 'kvargs', - 'telemetry', - 'eal', - 'ring', - ] -endif - always_enable = [ 'cmdline', 'eal', diff --git a/lib/mldev/meson.build b/lib/mldev/meson.build index 0079ccd..2c933ba 100644 --- a/lib/mldev/meson.build +++ b/lib/mldev/meson.build @@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright (c) 2022 Marvell. +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files( 'rte_mldev_pmd.c', 'rte_mldev.c', diff --git a/lib/rcu/meson.build b/lib/rcu/meson.build index 09abc52..71143f5 100644 --- a/lib/rcu/meson.build +++ b/lib/rcu/meson.build @@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Arm Limited +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_rcu_qsbr.c') headers = files('rte_rcu_qsbr.h') diff --git a/lib/stack/meson.build b/lib/stack/meson.build index 18177a7..7631a14 100644 --- a/lib/stack/meson.build +++ b/lib/stack/meson.build @@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2019 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_stack.c', 'rte_stack_std.c', 'rte_stack_lf.c') headers = files('rte_stack.h') # subheaders, not for direct inclusion by apps -- 1.8.3.1 ^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH v2] build: exclude rather than include libs in MSVC build 2024-04-03 18:23 ` Tyler Retzlaff @ 2024-04-03 18:50 ` Morten Brørup 2024-05-29 14:46 ` Thomas Monjalon 2024-04-11 5:01 ` Patrick Robb 1 sibling, 1 reply; 13+ messages in thread From: Morten Brørup @ 2024-04-03 18:50 UTC (permalink / raw) To: Tyler Retzlaff, dev Cc: Andrew Rybchenko, Bruce Richardson, Chengwen Feng, Honnappa Nagarahalli, Kevin Laatz, Srikanth Yalavarthi, Vladimir Medvedkin > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > Sent: Wednesday, 3 April 2024 20.23 > > Some libraries that could be built with MSVC were not being built. > > Switch from explicit include to exclude of libs to get immediate CI > coverage of libraries that already work with MSVC Windows builds. > > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com> > Acked-by: Stephen Hemminger <stephen@networkplumber.org> > --- Acked-by: Morten Brørup <mb@smartsharesystems.com> ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] build: exclude rather than include libs in MSVC build 2024-04-03 18:50 ` Morten Brørup @ 2024-05-29 14:46 ` Thomas Monjalon 0 siblings, 0 replies; 13+ messages in thread From: Thomas Monjalon @ 2024-05-29 14:46 UTC (permalink / raw) To: Tyler Retzlaff Cc: dev, Andrew Rybchenko, Bruce Richardson, Chengwen Feng, Honnappa Nagarahalli, Kevin Laatz, Srikanth Yalavarthi, Vladimir Medvedkin, Morten Brørup 03/04/2024 20:50, Morten Brørup: > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > > Sent: Wednesday, 3 April 2024 20.23 > > > > Some libraries that could be built with MSVC were not being built. > > > > Switch from explicit include to exclude of libs to get immediate CI > > coverage of libraries that already work with MSVC Windows builds. > > > > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com> > > Acked-by: Stephen Hemminger <stephen@networkplumber.org> > > Acked-by: Morten Brørup <mb@smartsharesystems.com> Applied, thanks. Having an exclude list looks closer to our final goal :) ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] build: exclude rather than include libs in MSVC build 2024-04-03 18:23 ` Tyler Retzlaff 2024-04-03 18:50 ` Morten Brørup @ 2024-04-11 5:01 ` Patrick Robb 1 sibling, 0 replies; 13+ messages in thread From: Patrick Robb @ 2024-04-11 5:01 UTC (permalink / raw) To: Tyler Retzlaff Cc: dev, Morten Brørup, Andrew Rybchenko, Bruce Richardson, Chengwen Feng, Honnappa Nagarahalli, Kevin Laatz, Srikanth Yalavarthi, Vladimir Medvedkin Recheck-request: iol-intel-Functional On Wed, Apr 3, 2024 at 2:23 PM Tyler Retzlaff <roretzla@linux.microsoft.com> wrote: > > Some libraries that could be built with MSVC were not being built. > > Switch from explicit include to exclude of libs to get immediate CI > coverage of libraries that already work with MSVC Windows builds. > > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com> > Acked-by: Stephen Hemminger <stephen@networkplumber.org> > --- > lib/argparse/meson.build | 6 ++++++ > lib/dmadev/meson.build | 6 ++++++ > lib/fib/meson.build | 6 ++++++ > lib/lpm/meson.build | 6 ++++++ > lib/mbuf/meson.build | 6 ++++++ > lib/mempool/meson.build | 6 ++++++ > lib/meson.build | 10 ---------- > lib/mldev/meson.build | 6 ++++++ > lib/rcu/meson.build | 6 ++++++ > lib/stack/meson.build | 6 ++++++ > 10 files changed, 54 insertions(+), 10 deletions(-) > > diff --git a/lib/argparse/meson.build b/lib/argparse/meson.build > index b6a08ca..8ab4c40 100644 > --- a/lib/argparse/meson.build > +++ b/lib/argparse/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2024 HiSilicon Limited. > > +if is_ms_compiler > + build = false > + reason = 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources = files('rte_argparse.c') > headers = files('rte_argparse.h') > > diff --git a/lib/dmadev/meson.build b/lib/dmadev/meson.build > index 62b0650..e66dcb6 100644 > --- a/lib/dmadev/meson.build > +++ b/lib/dmadev/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2021 HiSilicon Limited. > > +if is_ms_compiler > + build = false > + reason = 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources = files('rte_dmadev.c', 'rte_dmadev_trace_points.c') > headers = files('rte_dmadev.h') > indirect_headers += files('rte_dmadev_core.h', 'rte_dmadev_trace_fp.h') > diff --git a/lib/fib/meson.build b/lib/fib/meson.build > index ddcae06..6795f41 100644 > --- a/lib/fib/meson.build > +++ b/lib/fib/meson.build > @@ -2,6 +2,12 @@ > # Copyright(c) 2018 Vladimir Medvedkin <medvedkinv@gmail.com> > # Copyright(c) 2019 Intel Corporation > > +if is_ms_compiler > + build = false > + reason = 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources = files('rte_fib.c', 'rte_fib6.c', 'dir24_8.c', 'trie.c') > headers = files('rte_fib.h', 'rte_fib6.h') > deps += ['rib'] > diff --git a/lib/lpm/meson.build b/lib/lpm/meson.build > index 4cd4888..ae30f80 100644 > --- a/lib/lpm/meson.build > +++ b/lib/lpm/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > +if is_ms_compiler > + build = false > + reason = 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources = files('rte_lpm.c', 'rte_lpm6.c') > headers = files('rte_lpm.h', 'rte_lpm6.h') > # since header files have different names, we can install all vector headers > diff --git a/lib/mbuf/meson.build b/lib/mbuf/meson.build > index 0435c5e..2cee905 100644 > --- a/lib/mbuf/meson.build > +++ b/lib/mbuf/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > +if is_ms_compiler > + build = false > + reason = 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources = files( > 'rte_mbuf.c', > 'rte_mbuf_ptype.c', > diff --git a/lib/mempool/meson.build b/lib/mempool/meson.build > index 8099a56..acce66c 100644 > --- a/lib/mempool/meson.build > +++ b/lib/mempool/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > +if is_ms_compiler > + build = false > + reason = 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > extra_flags = [] > > foreach flag: extra_flags > diff --git a/lib/meson.build b/lib/meson.build > index 179a272..94d2b72 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -68,16 +68,6 @@ libraries = [ > 'node', > ] > > -if is_ms_compiler > - libraries = [ > - 'log', > - 'kvargs', > - 'telemetry', > - 'eal', > - 'ring', > - ] > -endif > - > always_enable = [ > 'cmdline', > 'eal', > diff --git a/lib/mldev/meson.build b/lib/mldev/meson.build > index 0079ccd..2c933ba 100644 > --- a/lib/mldev/meson.build > +++ b/lib/mldev/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright (c) 2022 Marvell. > > +if is_ms_compiler > + build = false > + reason = 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources = files( > 'rte_mldev_pmd.c', > 'rte_mldev.c', > diff --git a/lib/rcu/meson.build b/lib/rcu/meson.build > index 09abc52..71143f5 100644 > --- a/lib/rcu/meson.build > +++ b/lib/rcu/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2018 Arm Limited > > +if is_ms_compiler > + build = false > + reason = 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources = files('rte_rcu_qsbr.c') > headers = files('rte_rcu_qsbr.h') > > diff --git a/lib/stack/meson.build b/lib/stack/meson.build > index 18177a7..7631a14 100644 > --- a/lib/stack/meson.build > +++ b/lib/stack/meson.build > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2019 Intel Corporation > > +if is_ms_compiler > + build = false > + reason = 'not supported building with Visual Studio Toolset' > + subdir_done() > +endif > + > sources = files('rte_stack.c', 'rte_stack_std.c', 'rte_stack_lf.c') > headers = files('rte_stack.h') > # subheaders, not for direct inclusion by apps > -- > 1.8.3.1 > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] build: exclude rather than include libs in MSVC build 2024-04-03 18:23 ` [PATCH v2] " Tyler Retzlaff 2024-04-03 18:23 ` Tyler Retzlaff @ 2024-04-03 21:51 ` Stephen Hemminger 2024-04-05 14:29 ` Patrick Robb 2024-04-06 0:38 ` Patrick Robb 2 siblings, 1 reply; 13+ messages in thread From: Stephen Hemminger @ 2024-04-03 21:51 UTC (permalink / raw) To: Tyler Retzlaff Cc: dev, Morten Brørup, Andrew Rybchenko, Bruce Richardson, Chengwen Feng, Honnappa Nagarahalli, Kevin Laatz, Srikanth Yalavarthi, Vladimir Medvedkin On Wed, 3 Apr 2024 11:23:19 -0700 Tyler Retzlaff <roretzla@linux.microsoft.com> wrote: > Some libraries that could be built with MSVC were not being built. > > Switch from explicit include to exclude of libs to get immediate CI > coverage of libraries that already work with MSVC Windows builds. > > With this change we now get immediate CI build coverage for the libs > meter, timer, pci, cfgfile > > v2: > * add a few more explicit exclusions for now as they are known to require > more than trivial work and avoid needing to disable them later as the > dependent libraries are enabled. If you need to do another revision, it might be good idea to add comment to the meson.build file when doing exclusions as to what is missing. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] build: exclude rather than include libs in MSVC build 2024-04-03 21:51 ` Stephen Hemminger @ 2024-04-05 14:29 ` Patrick Robb 0 siblings, 0 replies; 13+ messages in thread From: Patrick Robb @ 2024-04-05 14:29 UTC (permalink / raw) To: Stephen Hemminger Cc: Tyler Retzlaff, dev, Morten Brørup, Andrew Rybchenko, Bruce Richardson, Chengwen Feng, Honnappa Nagarahalli, Kevin Laatz, Srikanth Yalavarthi, Vladimir Medvedkin Recheck-request: iol-intel-Functional checking for lab infra failure On Wed, Apr 3, 2024 at 5:51 PM Stephen Hemminger <stephen@networkplumber.org> wrote: > > On Wed, 3 Apr 2024 11:23:19 -0700 > Tyler Retzlaff <roretzla@linux.microsoft.com> wrote: > > > Some libraries that could be built with MSVC were not being built. > > > > Switch from explicit include to exclude of libs to get immediate CI > > coverage of libraries that already work with MSVC Windows builds. > > > > With this change we now get immediate CI build coverage for the libs > > meter, timer, pci, cfgfile > > > > v2: > > * add a few more explicit exclusions for now as they are known to require > > more than trivial work and avoid needing to disable them later as the > > dependent libraries are enabled. > > If you need to do another revision, it might be good idea to add comment > to the meson.build file when doing exclusions as to what is missing. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] build: exclude rather than include libs in MSVC build 2024-04-03 18:23 ` [PATCH v2] " Tyler Retzlaff 2024-04-03 18:23 ` Tyler Retzlaff 2024-04-03 21:51 ` Stephen Hemminger @ 2024-04-06 0:38 ` Patrick Robb 2 siblings, 0 replies; 13+ messages in thread From: Patrick Robb @ 2024-04-06 0:38 UTC (permalink / raw) To: Tyler Retzlaff Cc: dev, Morten Brørup, Andrew Rybchenko, Bruce Richardson, Chengwen Feng, Honnappa Nagarahalli, Kevin Laatz, Srikanth Yalavarthi, Vladimir Medvedkin Recheck-request: iol-intel-Functional Replied to the wrong version before On Wed, Apr 3, 2024 at 2:23 PM Tyler Retzlaff <roretzla@linux.microsoft.com> wrote: > > Some libraries that could be built with MSVC were not being built. > > Switch from explicit include to exclude of libs to get immediate CI > coverage of libraries that already work with MSVC Windows builds. > > With this change we now get immediate CI build coverage for the libs > meter, timer, pci, cfgfile > > v2: > * add a few more explicit exclusions for now as they are known to require > more than trivial work and avoid needing to disable them later as the > dependent libraries are enabled. > > Tyler Retzlaff (1): > build: exclude rather than include libs in MSVC build > > lib/argparse/meson.build | 6 ++++++ > lib/dmadev/meson.build | 6 ++++++ > lib/fib/meson.build | 6 ++++++ > lib/lpm/meson.build | 6 ++++++ > lib/mbuf/meson.build | 6 ++++++ > lib/mempool/meson.build | 6 ++++++ > lib/meson.build | 10 ---------- > lib/mldev/meson.build | 6 ++++++ > lib/rcu/meson.build | 6 ++++++ > lib/stack/meson.build | 6 ++++++ > 10 files changed, 54 insertions(+), 10 deletions(-) > > -- > 1.8.3.1 > ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2024-05-29 14:46 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-04-02 16:55 [PATCH] build: exclude rather than include libs in MSVC build Tyler Retzlaff 2024-04-02 16:55 ` Tyler Retzlaff 2024-04-02 17:15 ` Stephen Hemminger 2024-04-02 17:19 ` Tyler Retzlaff 2024-04-05 20:33 ` Patrick Robb 2024-04-03 18:23 ` [PATCH v2] " Tyler Retzlaff 2024-04-03 18:23 ` Tyler Retzlaff 2024-04-03 18:50 ` Morten Brørup 2024-05-29 14:46 ` Thomas Monjalon 2024-04-11 5:01 ` Patrick Robb 2024-04-03 21:51 ` Stephen Hemminger 2024-04-05 14:29 ` Patrick Robb 2024-04-06 0:38 ` Patrick Robb
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).