DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Konstantin Ananyev" <konstantin.ananyev@huawei.com>,
	"Stephen Hemminger" <stephen@networkplumber.org>
Cc: <dev@dpdk.org>
Subject: RE: [DPDK/ethdev Bug 1416] net/af_packet: tx_burst() can modify packets
Date: Tue, 16 Apr 2024 18:14:24 +0200	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F3A9@smartserver.smartshare.dk> (raw)
In-Reply-To: <2b4a3bac389141bbae7a2d0ec31df5c6@huawei.com>

> > > static uint16_t
> > > eth_af_packet_tx(void *queue, struct rte_mbuf **bufs, uint16_t
> nb_pkts)
> > > {
> > >         ...
> > >         for (i = 0; i < nb_pkts; i++) {
> > >                 mbuf = *bufs++;
> > >
> > >                 ...
> > >
> > >                 /* insert vlan info if necessary */
> > >                 if (mbuf->ol_flags & RTE_MBUF_F_TX_VLAN) {
> > >                         if (rte_vlan_insert(&mbuf)) {
> > >                                 rte_pktmbuf_free(mbuf);
> > >                                 continue;
> > >
> > > AFAIU, it does copy of mbuf contents into pbuf anyway (just few line
> below).
> > > So the fix might be - simply insert VLAN tag at copying stage.
> > > Feel free to correct me, if I missed something.
> >
> > vlan_insert will fail if the mbuf is has refcnt > 1.
> >
> > static inline int rte_vlan_insert(struct rte_mbuf **m)
> > {
> > 	struct rte_ether_hdr *oh, *nh;
> > 	struct rte_vlan_hdr *vh;
> >
> > 	/* Can't insert header if mbuf is shared */
> > 	if (!RTE_MBUF_DIRECT(*m) || rte_mbuf_refcnt_read(*m) > 1)
> > 		return -EINVAL;
> 
> You are right, I missed that.
> Will close it then.

Don't close, silent drop is also a bug.

The VLAN tag could be insert when copying, as originally suggested.

Alternatively, set tpacket2_hdr's tp_vlan_tci and tp_vlan_tpid fields and set TP_STATUS_VLAN_VALID and TP_STATUS_VLAN_TPID_VALID flags in tp_status. If the kernel reads those?


  reply	other threads:[~2024-04-16 16:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-16 10:29 bugzilla
2024-04-16 15:38 ` Stephen Hemminger
2024-04-16 15:56   ` Konstantin Ananyev
2024-04-16 16:14     ` Morten Brørup [this message]
2024-04-16 16:42       ` Konstantin Ananyev
2024-04-16 18:11         ` Morten Brørup
2024-04-16 20:09           ` Stephen Hemminger
2024-04-16 22:21             ` Morten Brørup
2024-04-16 15:58 ` bugzilla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F3A9@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@huawei.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).