From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1C97D43EF8;
	Wed, 24 Apr 2024 19:09:31 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8554D402D4;
	Wed, 24 Apr 2024 19:09:30 +0200 (CEST)
Received: from dkmailrelay1.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 802CD402D1
 for <dev@dpdk.org>; Wed, 24 Apr 2024 19:09:28 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesys.local [192.168.4.10])
 by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 39FBD20995;
 Wed, 24 Apr 2024 19:09:28 +0200 (CEST)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: getting rid of type argument to rte_malloc().
Date: Wed, 24 Apr 2024 19:09:24 +0200
X-MimeOLE: Produced By Microsoft Exchange V6.5
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F3E3@smartserver.smartshare.dk>
In-Reply-To: <20240424092351.31878a12@hermes.local>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: getting rid of type argument to rte_malloc().
Thread-Index: AdqWY9P45JU6nd1nQzWitnavbl2uxQABaJPw
References: <20240423210847.542cff76@hermes.local>
 <6e2e5f6e-7ff0-404e-991b-836d496ad164@amd.com>
 <20240424092351.31878a12@hermes.local>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>,
 "Ferruh Yigit" <ferruh.yigit@amd.com>
Cc: <dev@dpdk.org>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Wednesday, 24 April 2024 18.24
>=20
> On Wed, 24 Apr 2024 11:29:51 +0100
> Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>=20
> > On 4/24/2024 5:08 AM, Stephen Hemminger wrote:
> > > For the 24.11 release, I want to remove the unused type string
> argument
> > > that shows up in rte_malloc() and related functions, then =
percolates
> down
> > > through.  It was a idea in the 1.0 release of DPDK, never
> implemented and
> > > never removed.  Yes it will cause API breakage, a large sweeping
> change;
> > > probably easily scripted with coccinelle.
> > >
> > > Maybe doing ABI version now?
> > >
> >
> > Won't this impact many applications, is there big enough motivation =
to
> > force many DPDK applications to update their code, living with it
> looks
> > simpler.
> >
>=20
> Yeah, probably too big an impact but at least:
>   - change the documentation to say "do not use" should be NULL
>   - add script to remove all usage inside of DPDK
>   - get rid of places where useless arg is passed around inside
>     of the allocator internals.

For the sake of discussion:
Do we want to get rid of the "name" parameter to the memzone allocation =
functions too? It's somewhat weird that they differ.

Or are rte_memzone allocations considered init and control path, while =
rte_malloc allocations are considered fast path?