From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Shijith Thotton" <sthotton@marvell.com>, <dev@dpdk.org>
Cc: <olivier.matz@6wind.com>, <jerinj@marvell.com>, <stable@dpdk.org>
Subject: RE: [PATCH] mbuf: fix API to copy mbuf dynamic fields
Date: Wed, 26 Jun 2024 14:23:28 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F55A@smartserver.smartshare.dk> (raw)
In-Reply-To: <20240626120802.19333-1-sthotton@marvell.com>
> From: Shijith Thotton [mailto:sthotton@marvell.com]
> Sent: Wednesday, 26 June 2024 14.08
>
> Fixed rte_mbuf_dynfield_copy() API to copy dynamic fields from one mbuf
> to another. When RTE_IOVA_AS_PA is not defined during the build, an
> additional dynamic field (dynfield2) becomes available. This field
> should be conditionally copied to ensure the complete duplication of
> dynamic fields between mbufs. This patch fixes the same.
>
> see https://bugs.dpdk.org/show_bug.cgi?id=1472
>
> Bugzilla ID: 1472
> Fixes: 03b57eb7ab9a ("mbuf: add second dynamic field member")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
Thank you for fixing this bug.
> ---
> lib/mbuf/rte_mbuf.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h
> index 4c4722e002..dc6d1237ac 100644
> --- a/lib/mbuf/rte_mbuf.h
> +++ b/lib/mbuf/rte_mbuf.h
> @@ -1120,6 +1120,9 @@ static inline void
> rte_mbuf_dynfield_copy(struct rte_mbuf *mdst, const struct rte_mbuf *msrc)
> {
> memcpy(&mdst->dynfield1, msrc->dynfield1, sizeof(mdst->dynfield1));
> +#if !RTE_IOVA_IN_MBUF
> + mdst->dynfield2 = msrc->dynfield2;
> +#endif
dynfield2 is located before dynfield1 in the mbuf struct; suggest copy dynfield2 before dynfield1.
> }
>
> /* internal */
> --
> 2.25.1
With or without suggested change,
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
next prev parent reply other threads:[~2024-06-26 12:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 12:08 Shijith Thotton
2024-06-26 12:23 ` Morten Brørup [this message]
2024-06-26 15:00 ` Stephen Hemminger
2024-06-27 7:57 ` [PATCH v2] " Shijith Thotton
2024-07-03 16:05 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F55A@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).