From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDD3745644; Thu, 18 Jul 2024 13:57:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99ED242E94; Thu, 18 Jul 2024 13:57:24 +0200 (CEST) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id A90DA402D5 for ; Thu, 18 Jul 2024 13:57:22 +0200 (CEST) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 717F920C83; Thu, 18 Jul 2024 13:57:22 +0200 (CEST) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH v2 1/3] ethdev: add description for KEEP CRC offload Date: Thu, 18 Jul 2024 13:57:16 +0200 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F5AA@smartserver.smartshare.dk> X-MimeOLE: Produced By Microsoft Exchange V6.5 In-Reply-To: <20240718114806.577298-2-haijie1@huawei.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH v2 1/3] ethdev: add description for KEEP CRC offload Thread-Index: AdrZCGnlsE6j87cpQ8+QmE8I7JjzmgAAO6JQ References: <20240206011030.2007689-1-haijie1@huawei.com> <20240718114806.577298-1-haijie1@huawei.com> <20240718114806.577298-2-haijie1@huawei.com> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Jie Hai" , , , , , "Thomas Monjalon" , "Allain Legacy" Cc: , , X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Jie Hai [mailto:haijie1@huawei.com] > Sent: Thursday, 18 July 2024 13.48 >=20 > From: Dengdui Huang >=20 > The data execeed the pkt_len in mbuf is inavailable for user. > When KEEP CRC offload is enabled, CRC field length should be > included pkt_len in mbuf. However, almost of drivers supported > KEEP CRC feature didn't add the CRC data length to pkt_len. > So it is very necessary to add a coments for this. >=20 > Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dengdui Huang > --- > lib/ethdev/rte_ethdev.h | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index 548fada1c7..3d44673161 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -1550,6 +1550,12 @@ struct rte_eth_conf { > */ > #define RTE_ETH_RX_OFFLOAD_TIMESTAMP RTE_BIT64(14) > #define RTE_ETH_RX_OFFLOAD_SECURITY RTE_BIT64(15) > +/* Suggest making this a Doxygen comment: /** > + * Keep CRC data in packet. > + * > + * Note: If this offload is enabled, the pkt_len in mbuf should = contain "should contain" -> "must include" > + * the CRC data length. > + */ > #define RTE_ETH_RX_OFFLOAD_KEEP_CRC RTE_BIT64(16) > #define RTE_ETH_RX_OFFLOAD_SCTP_CKSUM RTE_BIT64(17) > #define RTE_ETH_RX_OFFLOAD_OUTER_UDP_CKSUM RTE_BIT64(18) > -- > 2.33.0 With above modifications, Acked-by: Morten Br=F8rup