From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Akhil Goyal" <gakhil@marvell.com>, <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <david.marchand@redhat.com>,
<hemant.agrawal@nxp.com>, <anoobj@marvell.com>,
<pablo.de.lara.guarch@intel.com>, <fiona.trahe@intel.com>,
<declan.doherty@intel.com>, <matan@nvidia.com>, <g.singh@nxp.com>,
<fanzhang.oss@gmail.com>, <jianjay.zhou@huawei.com>,
<asomalap@amd.com>, <ruifeng.wang@arm.com>,
<konstantin.v.ananyev@yandex.ru>, <radu.nicolau@intel.com>,
<ajit.khaparde@broadcom.com>, <rnagadheeraj@marvell.com>,
<mdr@ashroe.eu>
Subject: RE: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs
Date: Thu, 5 Sep 2024 17:09:00 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F6A8@smartserver.smartshare.dk> (raw)
In-Reply-To: <20240905101438.3888274-1-gakhil@marvell.com>
> +++ b/app/test/test_cryptodev_asym.c
> @@ -581,7 +581,7 @@ static inline void print_asym_capa(
> rte_cryptodev_asym_get_xform_string(capa->xform_type));
> printf("operation supported -");
>
> - for (i = 0; i < RTE_CRYPTO_ASYM_OP_LIST_END; i++) {
> + for (i = 0; i < rte_crypto_asym_op_list_end(); i++) {
> +++ b/lib/cryptodev/rte_crypto_asym.h
> +static inline int
> +rte_crypto_asym_xform_type_list_end(void)
> +{
> + return RTE_CRYPTO_ASYM_XFORM_SM2 + 1;
> +}
> +
> /**
> * Asymmetric crypto operation type variants
> + * Note: Update rte_crypto_asym_op_list_end for every new type added.
> */
> enum rte_crypto_asym_op_type {
> RTE_CRYPTO_ASYM_OP_ENCRYPT,
> @@ -135,9 +141,14 @@ enum rte_crypto_asym_op_type {
> /**< Signature Generation operation */
> RTE_CRYPTO_ASYM_OP_VERIFY,
> /**< Signature Verification operation */
> - RTE_CRYPTO_ASYM_OP_LIST_END
> };
>
> +static inline int
> +rte_crypto_asym_op_list_end(void)
> +{
> + return RTE_CRYPTO_ASYM_OP_VERIFY + 1;
> +}
I like the concept of replacing an "last enum value" with a "last enum function" for API/ABI compatibility purposes.
Here's an idea...
We can introduce a generic design pattern where we keep the _LIST_END enum value at the end, somehow marking it private (and not part of the API/ABI), and move the _list_end() function inside the C file, so it uses the _LIST_END enum value that the library was built with. E.g. like this:
In the header file:
enum rte_crypto_asym_op_type {
RTE_CRYPTO_ASYM_OP_VERIFY,
/**< Signature Verification operation */
#if RTE_BUILDING_INTERNAL
__RTE_CRYPTO_ASYM_OP_LIST_END /* internal */
#endif
}
int rte_crypto_asym_op_list_end(void);
And in the associated library code file, when including rte_crypto_asym.h:
#define RTE_BUILDING_INTERNAL
#include <cryptodev/rte_crypto_asym.h>
int
rte_crypto_asym_op_list_end(void)
{
return __RTE_CRYPTO_ASYM_OP_LIST_END;
}
next prev parent reply other threads:[~2024-09-05 15:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 10:14 Akhil Goyal
2024-09-05 15:09 ` Morten Brørup [this message]
2024-09-05 15:26 ` Kusztal, ArkadiuszX
2024-09-06 6:32 ` fengchengwen
2024-09-06 7:45 ` [EXTERNAL] " Akhil Goyal
2024-10-04 3:56 ` Ferruh Yigit
2024-09-06 7:54 ` Morten Brørup
2024-09-23 20:41 ` Akhil Goyal
2024-10-03 7:00 ` Akhil Goyal
2024-10-06 11:10 ` Morten Brørup
2024-10-09 11:21 ` Akhil Goyal
2024-10-04 4:00 ` Ferruh Yigit
2024-10-04 17:26 ` [EXTERNAL] " Akhil Goyal
2024-10-04 3:54 ` Ferruh Yigit
2024-10-04 7:04 ` David Marchand
2024-10-04 17:27 ` [EXTERNAL] " Akhil Goyal
2024-10-10 0:49 ` Ferruh Yigit
2024-10-10 6:18 ` [EXTERNAL] " Akhil Goyal
2024-10-28 11:15 ` Dodji Seketeli
2024-10-04 9:38 ` Dodji Seketeli
2024-10-04 17:45 ` [EXTERNAL] " Akhil Goyal
2024-10-28 10:55 ` Dodji Seketeli
2024-10-10 0:35 ` Ferruh Yigit
2024-10-28 10:12 ` Dodji Seketeli
2024-10-09 11:24 ` [PATCH] cryptodev: remove unnecessary list end Akhil Goyal
2024-10-09 12:52 ` Morten Brørup
2024-10-09 20:38 ` Akhil Goyal
2024-10-09 14:06 ` Hemant Agrawal
2024-10-10 0:51 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F6A8@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=ajit.khaparde@broadcom.com \
--cc=anoobj@marvell.com \
--cc=asomalap@amd.com \
--cc=david.marchand@redhat.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=fiona.trahe@intel.com \
--cc=g.singh@nxp.com \
--cc=gakhil@marvell.com \
--cc=hemant.agrawal@nxp.com \
--cc=jianjay.zhou@huawei.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=matan@nvidia.com \
--cc=mdr@ashroe.eu \
--cc=pablo.de.lara.guarch@intel.com \
--cc=radu.nicolau@intel.com \
--cc=rnagadheeraj@marvell.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).