RE: [PATCH v3] eal: add build-time option to omit trace

["Morten Brørup" <mb@smartsharesystems.com>]

> > +++ b/app/test/test_trace.c
> > @@ -12,7 +12,16 @@
> >
> >  int app_dpdk_test_tp_count;
> >
> > -#ifdef RTE_EXEC_ENV_WINDOWS
> > +#if !defined(RTE_TRACE)
> 
> Now that, we are is not disabling any symbols,
> This conditional compilation can be removed. Use
> __rte_trace_point_generic_is_enabled() in another leg.

Done in v4.
Also added to perf test.


> > +/**
> > + * @internal
> > + *
> > + * Test if the tracepoint compile-time option is enabled.
> > + *
> > + * @return
> > + *   true if tracepoint enabled, false otherwise.
> > + */
> > +__rte_experimental
> > +static __rte_always_inline bool
> > +__rte_trace_point_generic_is_enabled(void)
> 
> Add to version.map file

It's static inline, so not an exposed symbol.
__rte_trace_point_fp_is_enabled is also not in the version.map file.


> >  #define __rte_trace_point_emit_header_generic(t) \
> >  void *mem; \
> >  do { \
> > +       if (!__rte_trace_point_generic_is_enabled()) \
> > +               return; \
> 
> 
> To be super safe, Add similar check in
> RTE_INIT(trace##_init)

Done in v4.