From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Jerin Jacob" <jerinjacobk@gmail.com>
Cc: "Jerin Jacob" <jerinj@marvell.com>,
"Sunil Kumar Kori" <skori@marvell.com>, <dev@dpdk.org>
Subject: RE: [PATCH v4] eal: add build-time option to omit trace
Date: Tue, 1 Oct 2024 16:14:22 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F74C@smartserver.smartshare.dk> (raw)
In-Reply-To: <CALBAE1PXs0iRFxx5WWycDkUB8HQbgqSD+3yxram7O1jhs1H8gg@mail.gmail.com>
> From: Jerin Jacob [mailto:jerinjacobk@gmail.com]
> Sent: Tuesday, 1 October 2024 16.05
>
> On Tue, Oct 1, 2024 at 7:19 PM Morten Brørup <mb@smartsharesystems.com>
> wrote:
> >
> > Jerin,
> >
> > If you have no further comments, please add review/ack tag, to help
> Thomas see that the patch has been accepted by the maintainer, and can
> be merged.
>
> There was a comment to make the function as rte_trace_is_enabled() and
> remove internal. The rest looks good to me. I will Ack in the next
> version.
Perhaps my reply to that comment was unclear... such a public function already exists in the previous API:
https://elixir.bootlin.com/dpdk/v24.07/source/lib/eal/include/rte_trace.h#L36
That function tells if trace enabled at both build time and runtime, and returns false if not.
A separate public function to tell if trace is enabled at build time seems like overkill to me. Is that what you are asking for?
next prev parent reply other threads:[~2024-10-01 14:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 8:55 [PATCH] " Morten Brørup
2024-09-18 9:49 ` Jerin Jacob
2024-09-18 10:23 ` Morten Brørup
2024-09-19 8:06 ` [PATCH v2] " Morten Brørup
2024-09-19 8:51 ` Jerin Jacob
2024-09-19 13:15 ` Morten Brørup
2024-09-19 13:54 ` Jerin Jacob
2024-09-19 15:35 ` Morten Brørup
2024-09-19 15:49 ` Jerin Jacob
2024-09-19 16:08 ` Morten Brørup
2024-09-19 16:34 ` Jerin Jacob
2024-09-20 9:08 ` [PATCH v3] " Morten Brørup
2024-09-23 8:39 ` Jerin Jacob
2024-09-24 13:50 ` Morten Brørup
2024-09-24 13:39 ` [PATCH v4] " Morten Brørup
2024-09-24 15:30 ` Stephen Hemminger
2024-09-24 15:41 ` Jerin Jacob
2024-09-24 15:53 ` Morten Brørup
2024-09-24 15:57 ` Jerin Jacob
2024-10-01 13:49 ` Morten Brørup
2024-10-01 14:05 ` Jerin Jacob
2024-10-01 14:14 ` Morten Brørup [this message]
2024-10-01 15:01 ` Jerin Jacob
2024-10-01 16:01 ` Morten Brørup
2024-10-01 16:06 ` Jerin Jacob
2024-10-01 16:15 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F74C@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=skori@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).