DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Bhagyada Modali" <bhagyada.modali@amd.com>, <dev@dpdk.org>,
	": Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>
Cc: <ssebasti@amd.com>, <rningoji@amd.com>,
	"Chengwen Feng" <fengchengwen@huawei.com>
Subject: RE: [PATCH] dma\ae4dma: added AMD user space DMA driver
Date: Mon, 10 Mar 2025 10:35:08 +0100	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9FAD0@smartserver.smartshare.dk> (raw)
In-Reply-To: <20250309084526.972512-1-bhagyada.modali@amd.com>

> --- a/lib/mempool/rte_mempool.h
> +++ b/lib/mempool/rte_mempool.h
> @@ -136,7 +136,7 @@ struct rte_mempool_objsz {
>  /**
>   * Alignment of elements inside mempool.
>   */
> -#define RTE_MEMPOOL_ALIGN	RTE_CACHE_LINE_SIZE
> +#define RTE_MEMPOOL_ALIGN	4096

NAK!
This would nearly double the memory footprint of ordinary mbuf pools (with object size 2048).
And the memory footprint of mempools containing small objects would explode.

>  #endif
> 
>  #define RTE_MEMPOOL_ALIGN_MASK	(RTE_MEMPOOL_ALIGN - 1)



      parent reply	other threads:[~2025-03-10  9:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-09  8:45 Bhagyada Modali
2025-03-10  2:33 ` fengchengwen
2025-03-10  9:35 ` Morten Brørup [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9FAD0@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=bhagyada.modali@amd.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=rningoji@amd.com \
    --cc=ssebasti@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).