From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6D79D463BB;
	Tue, 11 Mar 2025 11:18:36 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 335A040279;
	Tue, 11 Mar 2025 11:18:36 +0100 (CET)
Received: from dkmailrelay1.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id C73D740268
 for <dev@dpdk.org>; Tue, 11 Mar 2025 11:18:34 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesys.local [192.168.4.10])
 by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id BDBC320B6F;
 Tue, 11 Mar 2025 11:18:33 +0100 (CET)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [RFC v3 0/8] Symbol versioning and export rework
X-MimeOLE: Produced By Microsoft Exchange V6.5
Date: Tue, 11 Mar 2025 11:18:33 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9FAE4@smartserver.smartshare.dk>
In-Reply-To: <20250311095609.194523-1-david.marchand@redhat.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [RFC v3 0/8] Symbol versioning and export rework
Thread-Index: AduSa9rgjdLoI2p5TCazkoAJBShYUQAAaoPA
References: <20250305212349.2036410-1-david.marchand@redhat.com>
 <20250311095609.194523-1-david.marchand@redhat.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "David Marchand" <david.marchand@redhat.com>,
	<dev@dpdk.org>
Cc: <thomas@monjalon.net>, <bruce.richardson@intel.com>,
 <andremue@linux.microsoft.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: David Marchand [mailto:david.marchand@redhat.com]
> Sent: Tuesday, 11 March 2025 10.56
>=20
> So far, each DPDK library (or driver) exposing symbols in an ABI had =
to
> maintain a version.map and use some macros for symbol versioning,
> specially crafted with the GNU linker in mind.
>=20
> This series proposes to rework the whole principle, and instead rely =
on
> marking the symbol exports in the source code itself, then let it to
> the
> build framework to produce a version script adapted to the linker in
> use
> (think GNU linker vs MSVC linker).
>=20
> This greatly simplifies versioning symbols: a developer does not need
> to
> know anything about version.map, or that a versioned symbol must be
> renamed with _v26, annotated with __vsym, exported in a header etc...
>=20
> Checking symbol maps becomes unnecessary since generated by the build
> framework.
>=20
> Updating to a new ABI is just a matter of bumping the value in
> ABI_VERSION.
>=20
>=20
> Comments please.

Excellent. I'm all for automating this!

Feature creep:

Have you thought about how this (or related automation) can possibly =
also benefit the CI, e.g. for ABI breakage testing?

Or possible benefits to (automated) documentation of versioned =
functions?
Or possible benefits to remembering all versioned ABIs when writing the =
release notes?