RE: [PATCH v2 6/6] trace: add PMU

["Morten Brørup" <mb@smartsharesystems.com>]

> From: Tomasz Duszynski [mailto:tduszynski@marvell.com]
> Sent: Wednesday, 18 June 2025 12.23
> 
> >> diff --git a/lib/meson.build b/lib/meson.build
> >> index 1934cb4a29..87b567f01b 100644
> >> --- a/lib/meson.build
> >> +++ b/lib/meson.build
> >> @@ -13,7 +13,7 @@ libraries = [
> >>          'kvargs', # eal depends on kvargs
> >>          'argparse',
> >>          'telemetry', # basic info querying
> >> -        'pmu',
> >> +        'pmu', # trace depends on pmu
> >>          'eal', # everything depends on eal
> >>          'ptr_compress',
> >>          'ring',
> >
> >@Tomasz,
> >
> >Please re-read my v1 review feedback [1]:
> >The PMU library should depend on the EAL, not the other way around!
> >How else is the PMU library supposed to use EAL functions like
> rte_mem_page_size()?
> 
> Hi Morten,
> 
> Not addressing your comments wasn't intentional - just missed your reply prior
> to sending
> v2.
> 
> Tracing is tightly tied to eal right now so adding anything "external" there
> brings in extra
> deps. That's why I can't move pmu further down in the lib hierarchy - dpdk
> won't build if I do.
> 
> Once tracing is moved out into its own library, that kind of change should be
> possible.

OK. Thomas seems to agree with this approach, so I will accept it too. :-)

> 
> >
> >@Jerin or @Bruce, do any of you have some suggestions for how to achieve the
> proper dependency chain here?
> >
> >Worst case, we will have to move PMU into EAL. :-(
> >
> >[1]:
> https://inbox.dpdk.org/dev/98CBD80474FA8B44BF855DF32C47DC35E9FCFA@smartserver.
> smartshare.dk/T/#u
> >
> >Besides that, good stuff. :-)