From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Mario Kuka" <kuka@cesnet.cz>, <dev@dpdk.org>
Subject: RE: [PATCH v2] mbuf: add new ptype for slow protocols
Date: Mon, 7 Jul 2025 14:47:17 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9FD94@smartserver.smartshare.dk> (raw)
In-Reply-To: <20250707075100.15034-1-kuka@cesnet.cz>
> From: Mario Kuka [mailto:kuka@cesnet.cz]
> Sent: Monday, 7 July 2025 09.51
>
> Introduce a new ptype for identifying slow protocol packets.
>
> Signed-off-by: Mario Kuka <kuka@cesnet.cz>
> * <'ether type'=[0x8847|0x8848]>
> */
> #define RTE_PTYPE_L2_ETHER_MPLS 0x0000000a
> +/**
> + * Ethernet packet type for Slow Protocols.
> + *
> + * Packet format:
> + * <'destination mac'=01-80-C2-00-00-02, 'ether type'=0x8809>
> + */
> +#define RTE_PTYPE_L2_ETHER_SLOW 0x0000000b
I'm not sure that we want to register individual packet types for Layer 2 control protocol type packets, where the packet rate is very low.
Consider the endless list of vendor proprietary Layer 2 control protocols, such as Cicso Link Layer Protocols, Realtek Layer 2 Protocols, MikroTik RoMON, etc. The list would explode if we started adding these.
IMO, only data carrying packet types (IPv4, IPv6, PPPoE, etc.) should be registered as individual packet types. The rest should be sorted manually by the application.
next prev parent reply other threads:[~2025-07-07 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 8:45 [PATCH] " Mario Kuka
2025-07-04 9:38 ` Morten Brørup
2025-07-07 7:51 ` [PATCH v2] " Mario Kuka
2025-07-07 12:47 ` Morten Brørup [this message]
2025-07-07 14:48 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9FD94@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=dev@dpdk.org \
--cc=kuka@cesnet.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).