From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C3CD346D32;
	Fri, 15 Aug 2025 08:41:03 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E29934026C;
	Fri, 15 Aug 2025 08:41:02 +0200 (CEST)
Received: from dkmailrelay1.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 2D199400EF
 for <dev@dpdk.org>; Fri, 15 Aug 2025 08:41:02 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesys.local [192.168.4.10])
 by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id E52C72051E;
 Fri, 15 Aug 2025 08:41:00 +0200 (CEST)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v2 0/6] Enable warnings about use of comma operator
X-MimeOLE: Produced By Microsoft Exchange V6.5
Date: Fri, 15 Aug 2025 08:40:58 +0200
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9FE37@smartserver.smartshare.dk>
In-Reply-To: <20250814212901.88863-1-stephen@networkplumber.org>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v2 0/6] Enable warnings about use of comma operator
Thread-Index: AdwNYnxTcyRmW5h/QKusJoztcxg1+AAS/26g
References: <20250312232739.228295-1-stephen@networkplumber.org>
 <20250814212901.88863-1-stephen@networkplumber.org>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>
Cc: <dev@dpdk.org>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Thursday, 14 August 2025 23.29
>=20
> This series was motivated by recent thread on netdev
> about build with -Wcomma in clang. This warning catches code
> that uses comma where a semi-colon is a better choice.

Overall, I agree that using semicolon is better for consistency is most =
places, but using commas in some loops - e.g. "for (dst=3D,src=3D; =
condition; dst+=3D, src+=3D)" - might be more readable than the =
alternative.

Stephen, I'm interested in the discussion about this, can you please =
post a link to the thread on the netdev mailing list?