DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Bruce Richardson" <bruce.richardson@intel.com>, <dev@dpdk.org>
Cc: <david.marchand@redhat.com>
Subject: RE: [PATCH v8 00/18] Simplify running with high-numbered CPUs
Date: Mon, 6 Oct 2025 09:42:20 +0200	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35F65499@smartserver.smartshare.dk> (raw)
In-Reply-To: <20251002174315.962992-1-bruce.richardson@intel.com>

Bruce,

cpu_set_t is a fixed size array, with the size CPU_SETSIZE.
This is part of libc.

However, the kernel may be built with support for a different number of CPUs.
This means that e.g. sched_getaffinity() will fail with EINVAL if cpusetsize is smaller than the number of CPUs the kernel was built for.
For more information, refer to the description about "Dynamically sized CPU sets" here:
https://linux.die.net/man/3/cpu_alloc_size

With this series, consider ensuring that all DPDK functions taking a cpu set parameter also take a cpu set size parameter, to align with kernel APIs.
E.g.:
int sched_getaffinity(pid_t pid,
	size_t cpusetsize, cpu_set_t *mask), and
void CPU_ZERO_S(size_t setsize, cpu_set_t *set),
instead of:
void CPU_ZERO(cpu_set_t *set).

<feature creep>
Consider not using fixed size cpu sets (and CPU_SETSIZE) at all, but dynamically allocated cpu sets.
</feature creep>

<joke>
Consider not using fixed size lcore arrays (and RTE_MAX_LCORE) at all, but dynamically allocated lcore arrays.
</joke>


Venlig hilsen / Kind regards,
-Morten Brørup


  parent reply	other threads:[~2025-10-06  7:42 UTC|newest]

Thread overview: 184+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-20 16:40 [RFC PATCH 0/7] rework EAL argument parsing in DPDK Bruce Richardson
2025-05-20 16:40 ` [RFC PATCH 1/7] eal: add long options for each short option Bruce Richardson
2025-05-20 16:40 ` [RFC PATCH 2/7] argparse: add support for string and boolean args Bruce Richardson
2025-05-20 16:40 ` [RFC PATCH 3/7] argparse: make argparse EAL-args compatible Bruce Richardson
2025-05-22 10:44   ` Bruce Richardson
2025-05-20 16:40 ` [RFC PATCH 4/7] eal: define the EAL parameters in argparse format Bruce Richardson
2025-05-20 16:40 ` [RFC PATCH 5/7] eal: gather EAL args before processing Bruce Richardson
2025-05-20 16:40 ` [RFC PATCH 6/7] eal: combine parameter validation checks Bruce Richardson
2025-05-20 16:40 ` [RFC PATCH 7/7] eal: simplify handling of conflicting cmdline options Bruce Richardson
2025-07-08 17:20 ` [RFC PATCH v2 0/5] rework EAL argument parsing in DPDK Bruce Richardson
2025-07-08 17:20   ` [RFC PATCH v2 1/5] eal: add long options for each short option Bruce Richardson
2025-07-08 17:20   ` [RFC PATCH v2 2/5] eal: define the EAL parameters in argparse format Bruce Richardson
2025-07-08 17:20   ` [RFC PATCH v2 3/5] eal: gather EAL args before processing Bruce Richardson
2025-07-08 17:20   ` [RFC PATCH v2 4/5] eal: combine parameter validation checks Bruce Richardson
2025-07-08 17:20   ` [RFC PATCH v2 5/5] eal: simplify handling of conflicting cmdline options Bruce Richardson
2025-07-08 18:41   ` [RFC PATCH v2 0/5] rework EAL argument parsing in DPDK Stephen Hemminger
2025-07-09  7:50     ` Bruce Richardson
2025-07-09 12:30   ` David Marchand
2025-07-09 12:54     ` Bruce Richardson
2025-07-17 10:41   ` David Marchand
2025-07-17 10:54     ` Bruce Richardson
2025-07-18 14:33 ` [PATCH v3 0/9] rework EAL argument parsing Bruce Richardson
2025-07-18 14:33   ` [PATCH v3 1/9] build: add define for the OS environment name Bruce Richardson
2025-07-18 14:33   ` [PATCH v3 2/9] argparse: export function to print help text for object Bruce Richardson
2025-07-18 14:33   ` [PATCH v3 3/9] argparse: allow user-override of help printing Bruce Richardson
2025-07-21  8:43     ` David Marchand
2025-07-21  9:00       ` Bruce Richardson
2025-07-18 14:33   ` [PATCH v3 4/9] eal: add long options for each short option Bruce Richardson
2025-07-18 14:33   ` [PATCH v3 5/9] eal: define the EAL parameters in argparse format Bruce Richardson
2025-07-21  8:41     ` David Marchand
2025-07-21  9:05       ` Bruce Richardson
2025-07-21 12:53         ` Bruce Richardson
2025-07-18 14:33   ` [PATCH v3 6/9] eal: gather EAL args before processing Bruce Richardson
2025-07-18 14:33   ` [PATCH v3 7/9] eal: ensure proper cleanup on EAL init failure Bruce Richardson
2025-07-18 14:33   ` [PATCH v3 8/9] eal: combine parameter validation checks Bruce Richardson
2025-07-18 14:33   ` [PATCH v3 9/9] eal: simplify handling of conflicting cmdline options Bruce Richardson
2025-07-18 14:41   ` [PATCH v3 0/9] rework EAL argument parsing Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 " Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 1/9] build: add define for the OS environment name Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 2/9] argparse: export function to print help text for object Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 3/9] argparse: allow user-override of help printing Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 4/9] eal: add long options for each short option Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 5/9] eal: define the EAL parameters in argparse format Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 6/9] eal: gather EAL args before processing Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 7/9] eal: ensure proper cleanup on EAL init failure Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 8/9] eal: combine parameter validation checks Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 9/9] eal: simplify handling of conflicting cmdline options Bruce Richardson
2025-07-21 15:16 ` [PATCH v5 0/9] rework EAL argument parsing Bruce Richardson
2025-07-21 15:16   ` [PATCH v5 1/9] build: add define for the OS environment name Bruce Richardson
2025-07-21 15:16   ` [PATCH v5 2/9] argparse: export function to print help text for object Bruce Richardson
2025-07-21 15:16   ` [PATCH v5 3/9] argparse: allow user-override of help printing Bruce Richardson
2025-07-21 15:16   ` [PATCH v5 4/9] eal: add long options for each short option Bruce Richardson
2025-07-21 15:16   ` [PATCH v5 5/9] eal: define the EAL parameters in argparse format Bruce Richardson
2025-07-21 15:16   ` [PATCH v5 6/9] eal: gather EAL args before processing Bruce Richardson
2025-07-21 15:16   ` [PATCH v5 7/9] eal: ensure proper cleanup on EAL init failure Bruce Richardson
2025-07-21 15:16   ` [PATCH v5 8/9] eal: combine parameter validation checks Bruce Richardson
2025-07-21 15:16   ` [PATCH v5 9/9] eal: simplify handling of conflicting cmdline options Bruce Richardson
2025-07-22 14:03 ` [PATCH v6 0/9] rework EAL argument parsing Bruce Richardson
2025-07-22 14:03   ` [PATCH v6 1/9] build: add define for the OS environment name Bruce Richardson
2025-07-22 14:03   ` [PATCH v6 2/9] argparse: export function to print help text for object Bruce Richardson
2025-07-22 14:03   ` [PATCH v6 3/9] argparse: allow user-override of help printing Bruce Richardson
2025-07-22 14:03   ` [PATCH v6 4/9] eal: add long options for each short option Bruce Richardson
2025-07-22 14:03   ` [PATCH v6 5/9] eal: define the EAL parameters in argparse format Bruce Richardson
2025-07-22 14:03   ` [PATCH v6 6/9] eal: gather EAL args before processing Bruce Richardson
2025-07-22 14:03   ` [PATCH v6 7/9] eal: ensure proper cleanup on EAL init failure Bruce Richardson
2025-07-22 14:03   ` [PATCH v6 8/9] eal: combine parameter validation checks Bruce Richardson
2025-07-22 14:03   ` [PATCH v6 9/9] eal: simplify handling of conflicting cmdline options Bruce Richardson
2025-09-30 13:06   ` [PATCH v6 0/9] rework EAL argument parsing David Marchand
2025-09-30 13:31     ` Bruce Richardson
2025-07-23 16:19 ` [PATCH v7 00/13] Simplify running with high-numbered CPUs Bruce Richardson
2025-07-23 16:19   ` [PATCH v7 01/13] build: add define for the OS environment name Bruce Richardson
2025-07-23 16:20   ` [PATCH v7 02/13] argparse: export function to print help text for object Bruce Richardson
2025-09-30 12:20     ` David Marchand
2025-07-23 16:20   ` [PATCH v7 03/13] argparse: allow user-override of help printing Bruce Richardson
2025-07-23 16:20   ` [PATCH v7 04/13] argparse: add documentation on supported value types Bruce Richardson
2025-07-23 16:20   ` [PATCH v7 05/13] eal: add long options for each short option Bruce Richardson
2025-09-30 12:21     ` David Marchand
2025-07-23 16:20   ` [PATCH v7 06/13] eal: define the EAL parameters in argparse format Bruce Richardson
2025-09-30 12:21     ` David Marchand
2025-09-30 15:12       ` Bruce Richardson
2025-10-01  8:46         ` David Marchand
2025-10-01 10:15           ` Bruce Richardson
2025-09-30 12:45     ` David Marchand
2025-09-30 12:58       ` Bruce Richardson
2025-09-30 13:16         ` David Marchand
2025-07-23 16:20   ` [PATCH v7 07/13] eal: gather EAL args before processing Bruce Richardson
2025-07-23 16:20   ` [PATCH v7 08/13] eal: ensure proper cleanup on EAL init failure Bruce Richardson
2025-07-23 16:20   ` [PATCH v7 09/13] eal: combine parameter validation checks Bruce Richardson
2025-07-23 16:20   ` [PATCH v7 10/13] eal: simplify handling of conflicting cmdline options Bruce Richardson
2025-07-23 16:20   ` [PATCH v7 11/13] argparse: add support for parsing core lists Bruce Richardson
2025-07-23 16:20   ` [PATCH v7 12/13] eal: simplify running CPUs with ids above max lcores Bruce Richardson
2025-07-23 16:20   ` [PATCH v7 13/13] eal: add warnings about ignored options Bruce Richardson
2025-08-29 14:39   ` [PATCH v7 00/13] Simplify running with high-numbered CPUs Bruce Richardson
2025-10-02 17:42 ` [PATCH v8 00/18] " Bruce Richardson
2025-10-02 17:42   ` [PATCH v8 01/18] build: add define for the OS environment name Bruce Richardson
2025-10-02 17:42   ` [PATCH v8 02/18] argparse: export function to print help text for object Bruce Richardson
2025-10-02 17:43   ` [PATCH v8 03/18] argparse: allow user-override of help printing Bruce Richardson
2025-10-02 17:43   ` [PATCH v8 04/18] argparse: add documentation on supported value types Bruce Richardson
2025-10-02 17:43   ` [PATCH v8 05/18] argparse: add support for parsing core lists Bruce Richardson
2025-10-02 17:43   ` [PATCH v8 06/18] eal: add long options for each short option Bruce Richardson
2025-10-02 17:43   ` [PATCH v8 07/18] eal: define the EAL parameters in argparse format Bruce Richardson
2025-10-02 17:43   ` [PATCH v8 08/18] eal: gather EAL args before processing Bruce Richardson
2025-10-02 17:43   ` [PATCH v8 09/18] eal: ensure proper cleanup on EAL init failure Bruce Richardson
2025-10-02 17:43   ` [PATCH v8 10/18] eal: combine parameter validation checks Bruce Richardson
2025-10-02 17:43   ` [PATCH v8 11/18] eal: simplify handling of conflicting cmdline options Bruce Richardson
2025-10-02 17:43   ` [PATCH v8 12/18] eal: automatically init arg list options Bruce Richardson
2025-10-02 17:43   ` [PATCH v8 13/18] eal: add internal fn for converting cpuset to string Bruce Richardson
2025-10-02 17:43   ` [PATCH v8 14/18] eal: use common cpuset to string function Bruce Richardson
2025-10-02 17:43   ` [PATCH v8 15/18] eal: introduce lcore remapping option for coremasks Bruce Richardson
2025-10-02 17:43   ` [PATCH v8 16/18] eal: rework internal coremask parsing to use cpu sets Bruce Richardson
2025-10-02 17:43   ` [PATCH v8 17/18] eal: allow lcore id remapping with core lists Bruce Richardson
2025-10-02 17:43   ` [PATCH v8 18/18] eal: allow lcore remapping with autodetected core affinity Bruce Richardson
2025-10-03  8:13   ` [PATCH v8 00/18] Simplify running with high-numbered CPUs Bruce Richardson
2025-10-06  7:42   ` Morten Brørup [this message]
2025-10-06  8:41     ` Bruce Richardson
2025-10-07 15:30       ` Bruce Richardson
2025-10-03  8:14 ` [PATCH v9 " Bruce Richardson
2025-10-03  8:14   ` [PATCH v9 01/18] build: add define for the OS environment name Bruce Richardson
2025-10-03  8:14   ` [PATCH v9 02/18] argparse: export function to print help text for object Bruce Richardson
2025-10-03  8:14   ` [PATCH v9 03/18] argparse: allow user-override of help printing Bruce Richardson
2025-10-03  8:14   ` [PATCH v9 04/18] argparse: add documentation on supported value types Bruce Richardson
2025-10-03  8:14   ` [PATCH v9 05/18] argparse: add support for parsing core lists Bruce Richardson
2025-10-03  8:14   ` [PATCH v9 06/18] eal: add long options for each short option Bruce Richardson
2025-10-03  8:14   ` [PATCH v9 07/18] eal: define the EAL parameters in argparse format Bruce Richardson
2025-10-03  8:15   ` [PATCH v9 08/18] eal: gather EAL args before processing Bruce Richardson
2025-10-03  8:15   ` [PATCH v9 09/18] eal: ensure proper cleanup on EAL init failure Bruce Richardson
2025-10-03  8:15   ` [PATCH v9 10/18] eal: combine parameter validation checks Bruce Richardson
2025-10-03  8:15   ` [PATCH v9 11/18] eal: simplify handling of conflicting cmdline options Bruce Richardson
2025-10-03  8:15   ` [PATCH v9 12/18] eal: automatically init arg list options Bruce Richardson
2025-10-03  8:15   ` [PATCH v9 13/18] eal: add internal fn for converting cpuset to string Bruce Richardson
2025-10-03  8:15   ` [PATCH v9 14/18] eal: use common cpuset to string function Bruce Richardson
2025-10-03  8:15   ` [PATCH v9 15/18] eal: introduce lcore remapping option for coremasks Bruce Richardson
2025-10-03  8:15   ` [PATCH v9 16/18] eal: rework internal coremask parsing to use cpu sets Bruce Richardson
2025-10-03  8:15   ` [PATCH v9 17/18] eal: allow lcore id remapping with core lists Bruce Richardson
2025-10-03  8:15   ` [PATCH v9 18/18] eal: allow lcore remapping with autodetected core affinity Bruce Richardson
2025-10-06 14:10   ` [PATCH v9 00/18] Simplify running with high-numbered CPUs David Marchand
2025-10-06 14:42     ` Bruce Richardson
2025-10-07 16:15     ` Bruce Richardson
2025-10-08  7:53       ` Thomas Monjalon
2025-10-08  8:11         ` Bruce Richardson
2025-10-08 20:42 ` [PATCH v10 00/21] " Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 01/21] build: add define for the OS environment name Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 02/21] test/func_reentrancy: fix args to EAL init call Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 03/21] argparse: export function to print help text for object Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 04/21] argparse: allow user-override of help printing Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 05/21] argparse: add documentation on supported value types Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 06/21] argparse: add support for parsing core lists Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 07/21] argparse: allow optional flag reordering Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 08/21] argparse: support parameters to short options without "=" Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 09/21] eal: add long options for each short option Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 10/21] eal: define the EAL parameters in argparse format Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 11/21] eal: gather EAL args before processing Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 12/21] eal: ensure proper cleanup on EAL init failure Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 13/21] eal: combine parameter validation checks Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 14/21] eal: simplify handling of conflicting cmdline options Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 15/21] eal: automatically init arg list options Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 16/21] eal: add internal fn for converting cpuset to string Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 17/21] eal: use common cpuset to string function Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 18/21] eal: introduce lcore remapping option for coremasks Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 19/21] eal: rework internal coremask parsing to use cpu sets Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 20/21] eal: allow lcore ID remapping with core lists Bruce Richardson
2025-10-08 20:42   ` [PATCH v10 21/21] eal: allow lcore remapping with autodetected core affinity Bruce Richardson
2025-10-09 13:00 ` [PATCH v11 00/21] Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 01/21] build: add define for the OS environment name Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 02/21] test/func_reentrancy: fix args to EAL init call Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 03/21] argparse: export function to print help text for object Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 04/21] argparse: allow user-override of help printing Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 05/21] argparse: add documentation on supported value types Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 06/21] argparse: add support for parsing core lists Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 07/21] argparse: allow optional flag reordering Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 08/21] argparse: support parameters to short options without "=" Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 09/21] eal: add long options for each short option Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 10/21] eal: define the EAL parameters in argparse format Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 11/21] eal: gather EAL args before processing Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 12/21] eal: ensure proper cleanup on EAL init failure Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 13/21] eal: combine parameter validation checks Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 14/21] eal: simplify handling of conflicting cmdline options Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 15/21] eal: automatically init arg list options Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 16/21] eal: add internal fn for converting cpuset to string Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 17/21] eal: use common cpuset to string function Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 18/21] eal: introduce lcore remapping option for coremasks Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 19/21] eal: rework internal coremask parsing to use cpu sets Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 20/21] eal: allow lcore ID remapping with core lists Bruce Richardson
2025-10-09 13:00   ` [PATCH v11 21/21] eal: allow lcore remapping with autodetected core affinity Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35F65499@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).