From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: xiangxia.m.yue@gmail.com, jianfeng.tan@intel.com, yliu@fridaylinux.org
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/3] vhost: fix crash and fd leak due to vhostuser destroyed
Date: Fri, 4 May 2018 17:11:42 +0200 [thread overview]
Message-ID: <98a7f78c-d804-cbcb-7f4e-61b3f0c95297@redhat.com> (raw)
In-Reply-To: <1524842385-61707-2-git-send-email-xiangxia.m.yue@gmail.com>
On 04/27/2018 05:19 PM, xiangxia.m.yue@gmail.com wrote:
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> when rte_vhost_driver_unregister detstroy the vsocket, we
> should set it to NULL after freeing it, because in client mode,
> the conn may be added to reconnect thread while vsocket is
> destroyed. In one case, if qemu create vhostuser port as a
> server with the same unix path, the reconnect thread will
> reconnect to it while vsocket is destroyed.
>
> To fix this:
> 1. set vsocket to NULL after free it.
> 2. remove the reconnection from reconnection thread in suitable
> position.
>
> Cc: stable@dpdk.org
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> ---
> lib/librte_vhost/socket.c | 41 ++++++++++++++++++++++++++++-------------
> 1 file changed, 28 insertions(+), 13 deletions(-)
>
Applied to dpdk-next-virtio/master.
Thanks,
Maxime
next prev parent reply other threads:[~2018-05-04 15:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 15:19 [dpdk-dev] [PATCH 1/3] vhost: fix deadlock due to vhostuser socket and fdset xiangxia.m.yue
2018-04-27 15:19 ` [dpdk-dev] [PATCH 2/3] vhost: fix crash and fd leak due to vhostuser destroyed xiangxia.m.yue
2018-05-04 13:02 ` Maxime Coquelin
2018-05-04 15:11 ` Maxime Coquelin [this message]
2018-04-27 15:19 ` [dpdk-dev] [PATCH 3/3] vhost: fix typo in fdset_event_dispatch comment xiangxia.m.yue
2018-05-04 13:03 ` Maxime Coquelin
2018-05-04 15:11 ` Maxime Coquelin
2018-05-04 13:00 ` [dpdk-dev] [PATCH 1/3] vhost: fix deadlock due to vhostuser socket and fdset Maxime Coquelin
2018-05-04 15:11 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98a7f78c-d804-cbcb-7f4e-61b3f0c95297@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=stable@dpdk.org \
--cc=xiangxia.m.yue@gmail.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).