From: 王志克 <wangzhike@jd.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
Zhike Wang <wangzk320@163.com>, "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"security@dpdk.org" <security@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] vhost: fix vring message handling broken in some case
Date: Thu, 14 Nov 2019 10:16:21 +0000 [thread overview]
Message-ID: <98c33d29d2954f268fd7dd6ed03e6b3f@jd.com> (raw)
In-Reply-To: <36d4ff71-bce4-6b69-7110-c4f6b9bfa51d@redhat.com>
Thanks Maxime.
Go ahead, your proposal sounds good.
Br,
Zhike Wang
JDCloud, Product Development, IaaS
------------------------------------------------------------------------------------------------
Mobile/+86 13466719566
E- mail/wangzhike@jd.com
Address/5F Building A,North-Star Century Center,8 Beichen West Street,Chaoyang District Beijing
Https://JDCloud.com
------------------------------------------------------------------------------------------------
-----Original Message-----
From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
Sent: Thursday, November 14, 2019 4:53 PM
To: Zhike Wang; dev@dpdk.org; stable@dpdk.org; security@dpdk.org
Cc: 王志克
Subject: Re: [dpdk-dev] [PATCH v2] vhost: fix vring message handling broken in some case
Maybe change the title to something like:
vhost: fix vring requests validation broken if no FD in payload
On 11/13/19 12:03 PM, Zhike Wang wrote:
> When VHOST_USER_VRING_NOFD_MASK is set, the fd_num is 0,
> so validate_msg_fds() will return error. In this case,
> the negotiation of vring message between vhost user front end and
> back end would fail, and as a result, vhost user link could NOT be up.
>
> How to reproduce:
> 1.Run dpdk testpmd insides VM, which locates at host with ovs+dpdk.
> 2.Notice that inside ovs there are endless logs regarding failure to
> handle VHOST_USER_SET_VRING_CALL, and link of vm could NOT be up.
>
> Fixes: bf47225 ("vhost: fix possible denial of service by leaking FDs")
> Signed-off-by: Zhike Wang <wangzk320@163.com>
> ---
> lib/librte_vhost/vhost_user.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
otherwise:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
The title can be changed while applying if you agree with it, no need to
send v3.
I'll take care of the different backports.
Thanks,
Maxime
next prev parent reply other threads:[~2019-11-14 10:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 11:03 Zhike Wang
2019-11-14 8:52 ` Maxime Coquelin
2019-11-14 10:16 ` 王志克 [this message]
2019-11-14 10:23 ` Maxime Coquelin
2019-11-14 10:58 ` 王志克
2019-11-15 4:15 ` [dpdk-dev] [dpdk-stable] " Tiwei Bie
2019-11-15 13:31 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98c33d29d2954f268fd7dd6ed03e6b3f@jd.com \
--to=wangzhike@jd.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=security@dpdk.org \
--cc=stable@dpdk.org \
--cc=wangzk320@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).