From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix to add offloads confguration for queue
Date: Fri, 5 Jul 2019 00:54:04 +0100 [thread overview]
Message-ID: <98ca71e4-d961-a021-ef2b-427b846101a2@intel.com> (raw)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260DC5A36@IRSMSX108.ger.corp.intel.com>
On 7/4/2019 9:53 AM, Iremonger, Bernard wrote:
>> -----Original Message-----
>> From: Zhao1, Wei
>> Sent: Thursday, July 4, 2019 6:36 AM
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; Iremonger, Bernard <bernard.iremonger@intel.com>;
>> Zhao1, Wei <wei.zhao1@intel.com>
>> Subject: [PATCH v2] app/testpmd: fix to add offloads confguration for queue
>>
>> When adding offloads from commandline, not only port related configuration
>> bits should be set, but also queue related offloads configuration bits, or it will
>> cause error.
>> For example, test in this process for ixgbe:
>> (1)./x86_64-native-linuxapp-gcc/app/testpmd -c 0x6 -n 4
>> -- -i --portmask=0x1 --port-topology=loop --disable-crc-strip (2)port stop all
>> (3)port config all crc-strip on (4)port start all we will see "Fail to configure port
>> 0 rx queues" of warning info.
>>
>> Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: wei zhao <wei.zhao1@intel.com>
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
>
Applied to dpdk-next-net/master, thanks.
next prev parent reply other threads:[~2019-07-04 23:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 5:24 [dpdk-dev] [PATCH] " Wei Zhao
2019-07-03 11:46 ` Iremonger, Bernard
2019-07-04 5:35 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2019-07-04 8:53 ` Iremonger, Bernard
2019-07-04 23:54 ` Ferruh Yigit [this message]
2019-07-06 16:24 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-07-06 16:25 ` Thomas Monjalon
2019-07-08 9:09 ` David Marchand
2019-07-08 9:16 ` Zhao1, Wei
2019-07-08 9:22 ` Zhao1, Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98ca71e4-d961-a021-ef2b-427b846101a2@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).