From: "Doherty, Declan" <declan.doherty@intel.com>
To: Matan Azrad <matan@mellanox.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] net/bonding: add rte flow support
Date: Tue, 24 Apr 2018 13:54:44 +0100 [thread overview]
Message-ID: <98ea4835-98a7-e3d0-c266-4fc4df5f0fff@intel.com> (raw)
In-Reply-To: <1522235761-21928-1-git-send-email-matan@mellanox.com>
Firstly, apologies on the very large delay on reviewing this. This looks
good to me and I've verified that flow configuration propagates as
expected to bonded slaves using IXGBE PMDs for testing.
I had to do some minor rebasing to get the patch to apply cleanly to
next-net, so I'll leave it up to Ferruh on whether he wants a rebased
revision of the patch or if he is happy to apply as is and handle the
rebasing himself.
I will do a v6 of the tunnel encap/decap patchset rebased to this
patchset to handle the changes to the rte_flow_query API as I need to
send a new revision of that to fix some whitespace issue I added in the
last revision of it.
Regards
Declan
On 28/03/2018 12:16 PM, Matan Azrad wrote:
> Ethernet devices which are grouped by bonding PMD, aka slaves, are
> sharing the same queues and RSS configurations and their Rx burst
> functions must be managed by the bonding PMD according to the bonding
> architectuer.
^^
typo
>
> So, it makes sense to configure the same flow rules for all the bond
> slaves to allow consistency in packet flow management.
>
> Add rte flow support to the bonding PMD to manage all flow
> configuration to the bonded slaves.
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> ---
....
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
next prev parent reply other threads:[~2018-04-24 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 11:16 Matan Azrad
2018-04-12 17:27 ` Ferruh Yigit
2018-04-22 21:22 ` Thomas Monjalon
2018-04-24 12:54 ` Doherty, Declan [this message]
2018-04-24 15:04 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98ea4835-98a7-e3d0-c266-4fc4df5f0fff@intel.com \
--to=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).