From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <declan.doherty@intel.com> Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 383A22B92 for <dev@dpdk.org>; Tue, 24 Apr 2018 14:54:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2018 05:54:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,323,1520924400"; d="scan'208";a="34248711" Received: from dwdohert-mobl.ger.corp.intel.com (HELO [163.33.229.45]) ([163.33.229.45]) by fmsmga007.fm.intel.com with ESMTP; 24 Apr 2018 05:54:46 -0700 To: Matan Azrad <matan@mellanox.com> Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>, Thomas Monjalon <thomas@monjalon.net> References: <1522235761-21928-1-git-send-email-matan@mellanox.com> From: "Doherty, Declan" <declan.doherty@intel.com> Message-ID: <98ea4835-98a7-e3d0-c266-4fc4df5f0fff@intel.com> Date: Tue, 24 Apr 2018 13:54:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1522235761-21928-1-git-send-email-matan@mellanox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/bonding: add rte flow support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 24 Apr 2018 12:54:48 -0000 Firstly, apologies on the very large delay on reviewing this. This looks good to me and I've verified that flow configuration propagates as expected to bonded slaves using IXGBE PMDs for testing. I had to do some minor rebasing to get the patch to apply cleanly to next-net, so I'll leave it up to Ferruh on whether he wants a rebased revision of the patch or if he is happy to apply as is and handle the rebasing himself. I will do a v6 of the tunnel encap/decap patchset rebased to this patchset to handle the changes to the rte_flow_query API as I need to send a new revision of that to fix some whitespace issue I added in the last revision of it. Regards Declan On 28/03/2018 12:16 PM, Matan Azrad wrote: > Ethernet devices which are grouped by bonding PMD, aka slaves, are > sharing the same queues and RSS configurations and their Rx burst > functions must be managed by the bonding PMD according to the bonding > architectuer. ^^ typo > > So, it makes sense to configure the same flow rules for all the bond > slaves to allow consistency in packet flow management. > > Add rte flow support to the bonding PMD to manage all flow > configuration to the bonded slaves. > > Signed-off-by: Matan Azrad <matan@mellanox.com> > --- .... > Acked-by: Declan Doherty <declan.doherty@intel.com>