From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FACFA0C45; Thu, 25 Nov 2021 15:40:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 36E8E42708; Thu, 25 Nov 2021 15:40:50 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id D9C83426F2 for ; Thu, 25 Nov 2021 15:40:47 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10178"; a="321758856" X-IronPort-AV: E=Sophos;i="5.87,263,1631602800"; d="scan'208";a="321758856" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2021 06:40:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,263,1631602800"; d="scan'208";a="607587031" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 25 Nov 2021 06:40:46 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 25 Nov 2021 06:40:46 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 25 Nov 2021 06:40:45 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 25 Nov 2021 06:40:45 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 25 Nov 2021 06:40:45 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZK9lTGyxrcev8JGtdMN7cmUYPq/0DfAZgWHcamGMzfaf3fdr+TEE48kIiB8mvuQOVkNFmgBomgjK2YRVgmWxw35gDRufjO8xmkqGGiRv+UhGPT0ibBRzt+Gf5kCLkt+dtQTM60ImAXI3K4RYNycj2kyYJSAYx7GTdZmfkZTt4NHr0PmrstfOXG4HN0C7ZfwHC0cm3NHChbkhxMThbHGTr/d1kVHwOomDDhkob/BumNyg5TnRErKuoPVzk2FOE51seLIzJHwv8QeCS2C+nJD442EOTGe/GUicT29E1GD8l7X4aS8bI5vrJhZmqMNKzdBRFSdDPi71H13N4ULSCxTxPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DZP3HvHhkuMEy08GyzWLGhRRSwBMVNEGdHp0E220L3c=; b=Dm3K3BjetbzJHuz6XYINZV96/RNYVmYeW5LevdQl2QhJM7xVyLOr6FJNzLhnEaTQ0j2oouap96bo+Sr1K1+/pvSUgctoMOGFGzKT6W3K7gl52UOHcp9vfYW9RiBmWhAqdFZDh0D24QUbmH8JfKL0Auvv7ON6wAWVblo/BkQdV7IJK/3na83bOPckQM9JvTrbmRmLNiyr4HKnFk1Ib16jRzjhLK8p8dsSM9CGowvrMzXuOCZ65yVMypLl2IhASA9eBZpQFuYkCc2NIr/77miGYWY30876Os3Fv8gx6uquOJa1pCcN08cGnfGpPvA+8XK9CFlAB5WbN4ureLRE/5ktfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DZP3HvHhkuMEy08GyzWLGhRRSwBMVNEGdHp0E220L3c=; b=dRaOK+ZWVLn02zEkl/++O16EvPlUU8cJdamiw36UApFCLtHhsbyk8drTQ3DRUguuykTtpx8Jjj13l8b/68RTYgOwgKOKJrqWdF2Jh3WAPMe/r7RZqhPNKFAbODIEST3/jYeXcBYbGbcvMNd7DkOrxIab3v1c88N18gJsRqZGLRk= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5927.namprd11.prod.outlook.com (2603:10b6:510:14e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Thu, 25 Nov 2021 14:40:44 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.030; Thu, 25 Nov 2021 14:40:44 +0000 Message-ID: <98f67a1e-bfd1-199e-496a-ad47dc714128@intel.com> Date: Thu, 25 Nov 2021 14:40:37 +0000 Content-Language: en-US To: Slava Ovsiienko , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Andrew Rybchenko , Ajit Khaparde , Somnath Kotur , Rahul Lakkireddy CC: "dev@dpdk.org" , Ori Kam References: <20211123075940.5521-1-viacheslavo@nvidia.com> <20211124153756.12198-1-viacheslavo@nvidia.com> <0e5753c9-85c3-1dc1-69d8-460cb0a7b5a4@intel.com> <1989679.70EXCg8c8L@thomas> From: Ferruh Yigit Subject: Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0001.eurprd04.prod.outlook.com (2603:10a6:10:3b::6) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0001.eurprd04.prod.outlook.com (2603:10a6:10:3b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.20 via Frontend Transport; Thu, 25 Nov 2021 14:40:42 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7138c1d0-9d94-496a-342b-08d9b0218f92 X-MS-TrafficTypeDiagnostic: PH0PR11MB5927: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eJ04BhYkYFLlMWk2oFXRdBPPFjq7kIlt+3gatLAyLSWvgiZadb1UA9YvjuwQNEDZQpwNoIFhNuUasJ3DMI7Rw3rKn/PIxk6zWfkxOtq0YWCmtZgiS7X8+xTZOSmZjU+yfqmwMEym1tGFjEJoxiE8m7ViPAT4GPvng8wXyLlj7zgrMHW4Gh8pnW/mhXMswH7LAqH7ZfbRL46ysTiXxxlH7kaSELiR27nx0dFOgw15TLik1VSPxkYz9fDUFatSFZc9GWr7OGyb9kMS0o+stpAr7WeSVgtWUkh/KK0IL2lc122Y6iuYy+lcSJBBlWNvWzGTiLJaaQGUebIoHAzzw07+8BO5tlW4K5FZsrepgcCfDO51m0NDIgcK0KGEL1tj4wNgJbAM8LvWL9H8fbNudcjpw45UIimjc/j5xbUloKzI9f/kC2llOZjZTWdkUXYXlHGRxPz3qcL06vtj8SIUbyUaKgHKuXFHv9k/7Xbp1/QmpAQzy9/UyoIBrEH5jmA4ZgoCkY5lVTwPQbQqnMnXvKut/2Lcj1k2m+yRjcir9CRsVnswF0b/6M6FwTv188vaDl1zR6nqGGXi6yjas5Rg+2Gk3MEaOkBRrA0B8L8h02pr3Dx7Z024Ae4eqYmILrStt3oYKeNnRA9LCeffv9fK06EQY7GVZXPU7jmeNwU3C5WQH1u47uhcMHaDWvT1FqhW537R63U8aIiQci7l2fb+hxRMIA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(186003)(53546011)(66556008)(8936002)(508600001)(66476007)(316002)(2906002)(82960400001)(44832011)(26005)(6666004)(6486002)(5660300002)(31696002)(2616005)(8676002)(31686004)(83380400001)(38100700002)(956004)(36756003)(16576012)(66946007)(4326008)(86362001)(110136005)(54906003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TkNYWFJQV2ZVZ3NORmVsU1V5Z1hCYWFRTlhmV0tnYjdqU1JKd0JkTWlUT255?= =?utf-8?B?dUs0NWxFMXoxTFl1WFg0ZlAzYU0zemh3d1hqM1BJZXdxY1FQUFVTYW8yaXpE?= =?utf-8?B?T09VUlBnbnFWWWpuSXJaaHVlYVUxQ3lqV3VIUEtadkx2aW4rWnB3bVQwR0s3?= =?utf-8?B?QjhYNG9xQ3FiSzYyK3A0OFlTelFQNlpqZkVJbkV1Tk9ydGRseVJsOC9ubmpx?= =?utf-8?B?VjZTZDRrakxxbWo3dDVyN2tWUW9JcHJUa1FGREU1TG1wQmppSlpzZWhjWUFD?= =?utf-8?B?R3NNOEVKY3haMm9iOWdmd0FOYkVEWmREdHdUVXhGY3lzWit6WnFrTUVSZVBo?= =?utf-8?B?MjJJblZkRVBtcmdhOGVXQXRBcEEyWGxzeklNd1ZGTDRUYU9teEc1Qm1UUnZh?= =?utf-8?B?TjhmN1Rma01ZOWpzU2hKdTlIVGdIN2oxUTNVd2xFVzRXemZ5UHpYOWNuT2U1?= =?utf-8?B?NlE5TXNwYyt2ajhVNzR3YW9lZldOKzRtVmJUeW1YZVlLOVNUOUN3M0p6aUJF?= =?utf-8?B?UFRnbm5qVU41R1RYTG9NeGV6SFFtVmxtUEU2VmI1am5TcUxRM2VwQjNqM1B3?= =?utf-8?B?SWlNeldGZUZQd3JWTDZXbGJ4cHU5d3ZvVkN1c3BwdGJpL0wrTjhSekRMQXZp?= =?utf-8?B?S01DSFNBeDNRdzU3a2Q2VTdZVXM2ZEZKNWo4RUVvYUEwL09RWDEvREExQzdu?= =?utf-8?B?MmtPTGxZOHNwc0hvWEM4alNmMlM2aFU2blAyc3h3SUxSMkxIMEswM1NxYW9E?= =?utf-8?B?UmtBY3hSSGxydmhSd0hIOUJiY29ZcWE4cnFUZXdmeWlSZWhEeWhYS1pIOUVy?= =?utf-8?B?LzNEUGVCK21aaWF1eC9ETGxyTlVFYTNiU2lnS2pDWmtFYlJiWEpsaE9TWFo4?= =?utf-8?B?N01qa09FaVB2WjJrZ0txZWtaSVc1amFvTGRFdUczbGRaaUNLVGluY25tOGVZ?= =?utf-8?B?dk5hZnhINEo4WHREd2hQaEhUVTVNdEFCNXdZSzRuYm5VN3lMS3JOenRLQ21P?= =?utf-8?B?WmRzYXNlUG1HYVNVMCtoR2Y5eVhOSnMxQ1JPTHJHRFl1aUI4b0MxZVhQWEVD?= =?utf-8?B?Wnl1dE9VYlhzWTdtS1FIM1p1UlpLakV4MkZQOWhBbkx2N2pDUE0yTk5WWjBz?= =?utf-8?B?Q1AzTUtVYWloL1MxaGxlN1Y0d0xNWmE0eSt0aDhHWW9SM1d4ZUVyODJoS010?= =?utf-8?B?QnBIeGM2bWFrbVdodklHaGN0aDhNTHZUSlVKeUgvQ1Nka2NyQ3pudUVJcjk0?= =?utf-8?B?NTVqSktqc0FnZG12bzRXZjFoUzFaTFF0Z1lqYlAwT05qT2lVdmlySzFpQlpW?= =?utf-8?B?eUFSVit6dG02VXhOc1NsVlVLdW4yK2dadFZjbkpXZFcrU21POGlKSGpYcDNz?= =?utf-8?B?YVlOMjIySmJ5UFFqLzE2QThZNnUzQzFKYmdTM3lxT2I0OXl4REpxYTFRSWow?= =?utf-8?B?WHhxR3V5U2gwMEExa2trUDZ2YWlUUjBNUStaOTg4czRVU0xVeDc5MWdNT3Fn?= =?utf-8?B?TDBZRVZkeDBEMVppTE95OXVDalhvVlh6MVRNS2EzaDROVDFmL1J6SVp6RFV0?= =?utf-8?B?NVEyZXd2TDR5NmhxNzUrV3ZTOVBrNkx0VkdRYzhPK1d3aXlnaWh0RnppeDFn?= =?utf-8?B?bTErYnpyTjFZV2dnanJEbWZGTTNEblFiajVKOEZDZXpIYVA2MXFWYXN4WnU1?= =?utf-8?B?UUlnOW5vNnRnYjVFREdYVGQ3Ynl5S3pIWGtmeVRRRnNIZVRsYXhkbkFSWklj?= =?utf-8?B?TDAyMmtZTm9GUXFOQWoycnl3MXJYQ0UxTTJlUEtSYkQ4OUdBMm5nVWZqV0w3?= =?utf-8?B?ZU50dmhjTVowdlZMdDBadmE5YlRCU0MvNXBSRjcvaEc3cVRSbEFGeHd2T2sz?= =?utf-8?B?WVB0d3ZtZUgzczZJYzFCUjJjWGE4T1AzWElZR2hVVk9YWE9nTzJIcUJKTnd3?= =?utf-8?B?Vmg1TFdFaDVrWTluaFlIZUhobDZXVGlwbm0yWmNSeHE0eHFsYW1MaUxNVmgv?= =?utf-8?B?NGZsa1k5SlpWdXFDMFpDVnFURUJUeEZ4dzNuQjMvbUVMa3pBZVVLOS9GSDRq?= =?utf-8?B?Y0NxS0lBODhndGRRdy9zWWMvUzllNSttWlU5QnRLajlwR01rb0hYeUFpUkZ4?= =?utf-8?B?Vm51RHZ5eEl3OFI1YmNTRHhGWDhiLzhNT1J4QzdhQitzUlBNV1AxVUVCUXZP?= =?utf-8?Q?FxQt2m21hjaLWD2iMX4ySGo=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7138c1d0-9d94-496a-342b-08d9b0218f92 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2021 14:40:44.0919 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ibliz5at+pfzmKAmqhh5f14IFvMH4sscuc/u7bSAtXogKNTKPtRs6kssXQcwiKcVws1zec/buTzNU76jdl2XrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5927 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/25/2021 2:13 PM, Slava Ovsiienko wrote: >> -----Original Message----- >> From: Thomas Monjalon >> Sent: Thursday, November 25, 2021 15:07 >> To: Andrew Rybchenko ; Ajit Khaparde >> ; Somnath Kotur >> ; Rahul Lakkireddy >> ; Slava Ovsiienko ; >> Ferruh Yigit >> Cc: dev@dpdk.org; Ori Kam >> Subject: Re: [PATCH v3] ethdev: deprecate header fields and metadata flow >> actions >> >> 25/11/2021 12:53, Ferruh Yigit: >>> On 11/24/2021 3:37 PM, Viacheslav Ovsiienko wrote: >>>> The generic RTE_FLOW_ACTION_TYPE_MODIFY_FIELD action was >> introduced >>>> by [1]. This action provides an unified way to perform various >>>> arithmetic and transfer operations over packet network header fields >>>> and packet metadata. >>>> >>>> [1] commit 641dbe4fb053 ("net/mlx5: support modify field flow >>>> action") >>>> >>>> On other side there are a bunch of multiple legacy actions, that can >>>> be superseded by the generic modify field action: >>>> >>>> RTE_FLOW_ACTION_TYPE_OF_SET_MPLS_TTL >>>> RTE_FLOW_ACTION_TYPE_OF_DEC_MPLS_TTL >>>> RTE_FLOW_ACTION_TYPE_OF_SET_NW_TTL >>>> RTE_FLOW_ACTION_TYPE_OF_DEC_NW_TTL sfc >>>> RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_OUT >>>> RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_IN >>>> RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC bnxt, cxgbe, mlx5 >>>> RTE_FLOW_ACTION_TYPE_SET_IPV4_DST bnxt, cxgbe, mlx5 >>>> RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC cxgbe, mlx5 >>>> RTE_FLOW_ACTION_TYPE_SET_IPV6_DST cxgbe, mlx5 >>>> RTE_FLOW_ACTION_TYPE_SET_TP_SRC cxgbe, mlx5 >>>> RTE_FLOW_ACTION_TYPE_SET_TP_DST cxgbe, mlx5 >>>> RTE_FLOW_ACTION_TYPE_DEC_TTL mlx5, sfc >>>> RTE_FLOW_ACTION_TYPE_SET_TTL mlx5 >>>> RTE_FLOW_ACTION_TYPE_SET_MAC_SRC cxgbe, mlx5 >>>> RTE_FLOW_ACTION_TYPE_SET_MAC_DST cxgbe, mlx5 >>>> RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ mlx5 >>>> RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ mlx5 >>>> RTE_FLOW_ACTION_TYPE_INC_TCP_ACK mlx5 >>>> RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK mlx5 >>>> RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP mlx5 >>>> RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP mlx5 >>>> RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID bnxt, cnxk, cxgbe, enic, >>>> mlx5, octeontx2, sfc >>>> RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_PCP bnxt, cnxk, cxgbe, enic, >>>> mlx5, octeontx2, sfc >>>> RTE_FLOW_ACTION_TYPE_SET_TAG mlx5 >>>> RTE_FLOW_ACTION_TYPE_SET_META mlx5 >>>> >>>> This note deprecates the following RTE Flow actions: >>>> 1. As not supported by any of PMDs: >>>> >>>> RTE_FLOW_ACTION_TYPE_OF_SET_MPLS_TTL >>>> RTE_FLOW_ACTION_TYPE_OF_DEC_MPLS_TTL >>>> RTE_FLOW_ACTION_TYPE_OF_SET_NW_TTL >>>> RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_OUT >>>> RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_IN >>>> >>>> 2. As supposed to be replaced by generig field modify action: >>>> RTE_FLOW_ACTION_TYPE_OF_DEC_NW_TTL >>>> RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC >>>> RTE_FLOW_ACTION_TYPE_SET_IPV4_DST >>>> RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC >>>> RTE_FLOW_ACTION_TYPE_SET_IPV6_DST >>>> RTE_FLOW_ACTION_TYPE_SET_TP_SRC >>>> RTE_FLOW_ACTION_TYPE_SET_TP_DST >>>> RTE_FLOW_ACTION_TYPE_DEC_TTL >>>> RTE_FLOW_ACTION_TYPE_SET_TTL >>>> RTE_FLOW_ACTION_TYPE_SET_MAC_SRC >>>> RTE_FLOW_ACTION_TYPE_SET_MAC_DST >>>> RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ >>>> RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ >>>> RTE_FLOW_ACTION_TYPE_INC_TCP_ACK >>>> RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK >>>> RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP >>>> RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP >>>> RTE_FLOW_ACTION_TYPE_SET_TAG >>>> RTE_FLOW_ACTION_TYPE_SET_META >>>> >>>> The VLAN set actions are interrelated to VLAN header >>>> insertion/removal and supported by multiple PMDs and supposed to be >>>> just deprecated but not be removed in 22.11. >>>> >>> >>> Why not remove them for v22.11? Do you think PMDs can't change the >>> existing implementation until 22.11? >>> >>>> Signed-off-by: Viacheslav Ovsiienko >>>> >>>> -- >>>> v2 - deprecation.rst is updated >>>> v3 - doc comments addressed >>>> - commit message comments addressed >>>> - SET_VLAN_VID and SET_VLAN_PCP actions deprecated, but will not >>>> be removed in 22.11 >>> >>> Deprecated symbols are to prevent new code using them, but for this >>> case there is no alternative, since PMDs still don't support >>> 'RTE_FLOW_ACTION_TYPE_MODIFY_FIELD' yet. >> >> This patch is not preventing new code using old actions, there are just >> comments to point to the new direction. >> >>> This patch is forcing users to use deprecated actions (except from mlx). >> >> I don't get it. >> It is encouraging to use the new generic action, which is supported only by >> mlx5 for now. >> >> >>> What about a slight change: >>> 1- In this release, update header/document as >> 'RTE_FLOW_ACTION_TYPE_MODIFY_FIELD' >>> is preferred way if supported. Instead of deprecating old ones. >> >> Deprecation is just a comment, clearly showing that it may be removed in >> future. >> In my opinion, it makes the message simple and clear. >> >> >>> 2- Have an agreement with PMD maintainers to switch to new action before >> v22.11, >>> and don't accept old action implementation in PMDs anymore. >>> Based on agreement update 'deprecation.rst' in this release to note that >>> old actions will be removed on v22.11. >>> (It would be good to have a check to prevent old actions merged >>> during that time.) >> >> Not sure I get it. >> You want to remove VLAN actions? I think it is premature. >> >>> 3- In v22.11, remove old actions, the PMDs that don't support >> MODIFY_FIELD >>> action will lose the feature. >> >> The VLAN actions are probably already used a lot in the field. >> I would consider removing them only if it becomes a burden to maintain. > > +1 > Dropping VLAN might trigger an avalanche of changes in applications - it is supported by multiple PMDs and should be widely engaged. > Other legacy actions are supported by very limited set of drivers and usage area should be smaller, I would say risk is moderate. > Got it, 'SET_VLAN*' is treat differently because its impact can be more. Can we do the same for other implemented actions, support them longer and give more time for deprecation. How big will be the maintenance cost in the PMD?